Re: [PATCH] jump label: pass kbuild_cflags when checking for asm goto support

From	David Lin <dtwlin@google.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] jump label: pass kbuild_cflags when checking for asm goto support
Date	2017-01-02 00:10 +0100
Message-ID	<sUXqh-6F8-3@gated-at.bofh.it> (permalink)
References	<sME1r-1Gv-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

+Cc: Steven Rostedt <rostedt@goodmis.org>
+Cc: Will Deacon <will.deacon@arm.com>

On Fri, Dec 9, 2016 at 4:46 PM, David Lin <dtwlin@google.com> wrote:
> Some versions of ARM GCC compiler such as Android toolchain throws in a
> '-fpic' flag by default. This causes the gcc-goto check script to fail
> although some config would have '-fno-pic' flag in the KBUILD_CFLAGS.
>
> This patch passes the KBUILD_CFLAGS to the check script so that the
> script does not rely on the default config from different compilers.
>
> Signed-off-by: David Lin <dtwlin@google.com>
> ---
>  Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index 694111b..f667daa 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -790,7 +790,7 @@ KBUILD_CFLAGS   += $(call cc-option,-Werror=incompatible-pointer-types)
>  KBUILD_ARFLAGS := $(call ar-option,D)
>
>  # check for 'asm goto'
> -ifeq ($(shell $(CONFIG_SHELL) $(srctree)/scripts/gcc-goto.sh $(CC)), y)
> +ifeq ($(shell $(CONFIG_SHELL) $(srctree)/scripts/gcc-goto.sh $(CC) $(KBUILD_CFLAGS)), y)
>         KBUILD_CFLAGS += -DCC_HAVE_ASM_GOTO
>         KBUILD_AFLAGS += -DCC_HAVE_ASM_GOTO
>  endif
> --
> 2.10.2
>

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] jump label: pass kbuild_cflags when checking for asm goto support David Lin <dtwlin@google.com> - 2017-01-02 00:10 +0100
  Re: [PATCH] jump label: pass kbuild_cflags when checking for asm  goto support Steven Rostedt <rostedt@goodmis.org> - 2017-01-02 20:00 +0100

csiph-web