Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1550753 > unrolled thread

[PATCH v2] dell-wmi, dell-laptop: hide dell-smbios

Started byJean Delvare <jdelvare@suse.de>
First post2017-01-04 14:10 +0100
Last post2017-01-05 10:20 +0100
Articles 7 — 3 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH v2] dell-wmi, dell-laptop: hide dell-smbios Jean Delvare <jdelvare@suse.de> - 2017-01-04 14:10 +0100
    Re: [PATCH v2] dell-wmi, dell-laptop: hide dell-smbios Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-01-04 14:20 +0100
      Re: [PATCH v2] dell-wmi, dell-laptop: hide dell-smbios Jean Delvare <jdelvare@suse.de> - 2017-01-05 09:20 +0100
    Re: [PATCH v2] dell-wmi, dell-laptop: hide dell-smbios Pali Rohár <pali.rohar@gmail.com> - 2017-01-05 10:10 +0100
      Re: [PATCH v2] dell-wmi, dell-laptop: hide dell-smbios Pali Rohár <pali.rohar@gmail.com> - 2017-01-05 10:20 +0100
        Re: [PATCH v2] dell-wmi, dell-laptop: hide dell-smbios Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-01-05 22:20 +0100
      Re: [PATCH v2] dell-wmi, dell-laptop: hide dell-smbios Jean Delvare <jdelvare@suse.de> - 2017-01-05 10:20 +0100

#1550753 — [PATCH v2] dell-wmi, dell-laptop: hide dell-smbios

FromJean Delvare <jdelvare@suse.de>
Date2017-01-04 14:10 +0100
Subject[PATCH v2] dell-wmi, dell-laptop: hide dell-smbios
Message-ID<sVTui-55P-47@gated-at.bofh.it>
Dell-smbios is a helper module, it serves no purpose on its own, so
do not present it as an option to the user. Instead, select it
automatically whenever a driver which needs it is selected.

Signed-off-by: Jean Delvare <jdelvare@suse.de>
Cc: Michał Kępień <kernel@kempniu.pl>
Cc: Pali Rohár <pali.rohar@gmail.com>
Cc: Darren Hart <dvhart@infradead.org>
---
Changes since v1:
 * Select DCDBAS instead of depending on it. This is more
   user-friendly and avoids the confusing transitive dependencies
   which Pali didn't like.

 drivers/platform/x86/Kconfig |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

--- linux-4.10-rc2.orig/drivers/platform/x86/Kconfig	2017-01-01 23:31:53.000000000 +0100
+++ linux-4.10-rc2/drivers/platform/x86/Kconfig	2017-01-04 13:53:41.691262664 +0100
@@ -92,8 +92,8 @@ config ASUS_LAPTOP
 	  If you have an ACPI-compatible ASUS laptop, say Y or M here.
 
 config DELL_SMBIOS
-	tristate "Dell SMBIOS Support"
-	depends on DCDBAS
+	tristate
+	select DCDBAS
 	default n
 	---help---
 	This module provides common functions for kernel modules using
@@ -103,12 +103,12 @@ config DELL_SMBIOS
 
 config DELL_LAPTOP
 	tristate "Dell Laptop Extras"
-	depends on DELL_SMBIOS
 	depends on DMI
 	depends on BACKLIGHT_CLASS_DEVICE
 	depends on ACPI_VIDEO || ACPI_VIDEO = n
 	depends on RFKILL || RFKILL = n
 	depends on SERIO_I8042
+	select DELL_SMBIOS
 	select POWER_SUPPLY
 	select LEDS_CLASS
 	select NEW_LEDS
@@ -123,7 +123,7 @@ config DELL_WMI
 	depends on DMI
 	depends on INPUT
 	depends on ACPI_VIDEO || ACPI_VIDEO = n
-	depends on DELL_SMBIOS
+	select DELL_SMBIOS
 	select INPUT_SPARSEKMAP
 	---help---
 	  Say Y here if you want to support WMI-based hotkeys on Dell laptops.

-- 
Jean Delvare
SUSE L3 Support

[toc] | [next] | [standalone]

#1550764

FromAndy Shevchenko <andy.shevchenko@gmail.com>
Date2017-01-04 14:20 +0100
Message-ID<sVTDY-5aP-23@gated-at.bofh.it>
In reply to#1550753
On Wed, Jan 4, 2017 at 2:59 PM, Jean Delvare <jdelvare@suse.de> wrote:
> Dell-smbios is a helper module, it serves no purpose on its own, so
> do not present it as an option to the user. Instead, select it
> automatically whenever a driver which needs it is selected.
>

Please, use prefix "platform/x86: ".
Perhaps, use just "dell_smbios: " as second one.

>  config DELL_SMBIOS
> -       tristate "Dell SMBIOS Support"
> -       depends on DCDBAS
> +       tristate
> +       select DCDBAS

>         default n

Do we need this one?

-- 
With Best Regards,
Andy Shevchenko

[toc] | [prev] | [next] | [standalone]

#1551735

FromJean Delvare <jdelvare@suse.de>
Date2017-01-05 09:20 +0100
Message-ID<sWbrb-bR-15@gated-at.bofh.it>
In reply to#1550764
Hi Andy,

Thanks for the review.

On Wed, 4 Jan 2017 15:14:10 +0200, Andy Shevchenko wrote:
> On Wed, Jan 4, 2017 at 2:59 PM, Jean Delvare <jdelvare@suse.de> wrote:
> > Dell-smbios is a helper module, it serves no purpose on its own, so
> > do not present it as an option to the user. Instead, select it
> > automatically whenever a driver which needs it is selected.
> >
> 
> Please, use prefix "platform/x86: ".
> Perhaps, use just "dell_smbios: " as second one.

OK, will change.

> >  config DELL_SMBIOS
> > -       tristate "Dell SMBIOS Support"
> > -       depends on DCDBAS
> > +       tristate
> > +       select DCDBAS
> 
> >         default n
> 
> Do we need this one?

Probably not. "n" being the default default, I guess the 844
occurrences of "default n" in the Kconfig tree are pointless ;-)

I'll post v3 of the patch in a minute.

-- 
Jean Delvare
SUSE L3 Support

[toc] | [prev] | [next] | [standalone]

#1551779

FromPali Rohár <pali.rohar@gmail.com>
Date2017-01-05 10:10 +0100
Message-ID<sWcdA-Is-19@gated-at.bofh.it>
In reply to#1550753
On Wednesday 04 January 2017 13:59:17 Jean Delvare wrote:
> Dell-smbios is a helper module, it serves no purpose on its own, so
> do not present it as an option to the user. Instead, select it
> automatically whenever a driver which needs it is selected.
> 
> Signed-off-by: Jean Delvare <jdelvare@suse.de>
> Cc: Michał Kępień <kernel@kempniu.pl>
> Cc: Pali Rohár <pali.rohar@gmail.com>
> Cc: Darren Hart <dvhart@infradead.org>
> ---
> Changes since v1:
>  * Select DCDBAS instead of depending on it. This is more
>    user-friendly and avoids the confusing transitive dependencies
>    which Pali didn't like.

Hi! I see that in previous email you CCed Yann and linux-kbuild, but I
do not see any response in my mailbox. Have you got some answer?

-- 
Pali Rohár
pali.rohar@gmail.com

[toc] | [prev] | [next] | [standalone]

#1551793

FromPali Rohár <pali.rohar@gmail.com>
Date2017-01-05 10:20 +0100
Message-ID<sWcng-N9-13@gated-at.bofh.it>
In reply to#1551779
On Thursday 05 January 2017 10:09:03 Jean Delvare wrote:
> Hi Pali,
> 
> On Thu, 5 Jan 2017 09:59:39 +0100, Pali Rohár wrote:
> > On Wednesday 04 January 2017 13:59:17 Jean Delvare wrote:
> > > Dell-smbios is a helper module, it serves no purpose on its own, so
> > > do not present it as an option to the user. Instead, select it
> > > automatically whenever a driver which needs it is selected.
> > > 
> > > Signed-off-by: Jean Delvare <jdelvare@suse.de>
> > > Cc: Michał Kępień <kernel@kempniu.pl>
> > > Cc: Pali Rohár <pali.rohar@gmail.com>
> > > Cc: Darren Hart <dvhart@infradead.org>
> > > ---
> > > Changes since v1:
> > >  * Select DCDBAS instead of depending on it. This is more
> > >    user-friendly and avoids the confusing transitive dependencies
> > >    which Pali didn't like.
> > 
> > Hi! I see that in previous email you CCed Yann and linux-kbuild, (...)
> 
> No, I did not. What are you talking about? I'm confused.

Ah, Darren (not you) CCed linux-kbuild under thread for v1 of your patches.

-- 
Pali Rohár
pali.rohar@gmail.com

[toc] | [prev] | [next] | [standalone]

#1552336

FromAndy Shevchenko <andy.shevchenko@gmail.com>
Date2017-01-05 22:20 +0100
Message-ID<sWnC1-4Y-11@gated-at.bofh.it>
In reply to#1551793
On Thu, Jan 5, 2017 at 11:10 AM, Pali Rohár <pali.rohar@gmail.com> wrote:
> On Thursday 05 January 2017 10:09:03 Jean Delvare wrote:
>> > Hi! I see that in previous email you CCed Yann and linux-kbuild, (...)
>>
>> No, I did not. What are you talking about? I'm confused.
>
> Ah, Darren (not you) CCed linux-kbuild under thread for v1 of your patches.

I have pushed v3 to testing and it passes kbuild bot tests.

-- 
With Best Regards,
Andy Shevchenko

[toc] | [prev] | [next] | [standalone]

#1551794

FromJean Delvare <jdelvare@suse.de>
Date2017-01-05 10:20 +0100
Message-ID<sWcng-N9-5@gated-at.bofh.it>
In reply to#1551779
Hi Pali,

On Thu, 5 Jan 2017 09:59:39 +0100, Pali Rohár wrote:
> On Wednesday 04 January 2017 13:59:17 Jean Delvare wrote:
> > Dell-smbios is a helper module, it serves no purpose on its own, so
> > do not present it as an option to the user. Instead, select it
> > automatically whenever a driver which needs it is selected.
> > 
> > Signed-off-by: Jean Delvare <jdelvare@suse.de>
> > Cc: Michał Kępień <kernel@kempniu.pl>
> > Cc: Pali Rohár <pali.rohar@gmail.com>
> > Cc: Darren Hart <dvhart@infradead.org>
> > ---
> > Changes since v1:
> >  * Select DCDBAS instead of depending on it. This is more
> >    user-friendly and avoids the confusing transitive dependencies
> >    which Pali didn't like.
> 
> Hi! I see that in previous email you CCed Yann and linux-kbuild, (...)

No, I did not. What are you talking about? I'm confused.

-- 
Jean Delvare
SUSE L3 Support

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web