Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1551735

Re: [PATCH v2] dell-wmi, dell-laptop: hide dell-smbios

From Jean Delvare <jdelvare@suse.de>
Newsgroups linux.kernel
Subject Re: [PATCH v2] dell-wmi, dell-laptop: hide dell-smbios
Date 2017-01-05 09:20 +0100
Message-ID <sWbrb-bR-15@gated-at.bofh.it> (permalink)
References <sVTui-55P-47@gated-at.bofh.it> <sVTDY-5aP-23@gated-at.bofh.it>
Organization SUSE Linux

Show all headers | View raw

Hi Andy,

Thanks for the review.

On Wed, 4 Jan 2017 15:14:10 +0200, Andy Shevchenko wrote:
> On Wed, Jan 4, 2017 at 2:59 PM, Jean Delvare <jdelvare@suse.de> wrote:
> > Dell-smbios is a helper module, it serves no purpose on its own, so
> > do not present it as an option to the user. Instead, select it
> > automatically whenever a driver which needs it is selected.
> >
> 
> Please, use prefix "platform/x86: ".
> Perhaps, use just "dell_smbios: " as second one.

OK, will change.

> >  config DELL_SMBIOS
> > -       tristate "Dell SMBIOS Support"
> > -       depends on DCDBAS
> > +       tristate
> > +       select DCDBAS
> 
> >         default n
> 
> Do we need this one?

Probably not. "n" being the default default, I guess the 844
occurrences of "default n" in the Kconfig tree are pointless ;-)

I'll post v3 of the patch in a minute.

-- 
Jean Delvare
SUSE L3 Support

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2] dell-wmi, dell-laptop: hide dell-smbios Jean Delvare <jdelvare@suse.de> - 2017-01-04 14:10 +0100
  Re: [PATCH v2] dell-wmi, dell-laptop: hide dell-smbios Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-01-04 14:20 +0100
    Re: [PATCH v2] dell-wmi, dell-laptop: hide dell-smbios Jean Delvare <jdelvare@suse.de> - 2017-01-05 09:20 +0100
  Re: [PATCH v2] dell-wmi, dell-laptop: hide dell-smbios Pali Rohár <pali.rohar@gmail.com> - 2017-01-05 10:10 +0100
    Re: [PATCH v2] dell-wmi, dell-laptop: hide dell-smbios Pali Rohár <pali.rohar@gmail.com> - 2017-01-05 10:20 +0100
      Re: [PATCH v2] dell-wmi, dell-laptop: hide dell-smbios Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-01-05 22:20 +0100
    Re: [PATCH v2] dell-wmi, dell-laptop: hide dell-smbios Jean Delvare <jdelvare@suse.de> - 2017-01-05 10:20 +0100

csiph-web