Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1547585 > unrolled thread
| Started by | Linus Walleij <linus.walleij@linaro.org> |
|---|---|
| First post | 2016-12-27 13:50 +0100 |
| Last post | 2016-12-30 14:10 +0100 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH V1] pinctrl:pxa:pinctrl-pxa2xx:- No need of devm functions Linus Walleij <linus.walleij@linaro.org> - 2016-12-27 13:50 +0100
Re: [PATCH V1] pinctrl:pxa:pinctrl-pxa2xx:- No need of devm functions Robert Jarzmik <robert.jarzmik@free.fr> - 2016-12-29 08:30 +0100
Re: [PATCH V1] pinctrl:pxa:pinctrl-pxa2xx:- No need of devm functions Linus Walleij <linus.walleij@linaro.org> - 2016-12-30 14:10 +0100
| From | Linus Walleij <linus.walleij@linaro.org> |
|---|---|
| Date | 2016-12-27 13:50 +0100 |
| Subject | Re: [PATCH V1] pinctrl:pxa:pinctrl-pxa2xx:- No need of devm functions |
| Message-ID | <sSZmx-262-9@gated-at.bofh.it> |
On Thu, Dec 8, 2016 at 3:35 PM, Arvind Yadav <arvind.yadav.cs@gmail.com> wrote: > In functions pxa2xx_build_functions, the memory allocated for > 'functions' is live within the function only. After the > allocation it is immediately freed with devm_kfree. There is > no need to allocate memory for 'functions' with devm function > so replace devm_kcalloc with kcalloc and devm_kfree with kfree. > > Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> I want the maintainer Robert Jarzmik to review this before I do anything with it. Yours, Linus Walleij
[toc] | [next] | [standalone]
| From | Robert Jarzmik <robert.jarzmik@free.fr> |
|---|---|
| Date | 2016-12-29 08:30 +0100 |
| Message-ID | <sTDjX-3B9-17@gated-at.bofh.it> |
| In reply to | #1547585 |
Linus Walleij <linus.walleij@linaro.org> writes: > On Thu, Dec 8, 2016 at 3:35 PM, Arvind Yadav <arvind.yadav.cs@gmail.com> wrote: > >> In functions pxa2xx_build_functions, the memory allocated for >> 'functions' is live within the function only. After the >> allocation it is immediately freed with devm_kfree. There is >> no need to allocate memory for 'functions' with devm function >> so replace devm_kcalloc with kcalloc and devm_kfree with kfree. >> >> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> > > I want the maintainer Robert Jarzmik to review this before I do anything Hi Linus, I did review, on December the 10th. I wasn't very enthusiastic about the patch, if you check back my reply. Cheers. -- Robert
[toc] | [prev] | [next] | [standalone]
| From | Linus Walleij <linus.walleij@linaro.org> |
|---|---|
| Date | 2016-12-30 14:10 +0100 |
| Message-ID | <sU56x-4KU-13@gated-at.bofh.it> |
| In reply to | #1548212 |
On Thu, Dec 29, 2016 at 8:20 AM, Robert Jarzmik <robert.jarzmik@free.fr> wrote: > Linus Walleij <linus.walleij@linaro.org> writes: > >> On Thu, Dec 8, 2016 at 3:35 PM, Arvind Yadav <arvind.yadav.cs@gmail.com> wrote: >> >>> In functions pxa2xx_build_functions, the memory allocated for >>> 'functions' is live within the function only. After the >>> allocation it is immediately freed with devm_kfree. There is >>> no need to allocate memory for 'functions' with devm function >>> so replace devm_kcalloc with kcalloc and devm_kfree with kfree. >>> >>> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> >> >> I want the maintainer Robert Jarzmik to review this before I do anything > > Hi Linus, > > I did review, on December the 10th. I wasn't very enthusiastic about the patch, > if you check back my reply. Sorry I missed it (mail overload as usual). OK dropping this. Yours, Linus Walleij
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web