Re: [PATCH V1] pinctrl:pxa:pinctrl-pxa2xx:- No need of devm functions

From	Linus Walleij <linus.walleij@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH V1] pinctrl:pxa:pinctrl-pxa2xx:- No need of devm functions
Date	2016-12-30 14:10 +0100
Message-ID	<sU56x-4KU-13@gated-at.bofh.it> (permalink)
References	<sM81z-7fI-9@gated-at.bofh.it> <sSZmx-262-9@gated-at.bofh.it> <sTDjX-3B9-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Dec 29, 2016 at 8:20 AM, Robert Jarzmik <robert.jarzmik@free.fr> wrote:
> Linus Walleij <linus.walleij@linaro.org> writes:
>
>> On Thu, Dec 8, 2016 at 3:35 PM, Arvind Yadav <arvind.yadav.cs@gmail.com> wrote:
>>
>>> In functions pxa2xx_build_functions, the memory allocated for
>>> 'functions' is live within the function only. After the
>>> allocation it is immediately freed with devm_kfree. There is
>>> no need to allocate memory for 'functions' with devm function
>>> so replace devm_kcalloc  with kcalloc and devm_kfree with kfree.
>>>
>>> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
>>
>> I want the maintainer Robert Jarzmik to review this before I do anything
>
> Hi Linus,
>
> I did review, on December the 10th. I wasn't very enthusiastic about the patch,
> if you check back my reply.

Sorry I missed it (mail overload as usual).

OK dropping this.

Yours,
Linus Walleij

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH V1] pinctrl:pxa:pinctrl-pxa2xx:- No need of devm functions Linus Walleij <linus.walleij@linaro.org> - 2016-12-27 13:50 +0100
  Re: [PATCH V1] pinctrl:pxa:pinctrl-pxa2xx:- No need of devm functions Robert Jarzmik <robert.jarzmik@free.fr> - 2016-12-29 08:30 +0100
    Re: [PATCH V1] pinctrl:pxa:pinctrl-pxa2xx:- No need of devm functions Linus Walleij <linus.walleij@linaro.org> - 2016-12-30 14:10 +0100

csiph-web