Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1541949 > unrolled thread
| Started by | zhongjiang <zhongjiang@huawei.com> |
|---|---|
| First post | 2016-12-14 15:40 +0100 |
| Last post | 2016-12-16 15:20 +0100 |
| Articles | 5 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[RESEND PATCH 2/2] arm64: make WANT_HUGE_PMD_SHARE depends on HUGETLB_PAGE zhongjiang <zhongjiang@huawei.com> - 2016-12-14 15:40 +0100
Re: [RESEND PATCH 2/2] arm64: make WANT_HUGE_PMD_SHARE depends on HUGETLB_PAGE zhong jiang <zhongjiang@huawei.com> - 2016-12-16 10:20 +0100
Re: [RESEND PATCH 2/2] arm64: make WANT_HUGE_PMD_SHARE depends on HUGETLB_PAGE Will Deacon <will.deacon@arm.com> - 2016-12-16 13:40 +0100
Re: [RESEND PATCH 2/2] arm64: make WANT_HUGE_PMD_SHARE depends on HUGETLB_PAGE zhong jiang <zhongjiang@huawei.com> - 2016-12-16 14:10 +0100
Re: [RESEND PATCH 2/2] arm64: make WANT_HUGE_PMD_SHARE depends on HUGETLB_PAGE zhong jiang <zhongjiang@huawei.com> - 2016-12-16 15:20 +0100
| From | zhongjiang <zhongjiang@huawei.com> |
|---|---|
| Date | 2016-12-14 15:40 +0100 |
| Subject | [RESEND PATCH 2/2] arm64: make WANT_HUGE_PMD_SHARE depends on HUGETLB_PAGE |
| Message-ID | <sOiSR-7Aq-17@gated-at.bofh.it> |
From: zhong jiang <zhongjiang@huawei.com> when HUGETLB_PAGE is disable, WANT_HUGE_PMD_SHARE contains the fuctions should not be use. therefore, we add the dependency. Signed-off-by: zhong jiang <zhongjiang@huawei.com> --- arch/arm64/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig index 969ef88..694ca73 100644 --- a/arch/arm64/Kconfig +++ b/arch/arm64/Kconfig @@ -640,6 +640,7 @@ config SYS_SUPPORTS_HUGETLBFS config ARCH_WANT_HUGE_PMD_SHARE def_bool y if ARM64_4K_PAGES || (ARM64_16K_PAGES && !ARM64_VA_BITS_36) + depends on HUGETLB_PAGE config ARCH_HAS_CACHE_LINE_SIZE def_bool y -- 1.8.3.1
[toc] | [next] | [standalone]
| From | zhong jiang <zhongjiang@huawei.com> |
|---|---|
| Date | 2016-12-16 10:20 +0100 |
| Subject | Re: [RESEND PATCH 2/2] arm64: make WANT_HUGE_PMD_SHARE depends on HUGETLB_PAGE |
| Message-ID | <sOWQi-1zp-15@gated-at.bofh.it> |
| In reply to | #1541949 |
On 2016/12/14 22:19, zhongjiang wrote:
> From: zhong jiang <zhongjiang@huawei.com>
>
> when HUGETLB_PAGE is disable, WANT_HUGE_PMD_SHARE contains the
> fuctions should not be use. therefore, we add the dependency.
>
> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
> ---
> arch/arm64/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
> index 969ef88..694ca73 100644
> --- a/arch/arm64/Kconfig
> +++ b/arch/arm64/Kconfig
> @@ -640,6 +640,7 @@ config SYS_SUPPORTS_HUGETLBFS
>
> config ARCH_WANT_HUGE_PMD_SHARE
> def_bool y if ARM64_4K_PAGES || (ARM64_16K_PAGES && !ARM64_VA_BITS_36)
> + depends on HUGETLB_PAGE
>
> config ARCH_HAS_CACHE_LINE_SIZE
> def_bool y
Hi,
I still think it is a issue. Perhaps above changelog is unclear. Further explain is as follows.
when hugetlb_pages is disable and arch_want_huge_pmd_share is enable, we maybe call
huge_pmd_sahre in hugetlbpage.c, but the function actually is not definition as it is not
exported. is it right ??
Thanks
zhongjiang
[toc] | [prev] | [next] | [standalone]
| From | Will Deacon <will.deacon@arm.com> |
|---|---|
| Date | 2016-12-16 13:40 +0100 |
| Subject | Re: [RESEND PATCH 2/2] arm64: make WANT_HUGE_PMD_SHARE depends on HUGETLB_PAGE |
| Message-ID | <sOZXP-3A4-7@gated-at.bofh.it> |
| In reply to | #1543287 |
On Fri, Dec 16, 2016 at 05:10:05PM +0800, zhong jiang wrote: > On 2016/12/14 22:19, zhongjiang wrote: > > From: zhong jiang <zhongjiang@huawei.com> > > > > when HUGETLB_PAGE is disable, WANT_HUGE_PMD_SHARE contains the > > fuctions should not be use. therefore, we add the dependency. > > > > Signed-off-by: zhong jiang <zhongjiang@huawei.com> > > --- > > arch/arm64/Kconfig | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig > > index 969ef88..694ca73 100644 > > --- a/arch/arm64/Kconfig > > +++ b/arch/arm64/Kconfig > > @@ -640,6 +640,7 @@ config SYS_SUPPORTS_HUGETLBFS > > > > config ARCH_WANT_HUGE_PMD_SHARE > > def_bool y if ARM64_4K_PAGES || (ARM64_16K_PAGES && !ARM64_VA_BITS_36) > > + depends on HUGETLB_PAGE > > > > config ARCH_HAS_CACHE_LINE_SIZE > > def_bool y > Hi, > I still think it is a issue. Perhaps above changelog is unclear. Further explain is as follows. > when hugetlb_pages is disable and arch_want_huge_pmd_share is enable, we maybe call > huge_pmd_sahre in hugetlbpage.c, but the function actually is not definition as it is not > exported. is it right ?? The only users of ARCH_WANT_HUGE_PMD_SHARE on arm64 are: arch/arm64/mm/hugetlbpage.c: if (IS_ENABLED(CONFIG_ARCH_WANT_HUGE_PMD_SHARE) && mm/hugetlb.c:#ifdef CONFIG_ARCH_WANT_HUGE_PMD_SHARE mm/hugetlb.c:#else /* !CONFIG_ARCH_WANT_HUGE_PMD_SHARE */ mm/hugetlb.c:#endif /* CONFIG_ARCH_WANT_HUGE_PMD_SHARE */ and neither of those files are compiled if !HUGETLB_PAGE. Are you actually seeing a problem here? Will
[toc] | [prev] | [next] | [standalone]
| From | zhong jiang <zhongjiang@huawei.com> |
|---|---|
| Date | 2016-12-16 14:10 +0100 |
| Subject | Re: [RESEND PATCH 2/2] arm64: make WANT_HUGE_PMD_SHARE depends on HUGETLB_PAGE |
| Message-ID | <sP0qS-42X-3@gated-at.bofh.it> |
| In reply to | #1543428 |
On 2016/12/16 20:35, Will Deacon wrote: > On Fri, Dec 16, 2016 at 05:10:05PM +0800, zhong jiang wrote: >> On 2016/12/14 22:19, zhongjiang wrote: >>> From: zhong jiang <zhongjiang@huawei.com> >>> >>> when HUGETLB_PAGE is disable, WANT_HUGE_PMD_SHARE contains the >>> fuctions should not be use. therefore, we add the dependency. >>> >>> Signed-off-by: zhong jiang <zhongjiang@huawei.com> >>> --- >>> arch/arm64/Kconfig | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig >>> index 969ef88..694ca73 100644 >>> --- a/arch/arm64/Kconfig >>> +++ b/arch/arm64/Kconfig >>> @@ -640,6 +640,7 @@ config SYS_SUPPORTS_HUGETLBFS >>> >>> config ARCH_WANT_HUGE_PMD_SHARE >>> def_bool y if ARM64_4K_PAGES || (ARM64_16K_PAGES && !ARM64_VA_BITS_36) >>> + depends on HUGETLB_PAGE >>> >>> config ARCH_HAS_CACHE_LINE_SIZE >>> def_bool y >> Hi, >> I still think it is a issue. Perhaps above changelog is unclear. Further explain is as follows. >> when hugetlb_pages is disable and arch_want_huge_pmd_share is enable, we maybe call >> huge_pmd_sahre in hugetlbpage.c, but the function actually is not definition as it is not >> exported. is it right ?? > The only users of ARCH_WANT_HUGE_PMD_SHARE on arm64 are: > > arch/arm64/mm/hugetlbpage.c: if (IS_ENABLED(CONFIG_ARCH_WANT_HUGE_PMD_SHARE) && yes > mm/hugetlb.c:#ifdef CONFIG_ARCH_WANT_HUGE_PMD_SHARE > mm/hugetlb.c:#else /* !CONFIG_ARCH_WANT_HUGE_PMD_SHARE */ > mm/hugetlb.c:#endif /* CONFIG_ARCH_WANT_HUGE_PMD_SHARE */ > > and neither of those files are compiled if !HUGETLB_PAGE. Indeed, but The only users maybe use it if !HUGETLB_PAGE. because include/linux/hugetlb.h can not export the reference if !HUGETLB_PAGE. IOW, the function is not definition. is it right ? or I miss the key point. > Are you actually seeing a problem here? I review the code and find the issue. Thanks zhongjiang > Will > > . >
[toc] | [prev] | [next] | [standalone]
| From | zhong jiang <zhongjiang@huawei.com> |
|---|---|
| Date | 2016-12-16 15:20 +0100 |
| Subject | Re: [RESEND PATCH 2/2] arm64: make WANT_HUGE_PMD_SHARE depends on HUGETLB_PAGE |
| Message-ID | <sP1wC-4Nh-9@gated-at.bofh.it> |
| In reply to | #1543428 |
On 2016/12/16 20:35, Will Deacon wrote: > On Fri, Dec 16, 2016 at 05:10:05PM +0800, zhong jiang wrote: >> On 2016/12/14 22:19, zhongjiang wrote: >>> From: zhong jiang <zhongjiang@huawei.com> >>> >>> when HUGETLB_PAGE is disable, WANT_HUGE_PMD_SHARE contains the >>> fuctions should not be use. therefore, we add the dependency. >>> >>> Signed-off-by: zhong jiang <zhongjiang@huawei.com> >>> --- >>> arch/arm64/Kconfig | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig >>> index 969ef88..694ca73 100644 >>> --- a/arch/arm64/Kconfig >>> +++ b/arch/arm64/Kconfig >>> @@ -640,6 +640,7 @@ config SYS_SUPPORTS_HUGETLBFS >>> >>> config ARCH_WANT_HUGE_PMD_SHARE >>> def_bool y if ARM64_4K_PAGES || (ARM64_16K_PAGES && !ARM64_VA_BITS_36) >>> + depends on HUGETLB_PAGE >>> >>> config ARCH_HAS_CACHE_LINE_SIZE >>> def_bool y >> Hi, >> I still think it is a issue. Perhaps above changelog is unclear. Further explain is as follows. >> when hugetlb_pages is disable and arch_want_huge_pmd_share is enable, we maybe call >> huge_pmd_sahre in hugetlbpage.c, but the function actually is not definition as it is not >> exported. is it right ?? > The only users of ARCH_WANT_HUGE_PMD_SHARE on arm64 are: > > arch/arm64/mm/hugetlbpage.c: if (IS_ENABLED(CONFIG_ARCH_WANT_HUGE_PMD_SHARE) && > mm/hugetlb.c:#ifdef CONFIG_ARCH_WANT_HUGE_PMD_SHARE > mm/hugetlb.c:#else /* !CONFIG_ARCH_WANT_HUGE_PMD_SHARE */ > mm/hugetlb.c:#endif /* CONFIG_ARCH_WANT_HUGE_PMD_SHARE */ > > and neither of those files are compiled if !HUGETLB_PAGE. > > Are you actually seeing a problem here? > > Will > > . > I got it. Please forget the stupid patch and my stupid comments. but the first patch look reasonable. Is it accepted ? Thanks zhongjiang
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web