Re: [RESEND PATCH 2/2] arm64: make WANT_HUGE_PMD_SHARE depends on HUGETLB_PAGE

From	Will Deacon <will.deacon@arm.com>
Newsgroups	linux.kernel
Subject	Re: [RESEND PATCH 2/2] arm64: make WANT_HUGE_PMD_SHARE depends on HUGETLB_PAGE
Date	2016-12-16 13:40 +0100
Message-ID	<sOZXP-3A4-7@gated-at.bofh.it> (permalink)
References	<sOiSR-7Aq-19@gated-at.bofh.it> <sOiSR-7Aq-17@gated-at.bofh.it> <sOWQi-1zp-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Dec 16, 2016 at 05:10:05PM +0800, zhong jiang wrote:
> On 2016/12/14 22:19, zhongjiang wrote:
> > From: zhong jiang <zhongjiang@huawei.com>
> >
> > when HUGETLB_PAGE is disable, WANT_HUGE_PMD_SHARE contains the
> > fuctions should not be use. therefore, we add the dependency.
> >
> > Signed-off-by: zhong jiang <zhongjiang@huawei.com>
> > ---
> >  arch/arm64/Kconfig | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
> > index 969ef88..694ca73 100644
> > --- a/arch/arm64/Kconfig
> > +++ b/arch/arm64/Kconfig
> > @@ -640,6 +640,7 @@ config SYS_SUPPORTS_HUGETLBFS
> >  
> >  config ARCH_WANT_HUGE_PMD_SHARE
> >  	def_bool y if ARM64_4K_PAGES || (ARM64_16K_PAGES && !ARM64_VA_BITS_36)
> > +	depends on HUGETLB_PAGE
> >  
> >  config ARCH_HAS_CACHE_LINE_SIZE
> >  	def_bool y
> Hi,
>       I still think it is a issue. Perhaps above changelog is unclear.  Further explain is as follows.
>  when hugetlb_pages is disable and arch_want_huge_pmd_share is enable,   we maybe call
>  huge_pmd_sahre in hugetlbpage.c, but the function actually is not definition as it is not
>  exported.  is it right ??

The only users of ARCH_WANT_HUGE_PMD_SHARE on arm64 are:

arch/arm64/mm/hugetlbpage.c:            if (IS_ENABLED(CONFIG_ARCH_WANT_HUGE_PMD_SHARE) &&
mm/hugetlb.c:#ifdef CONFIG_ARCH_WANT_HUGE_PMD_SHARE
mm/hugetlb.c:#else /* !CONFIG_ARCH_WANT_HUGE_PMD_SHARE */
mm/hugetlb.c:#endif /* CONFIG_ARCH_WANT_HUGE_PMD_SHARE */

and neither of those files are compiled if !HUGETLB_PAGE.

Are you actually seeing a problem here?

Will

Thread

[RESEND PATCH 2/2] arm64: make WANT_HUGE_PMD_SHARE depends on HUGETLB_PAGE zhongjiang <zhongjiang@huawei.com> - 2016-12-14 15:40 +0100
  Re: [RESEND PATCH 2/2] arm64: make WANT_HUGE_PMD_SHARE depends on  HUGETLB_PAGE zhong jiang <zhongjiang@huawei.com> - 2016-12-16 10:20 +0100
    Re: [RESEND PATCH 2/2] arm64: make WANT_HUGE_PMD_SHARE depends on  HUGETLB_PAGE Will Deacon <will.deacon@arm.com> - 2016-12-16 13:40 +0100
      Re: [RESEND PATCH 2/2] arm64: make WANT_HUGE_PMD_SHARE depends on  HUGETLB_PAGE zhong jiang <zhongjiang@huawei.com> - 2016-12-16 14:10 +0100
      Re: [RESEND PATCH 2/2] arm64: make WANT_HUGE_PMD_SHARE depends on  HUGETLB_PAGE zhong jiang <zhongjiang@huawei.com> - 2016-12-16 15:20 +0100

csiph-web