Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1543183 > unrolled thread
| Started by | Linus Torvalds <torvalds@linux-foundation.org> |
|---|---|
| First post | 2016-12-16 03:30 +0100 |
| Last post | 2016-12-16 18:40 +0100 |
| Articles | 4 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PULL] virtio, vhost: new device, fixes, speedups Linus Torvalds <torvalds@linux-foundation.org> - 2016-12-16 03:30 +0100
Re: [PULL] virtio, vhost: new device, fixes, speedups Paolo Bonzini <pbonzini@redhat.com> - 2016-12-16 11:20 +0100
Re: [PULL] virtio, vhost: new device, fixes, speedups "Michael S. Tsirkin" <mst@redhat.com> - 2016-12-16 18:10 +0100
Re: [PULL] virtio, vhost: new device, fixes, speedups Linus Torvalds <torvalds@linux-foundation.org> - 2016-12-16 18:40 +0100
| From | Linus Torvalds <torvalds@linux-foundation.org> |
|---|---|
| Date | 2016-12-16 03:30 +0100 |
| Subject | Re: [PULL] virtio, vhost: new device, fixes, speedups |
| Message-ID | <sOQrv-5vu-1@gated-at.bofh.it> |
On Thu, Dec 15, 2016 at 3:05 PM, Michael S. Tsirkin <mst@redhat.com> wrote:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git tags/for_linus
Pulled, but I wonder...
> Documentation/translations/zh_CN/sparse.txt | 7 +-
> arch/arm/plat-samsung/include/plat/gpio-cfg.h | 2 +-
> drivers/crypto/virtio/virtio_crypto_common.h | 128 +++++
[...]
what are you generating these diffstats with? Because they are pretty bogus..
The end result is correct:
> 86 files changed, 2106 insertions(+), 280 deletions(-)
but the file order in the diffstat is completely random, which makes
it very hard to compare with what I get. It also makes it hard to see
what you changed, because it's not alphabetical like it should be
(strictly speaking the git pathname ordering isnt' really
alphabetical, since the '/' sorts as the NUL character, but close
enough).
I can't see the logic to the re-ordering of the lines, so I'm
intrigued how you even generated it.
Linus
[toc] | [next] | [standalone]
| From | Paolo Bonzini <pbonzini@redhat.com> |
|---|---|
| Date | 2016-12-16 11:20 +0100 |
| Message-ID | <sOXMm-2df-23@gated-at.bofh.it> |
| In reply to | #1543183 |
On 16/12/2016 03:20, Linus Torvalds wrote: > On Thu, Dec 15, 2016 at 3:05 PM, Michael S. Tsirkin <mst@redhat.com> wrote: >> >> git://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git tags/for_linus > > Pulled, but I wonder... > >> Documentation/translations/zh_CN/sparse.txt | 7 +- >> arch/arm/plat-samsung/include/plat/gpio-cfg.h | 2 +- >> drivers/crypto/virtio/virtio_crypto_common.h | 128 +++++ > [...] > > what are you generating these diffstats with? Because they are pretty bogus.. > > The end result is correct: > >> 86 files changed, 2106 insertions(+), 280 deletions(-) > > but the file order in the diffstat is completely random, which makes > it very hard to compare with what I get. It also makes it hard to see > what you changed, because it's not alphabetical like it should be > (strictly speaking the git pathname ordering isnt' really > alphabetical, since the '/' sorts as the NUL character, but close > enough). > > I can't see the logic to the re-ordering of the lines, so I'm > intrigued how you even generated it. Looks like a diff.orderFile that places .h and .txt first, then .c, then Makefile. I've seen others propose it. Paolo
[toc] | [prev] | [next] | [standalone]
| From | "Michael S. Tsirkin" <mst@redhat.com> |
|---|---|
| Date | 2016-12-16 18:10 +0100 |
| Message-ID | <sP4b7-6vt-9@gated-at.bofh.it> |
| In reply to | #1543183 |
On Thu, Dec 15, 2016 at 06:20:40PM -0800, Linus Torvalds wrote: > On Thu, Dec 15, 2016 at 3:05 PM, Michael S. Tsirkin <mst@redhat.com> wrote: > > > > git://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git tags/for_linus > > Pulled, but I wonder... > > > Documentation/translations/zh_CN/sparse.txt | 7 +- > > arch/arm/plat-samsung/include/plat/gpio-cfg.h | 2 +- > > drivers/crypto/virtio/virtio_crypto_common.h | 128 +++++ > [...] > > what are you generating these diffstats with? Because they are pretty bogus.. > > The end result is correct: > > > 86 files changed, 2106 insertions(+), 280 deletions(-) > > but the file order in the diffstat is completely random, which makes > it very hard to compare with what I get. It also makes it hard to see > what you changed, because it's not alphabetical like it should be > (strictly speaking the git pathname ordering isnt' really > alphabetical, since the '/' sorts as the NUL character, but close > enough). > > I can't see the logic to the re-ordering of the lines, so I'm > intrigued how you even generated it. > > Linus Oh, that's because I set orderfile globally rather than just for the qemu project which wants it. Fixed, sorry about that. -- MST
[toc] | [prev] | [next] | [standalone]
| From | Linus Torvalds <torvalds@linux-foundation.org> |
|---|---|
| Date | 2016-12-16 18:40 +0100 |
| Message-ID | <sP4Ea-6Gh-13@gated-at.bofh.it> |
| In reply to | #1543599 |
On Fri, Dec 16, 2016 at 9:09 AM, Michael S. Tsirkin <mst@redhat.com> wrote:
>
> Oh, that's because I set orderfile globally rather than
> just for the qemu project which wants it.
> Fixed, sorry about that.
That explains it. I should have remembered, I think this came up once
before with somebody else.
Yeah, for the kernel it makes things much easier (at least for me) to
have everything just the default alphabetical ordering, particularly
because we use directory structure for maintenance areas.
So ordering the diffs by type ends up breaking my mental model for "is
this pull request touching the right files", which is why I reacted.
Linus
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web