Re: [PULL] virtio, vhost: new device, fixes, speedups

From	"Michael S. Tsirkin" <mst@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PULL] virtio, vhost: new device, fixes, speedups
Date	2016-12-16 18:10 +0100
Message-ID	<sP4b7-6vt-9@gated-at.bofh.it> (permalink)
References	<sOQrv-5vu-3@gated-at.bofh.it> <sOQrv-5vu-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Dec 15, 2016 at 06:20:40PM -0800, Linus Torvalds wrote:
> On Thu, Dec 15, 2016 at 3:05 PM, Michael S. Tsirkin <mst@redhat.com> wrote:
> >
> >   git://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git tags/for_linus
> 
> Pulled, but I wonder...
> 
> >  Documentation/translations/zh_CN/sparse.txt        |   7 +-
> >  arch/arm/plat-samsung/include/plat/gpio-cfg.h      |   2 +-
> >  drivers/crypto/virtio/virtio_crypto_common.h       | 128 +++++
> [...]
> 
> what are you generating these diffstats with? Because they are pretty bogus..
> 
> The end result is correct:
> 
> >  86 files changed, 2106 insertions(+), 280 deletions(-)
> 
> but the file order in the diffstat is completely random, which makes
> it very hard to compare with what I get. It also makes it hard to see
> what you changed, because it's not alphabetical like it should be
> (strictly speaking the git pathname ordering isnt' really
> alphabetical, since the '/' sorts as the NUL character, but close
> enough).
> 
> I can't see the logic to the re-ordering of the lines, so I'm
> intrigued how you even generated it.
> 
>             Linus


Oh, that's because I set orderfile globally rather than
just for the qemu project which wants it.
Fixed, sorry about that.

-- 
MST

Thread

Re: [PULL] virtio, vhost: new device, fixes, speedups Linus Torvalds <torvalds@linux-foundation.org> - 2016-12-16 03:30 +0100
  Re: [PULL] virtio, vhost: new device, fixes, speedups Paolo Bonzini <pbonzini@redhat.com> - 2016-12-16 11:20 +0100
  Re: [PULL] virtio, vhost: new device, fixes, speedups "Michael S. Tsirkin" <mst@redhat.com> - 2016-12-16 18:10 +0100
    Re: [PULL] virtio, vhost: new device, fixes, speedups Linus Torvalds <torvalds@linux-foundation.org> - 2016-12-16 18:40 +0100

csiph-web