Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1543101 > unrolled thread
| Started by | Geoff Lansberry <geoff@kuvee.com> |
|---|---|
| First post | 2016-12-15 23:40 +0100 |
| Last post | 2016-12-21 03:10 +0100 |
| Articles | 5 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH 2/3] NFC: trf7970a: Add device tree option of 1.8 Volt IO voltage Geoff Lansberry <geoff@kuvee.com> - 2016-12-15 23:40 +0100
Re: [PATCH 2/3] NFC: trf7970a: Add device tree option of 1.8 Volt IO voltage Mark Greer <mgreer@animalcreek.com> - 2016-12-16 02:20 +0100
Re: [PATCH 2/3] NFC: trf7970a: Add device tree option of 1.8 Volt IO voltage Rob Herring <robh@kernel.org> - 2016-12-19 23:40 +0100
Re: [PATCH 2/3] NFC: trf7970a: Add device tree option of 1.8 Volt IO voltage Geoff Lansberry <geoff@kuvee.com> - 2016-12-20 17:20 +0100
Re: [PATCH 2/3] NFC: trf7970a: Add device tree option of 1.8 Volt IO voltage Mark Greer <mgreer@animalcreek.com> - 2016-12-21 03:10 +0100
| From | Geoff Lansberry <geoff@kuvee.com> |
|---|---|
| Date | 2016-12-15 23:40 +0100 |
| Subject | [PATCH 2/3] NFC: trf7970a: Add device tree option of 1.8 Volt IO voltage |
| Message-ID | <sOMQW-38F-21@gated-at.bofh.it> |
From: Geoff Lansberry <geoff@kuvee.com>
---
Documentation/devicetree/bindings/net/nfc/trf7970a.txt | 2 ++
drivers/nfc/trf7970a.c | 13 ++++++++++++-
2 files changed, 14 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/net/nfc/trf7970a.txt b/Documentation/devicetree/bindings/net/nfc/trf7970a.txt
index 9dda879..208f045 100644
--- a/Documentation/devicetree/bindings/net/nfc/trf7970a.txt
+++ b/Documentation/devicetree/bindings/net/nfc/trf7970a.txt
@@ -21,6 +21,7 @@ Optional SoC Specific Properties:
- t5t-rmb-extra-byte-quirk: Specify that the trf7970a has the erratum
where an extra byte is returned by Read Multiple Block commands issued
to Type 5 tags.
+- vdd_io_1v8: Set to specify that the trf7970a io voltage should be set to 1.8V
- crystal_27mhz: Set to specify that the input frequency to the trf7970a is 27.12MHz
@@ -45,6 +46,7 @@ Example (for ARM-based BeagleBone with TRF7970A on SPI1):
irq-status-read-quirk;
en2-rf-quirk;
t5t-rmb-extra-byte-quirk;
+ vdd_io_1v8;
crystal_27mhz;
status = "okay";
};
diff --git a/drivers/nfc/trf7970a.c b/drivers/nfc/trf7970a.c
index 2d2a077..b4c37ab 100644
--- a/drivers/nfc/trf7970a.c
+++ b/drivers/nfc/trf7970a.c
@@ -441,6 +441,7 @@ struct trf7970a {
u8 iso_ctrl_tech;
u8 modulator_sys_clk_ctrl;
u8 special_fcn_reg1;
+ u8 io_ctrl;
unsigned int guard_time;
int technology;
int framing;
@@ -1048,6 +1049,11 @@ static int trf7970a_init(struct trf7970a *trf)
if (ret)
goto err_out;
+ ret = trf7970a_write(trf, TRF7970A_REG_IO_CTRL,
+ trf->io_ctrl|TRF7970A_REG_IO_CTRL_VRS(0x1));
+ if (ret)
+ goto err_out;
+
ret = trf7970a_write(trf, TRF7970A_NFC_TARGET_LEVEL, 0);
if (ret)
goto err_out;
@@ -1764,7 +1770,7 @@ static int _trf7970a_tg_listen(struct nfc_digital_dev *ddev, u16 timeout,
goto out_err;
ret = trf7970a_write(trf, TRF7970A_REG_IO_CTRL,
- TRF7970A_REG_IO_CTRL_VRS(0x1));
+ trf->io_ctrl|TRF7970A_REG_IO_CTRL_VRS(0x1));
if (ret)
goto out_err;
@@ -2058,6 +2064,11 @@ static int trf7970a_probe(struct spi_device *spi)
return ret;
}
+ if (of_property_read_bool(np, "vdd_io_1v8")) {
+ trf->io_ctrl = TRF7970A_REG_IO_CTRL_IO_LOW;
+ dev_dbg(trf->dev, "trf7970a config vdd_io_1v8\n");
+ }
+
if (of_property_read_bool(np, "crystal_27mhz")) {
trf->modulator_sys_clk_ctrl = TRF7970A_MODULATOR_27MHZ;
dev_dbg(trf->dev, "trf7970a configure crystal_27mhz\n");
--
Signed-off-by: Geoff Lansberry <geoff@kuvee.com>
[toc] | [next] | [standalone]
| From | Mark Greer <mgreer@animalcreek.com> |
|---|---|
| Date | 2016-12-16 02:20 +0100 |
| Subject | Re: [PATCH 2/3] NFC: trf7970a: Add device tree option of 1.8 Volt IO voltage |
| Message-ID | <sOPlL-4TI-1@gated-at.bofh.it> |
| In reply to | #1543101 |
On Thu, Dec 15, 2016 at 05:30:43PM -0500, Geoff Lansberry wrote: > From: Geoff Lansberry <geoff@kuvee.com> Missing commit description. > diff --git a/drivers/nfc/trf7970a.c b/drivers/nfc/trf7970a.c > index 2d2a077..b4c37ab 100644 > --- a/drivers/nfc/trf7970a.c > +++ b/drivers/nfc/trf7970a.c > @@ -1048,6 +1049,11 @@ static int trf7970a_init(struct trf7970a *trf) > if (ret) > goto err_out; > > + ret = trf7970a_write(trf, TRF7970A_REG_IO_CTRL, > + trf->io_ctrl|TRF7970A_REG_IO_CTRL_VRS(0x1)); s/l|T/l | T/ Otherwise, looks good. Mark --
[toc] | [prev] | [next] | [standalone]
| From | Rob Herring <robh@kernel.org> |
|---|---|
| Date | 2016-12-19 23:40 +0100 |
| Subject | Re: [PATCH 2/3] NFC: trf7970a: Add device tree option of 1.8 Volt IO voltage |
| Message-ID | <sQeL8-5pk-9@gated-at.bofh.it> |
| In reply to | #1543101 |
On Thu, Dec 15, 2016 at 05:30:43PM -0500, Geoff Lansberry wrote: > From: Geoff Lansberry <geoff@kuvee.com> > > --- > Documentation/devicetree/bindings/net/nfc/trf7970a.txt | 2 ++ > drivers/nfc/trf7970a.c | 13 ++++++++++++- > 2 files changed, 14 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/net/nfc/trf7970a.txt b/Documentation/devicetree/bindings/net/nfc/trf7970a.txt > index 9dda879..208f045 100644 > --- a/Documentation/devicetree/bindings/net/nfc/trf7970a.txt > +++ b/Documentation/devicetree/bindings/net/nfc/trf7970a.txt > @@ -21,6 +21,7 @@ Optional SoC Specific Properties: > - t5t-rmb-extra-byte-quirk: Specify that the trf7970a has the erratum > where an extra byte is returned by Read Multiple Block commands issued > to Type 5 tags. > +- vdd_io_1v8: Set to specify that the trf7970a io voltage should be set to 1.8V Use the regulator binding and provide a fixed 1.8V supply. > - crystal_27mhz: Set to specify that the input frequency to the trf7970a is 27.12MHz > > > @@ -45,6 +46,7 @@ Example (for ARM-based BeagleBone with TRF7970A on SPI1): > irq-status-read-quirk; > en2-rf-quirk; > t5t-rmb-extra-byte-quirk; > + vdd_io_1v8; > crystal_27mhz; > status = "okay"; > };
[toc] | [prev] | [next] | [standalone]
| From | Geoff Lansberry <geoff@kuvee.com> |
|---|---|
| Date | 2016-12-20 17:20 +0100 |
| Message-ID | <sQviW-7Qa-33@gated-at.bofh.it> |
| In reply to | #1544798 |
On Mon, Dec 19, 2016 at 5:35 PM, Rob Herring <robh@kernel.org> wrote: > On Thu, Dec 15, 2016 at 05:30:43PM -0500, Geoff Lansberry wrote: >> From: Geoff Lansberry <geoff@kuvee.com> >> >> --- >> Documentation/devicetree/bindings/net/nfc/trf7970a.txt | 2 ++ >> drivers/nfc/trf7970a.c | 13 ++++++++++++- >> 2 files changed, 14 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/net/nfc/trf7970a.txt b/Documentation/devicetree/bindings/net/nfc/trf7970a.txt >> index 9dda879..208f045 100644 >> --- a/Documentation/devicetree/bindings/net/nfc/trf7970a.txt >> +++ b/Documentation/devicetree/bindings/net/nfc/trf7970a.txt >> @@ -21,6 +21,7 @@ Optional SoC Specific Properties: >> - t5t-rmb-extra-byte-quirk: Specify that the trf7970a has the erratum >> where an extra byte is returned by Read Multiple Block commands issued >> to Type 5 tags. >> +- vdd_io_1v8: Set to specify that the trf7970a io voltage should be set to 1.8V > > Use the regulator binding and provide a fixed 1.8V supply. > >> - crystal_27mhz: Set to specify that the input frequency to the trf7970a is 27.12MHz >> >> >> @@ -45,6 +46,7 @@ Example (for ARM-based BeagleBone with TRF7970A on SPI1): >> irq-status-read-quirk; >> en2-rf-quirk; >> t5t-rmb-extra-byte-quirk; >> + vdd_io_1v8; >> crystal_27mhz; >> status = "okay"; >> }; Rob - using the regulator binding is new to me, but I've given it a shot and just sent you another set of patches for your inspection. Please let me know if this is what you had in mind. Geoff
[toc] | [prev] | [next] | [standalone]
| From | Mark Greer <mgreer@animalcreek.com> |
|---|---|
| Date | 2016-12-21 03:10 +0100 |
| Subject | Re: [PATCH 2/3] NFC: trf7970a: Add device tree option of 1.8 Volt IO voltage |
| Message-ID | <sQEvT-5Af-3@gated-at.bofh.it> |
| In reply to | #1545231 |
On Tue, Dec 20, 2016 at 11:13:23AM -0500, Geoff Lansberry wrote: > On Mon, Dec 19, 2016 at 5:35 PM, Rob Herring <robh@kernel.org> wrote: > > On Thu, Dec 15, 2016 at 05:30:43PM -0500, Geoff Lansberry wrote: > >> From: Geoff Lansberry <geoff@kuvee.com> > >> > >> --- > >> Documentation/devicetree/bindings/net/nfc/trf7970a.txt | 2 ++ > >> drivers/nfc/trf7970a.c | 13 ++++++++++++- > >> 2 files changed, 14 insertions(+), 1 deletion(-) > >> > >> diff --git a/Documentation/devicetree/bindings/net/nfc/trf7970a.txt b/Documentation/devicetree/bindings/net/nfc/trf7970a.txt > >> index 9dda879..208f045 100644 > >> --- a/Documentation/devicetree/bindings/net/nfc/trf7970a.txt > >> +++ b/Documentation/devicetree/bindings/net/nfc/trf7970a.txt > >> @@ -21,6 +21,7 @@ Optional SoC Specific Properties: > >> - t5t-rmb-extra-byte-quirk: Specify that the trf7970a has the erratum > >> where an extra byte is returned by Read Multiple Block commands issued > >> to Type 5 tags. > >> +- vdd_io_1v8: Set to specify that the trf7970a io voltage should be set to 1.8V > > > > Use the regulator binding and provide a fixed 1.8V supply. > > > >> - crystal_27mhz: Set to specify that the input frequency to the trf7970a is 27.12MHz > >> > >> > >> @@ -45,6 +46,7 @@ Example (for ARM-based BeagleBone with TRF7970A on SPI1): > >> irq-status-read-quirk; > >> en2-rf-quirk; > >> t5t-rmb-extra-byte-quirk; > >> + vdd_io_1v8; > >> crystal_27mhz; > >> status = "okay"; > >> }; > > Rob - using the regulator binding is new to me, but I've given it a > shot and just sent you another set of patches for your inspection. > Please let me know if this is what you had in mind. This is my bad. Geoff followed my example and did something similar to 'vin-voltage-override' which shouldn't have been there in the first place. I have this fixed (I think) locally and will submit once it I'm back from my holiday travels. Mark --
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web