Re: [PATCH 2/3] NFC: trf7970a: Add device tree option of 1.8 Volt IO voltage

From	Mark Greer <mgreer@animalcreek.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/3] NFC: trf7970a: Add device tree option of 1.8 Volt IO voltage
Date	2016-12-21 03:10 +0100
Message-ID	<sQEvT-5Af-3@gated-at.bofh.it> (permalink)
References	<sOMQW-38F-23@gated-at.bofh.it> <sOMQW-38F-21@gated-at.bofh.it> <sQeL8-5pk-9@gated-at.bofh.it> <sQviW-7Qa-33@gated-at.bofh.it>
Organization	Animal Creek Technologies, Inc.

Show all headers | View raw

On Tue, Dec 20, 2016 at 11:13:23AM -0500, Geoff Lansberry wrote:
> On Mon, Dec 19, 2016 at 5:35 PM, Rob Herring <robh@kernel.org> wrote:
> > On Thu, Dec 15, 2016 at 05:30:43PM -0500, Geoff Lansberry wrote:
> >> From: Geoff Lansberry <geoff@kuvee.com>
> >>
> >> ---
> >>  Documentation/devicetree/bindings/net/nfc/trf7970a.txt |  2 ++
> >>  drivers/nfc/trf7970a.c                                 | 13 ++++++++++++-
> >>  2 files changed, 14 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/Documentation/devicetree/bindings/net/nfc/trf7970a.txt b/Documentation/devicetree/bindings/net/nfc/trf7970a.txt
> >> index 9dda879..208f045 100644
> >> --- a/Documentation/devicetree/bindings/net/nfc/trf7970a.txt
> >> +++ b/Documentation/devicetree/bindings/net/nfc/trf7970a.txt
> >> @@ -21,6 +21,7 @@ Optional SoC Specific Properties:
> >>  - t5t-rmb-extra-byte-quirk: Specify that the trf7970a has the erratum
> >>    where an extra byte is returned by Read Multiple Block commands issued
> >>    to Type 5 tags.
> >> +- vdd_io_1v8: Set to specify that the trf7970a io voltage should be set to 1.8V
> >
> > Use the regulator binding and provide a fixed 1.8V supply.
> >
> >>  - crystal_27mhz: Set to specify that the input frequency to the trf7970a is 27.12MHz
> >>
> >>
> >> @@ -45,6 +46,7 @@ Example (for ARM-based BeagleBone with TRF7970A on SPI1):
> >>               irq-status-read-quirk;
> >>               en2-rf-quirk;
> >>               t5t-rmb-extra-byte-quirk;
> >> +             vdd_io_1v8;
> >>               crystal_27mhz;
> >>               status = "okay";
> >>       };
> 
> Rob - using the regulator binding is new to me, but I've given it a
> shot and just sent you another set of patches for your inspection.
> Please let me know if this is what you had in mind.

This is my bad.  Geoff followed my example and did something similar to
'vin-voltage-override' which shouldn't have been there in the first place.
I have this fixed (I think) locally and will submit once it I'm back from
my holiday travels.

Mark
--

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 2/3] NFC: trf7970a: Add device tree option of 1.8 Volt IO voltage Geoff Lansberry <geoff@kuvee.com> - 2016-12-15 23:40 +0100
  Re: [PATCH 2/3] NFC: trf7970a: Add device tree option of 1.8 Volt IO  voltage Mark Greer <mgreer@animalcreek.com> - 2016-12-16 02:20 +0100
  Re: [PATCH 2/3] NFC: trf7970a: Add device tree option of 1.8 Volt IO  voltage Rob Herring <robh@kernel.org> - 2016-12-19 23:40 +0100
    Re: [PATCH 2/3] NFC: trf7970a: Add device tree option of 1.8 Volt IO voltage Geoff Lansberry <geoff@kuvee.com> - 2016-12-20 17:20 +0100
      Re: [PATCH 2/3] NFC: trf7970a: Add device tree option of 1.8 Volt IO  voltage Mark Greer <mgreer@animalcreek.com> - 2016-12-21 03:10 +0100

csiph-web