Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1540002 > unrolled thread
| Started by | Pali Rohár <pali.rohar@gmail.com> |
|---|---|
| First post | 2016-12-11 11:50 +0100 |
| Last post | 2016-12-14 03:00 +0100 |
| Articles | 4 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH 4/7] dell-led: remove dell_app_wmi_led_set() Pali Rohár <pali.rohar@gmail.com> - 2016-12-11 11:50 +0100
Re: [PATCH 4/7] dell-led: remove dell_app_wmi_led_set() Andy Shevchenko <andy.shevchenko@gmail.com> - 2016-12-14 03:00 +0100
Re: [PATCH 4/7] dell-led: remove dell_app_wmi_led_set() Michał Kępień <kernel@kempniu.pl> - 2016-12-15 15:50 +0100
Re: [PATCH 4/7] dell-led: remove dell_app_wmi_led_set() Andy Shevchenko <andy.shevchenko@gmail.com> - 2016-12-14 03:00 +0100
| From | Pali Rohár <pali.rohar@gmail.com> |
|---|---|
| Date | 2016-12-11 11:50 +0100 |
| Subject | Re: [PATCH 4/7] dell-led: remove dell_app_wmi_led_set() |
| Message-ID | <sN9RD-6wJ-9@gated-at.bofh.it> |
[Multipart message — attachments visible in raw view] — view raw
On Thursday 08 December 2016 13:36:15 Michał Kępień wrote: > All calls to dell_app_wmi_led_set() have been replaced with direct > calls to dell_micmute_led_set(), so the former can be safely removed > along with its related enum. > > Signed-off-by: Michał Kępień <kernel@kempniu.pl> I would suggest to squash patches 2,3,4 into one. But I let decision to alsa & led maintainers. Anyway, for patches 2,3,4 you can add my Reviewed-by. It is nice cleanup Reviewed-by: Pali Rohár <pali.rohar@gmail.com> -- Pali Rohár pali.rohar@gmail.com
[toc] | [next] | [standalone]
| From | Andy Shevchenko <andy.shevchenko@gmail.com> |
|---|---|
| Date | 2016-12-14 03:00 +0100 |
| Message-ID | <sO71n-di-1@gated-at.bofh.it> |
| In reply to | #1540002 |
On Wed, Dec 14, 2016 at 3:54 AM, Andy Shevchenko <andy.shevchenko@gmail.com> wrote: > On Sun, Dec 11, 2016 at 12:40 PM, Pali Rohár <pali.rohar@gmail.com> wrote: >> On Thursday 08 December 2016 13:36:15 Michał Kępień wrote: >>> All calls to dell_app_wmi_led_set() have been replaced with direct >>> calls to dell_micmute_led_set(), so the former can be safely removed >>> along with its related enum. >>> >>> Signed-off-by: Michał Kępień <kernel@kempniu.pl> >> >> I would suggest to squash patches 2,3,4 into one. But I let decision to >> alsa & led maintainers. > > I don't like the part where we are exporting something for just one > moment. Oops, misread function name, though still valid vote for one patch. > So, +1 to squashed version. > >> >> Anyway, for patches 2,3,4 you can add my Reviewed-by. It is nice cleanup >> >> Reviewed-by: Pali Rohár <pali.rohar@gmail.com> -- With Best Regards, Andy Shevchenko
[toc] | [prev] | [next] | [standalone]
| From | Michał Kępień <kernel@kempniu.pl> |
|---|---|
| Date | 2016-12-15 15:50 +0100 |
| Message-ID | <sOFw6-6Xv-21@gated-at.bofh.it> |
| In reply to | #1541636 |
> On Wed, Dec 14, 2016 at 3:54 AM, Andy Shevchenko > <andy.shevchenko@gmail.com> wrote: > > On Sun, Dec 11, 2016 at 12:40 PM, Pali Rohár <pali.rohar@gmail.com> wrote: > >> On Thursday 08 December 2016 13:36:15 Michał Kępień wrote: > >>> All calls to dell_app_wmi_led_set() have been replaced with direct > >>> calls to dell_micmute_led_set(), so the former can be safely removed > >>> along with its related enum. > >>> > >>> Signed-off-by: Michał Kępień <kernel@kempniu.pl> > >> > >> I would suggest to squash patches 2,3,4 into one. But I let decision to > >> alsa & led maintainers. > > > > I don't like the part where we are exporting something for just one > > moment. > > Oops, misread function name, though still valid vote for one patch. Thanks, I will do that in v2 (and thanks to Pali for suggesting it). -- Best regards, Michał Kępień
[toc] | [prev] | [next] | [standalone]
| From | Andy Shevchenko <andy.shevchenko@gmail.com> |
|---|---|
| Date | 2016-12-14 03:00 +0100 |
| Message-ID | <sO71n-di-3@gated-at.bofh.it> |
| In reply to | #1540002 |
On Sun, Dec 11, 2016 at 12:40 PM, Pali Rohár <pali.rohar@gmail.com> wrote: > On Thursday 08 December 2016 13:36:15 Michał Kępień wrote: >> All calls to dell_app_wmi_led_set() have been replaced with direct >> calls to dell_micmute_led_set(), so the former can be safely removed >> along with its related enum. >> >> Signed-off-by: Michał Kępień <kernel@kempniu.pl> > > I would suggest to squash patches 2,3,4 into one. But I let decision to > alsa & led maintainers. I don't like the part where we are exporting something for just one moment. So, +1 to squashed version. > > Anyway, for patches 2,3,4 you can add my Reviewed-by. It is nice cleanup > > Reviewed-by: Pali Rohár <pali.rohar@gmail.com> > > -- > Pali Rohár > pali.rohar@gmail.com -- With Best Regards, Andy Shevchenko
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web