Re: [PATCH 4/7] dell-led: remove dell_app_wmi_led_set()

From	Andy Shevchenko <andy.shevchenko@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 4/7] dell-led: remove dell_app_wmi_led_set()
Date	2016-12-14 03:00 +0100
Message-ID	<sO71n-di-3@gated-at.bofh.it> (permalink)
References	<sM69r-68W-7@gated-at.bofh.it> <sM69r-68W-19@gated-at.bofh.it> <sN9RD-6wJ-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sun, Dec 11, 2016 at 12:40 PM, Pali Rohár <pali.rohar@gmail.com> wrote:
> On Thursday 08 December 2016 13:36:15 Michał Kępień wrote:
>> All calls to dell_app_wmi_led_set() have been replaced with direct
>> calls to dell_micmute_led_set(), so the former can be safely removed
>> along with its related enum.
>>
>> Signed-off-by: Michał Kępień <kernel@kempniu.pl>
>
> I would suggest to squash patches 2,3,4 into one. But I let decision to
> alsa & led maintainers.

I don't like the part where we are exporting something for just one
moment. So, +1 to squashed version.

>
> Anyway, for patches 2,3,4 you can add my Reviewed-by. It is nice cleanup
>
> Reviewed-by: Pali Rohár <pali.rohar@gmail.com>
>
> --
> Pali Rohár
> pali.rohar@gmail.com



-- 
With Best Regards,
Andy Shevchenko

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 4/7] dell-led: remove dell_app_wmi_led_set() Pali Rohár <pali.rohar@gmail.com> - 2016-12-11 11:50 +0100
  Re: [PATCH 4/7] dell-led: remove dell_app_wmi_led_set() Andy Shevchenko <andy.shevchenko@gmail.com> - 2016-12-14 03:00 +0100
    Re: [PATCH 4/7] dell-led: remove dell_app_wmi_led_set() Michał Kępień <kernel@kempniu.pl> - 2016-12-15 15:50 +0100
  Re: [PATCH 4/7] dell-led: remove dell_app_wmi_led_set() Andy Shevchenko <andy.shevchenko@gmail.com> - 2016-12-14 03:00 +0100

csiph-web