Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1540476 > unrolled thread
| Started by | Rob Herring <robh@kernel.org> |
|---|---|
| First post | 2016-12-12 18:30 +0100 |
| Last post | 2016-12-14 09:00 +0100 |
| Articles | 4 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH 5/5] Documentation: fsl-quadspi: Add fsl, ls1012a-qspi compatible string Rob Herring <robh@kernel.org> - 2016-12-12 18:30 +0100
RE: [PATCH 5/5] Documentation: fsl-quadspi: Add fsl, ls1012a-qspi compatible string Yao Yuan <yao.yuan@nxp.com> - 2016-12-13 16:30 +0100
Re: [PATCH 5/5] Documentation: fsl-quadspi: Add fsl, ls1012a-qspi compatible string Rob Herring <robh@kernel.org> - 2016-12-13 22:20 +0100
RE: [PATCH 5/5] Documentation: fsl-quadspi: Add fsl, ls1012a-qspi compatible string Yao Yuan <yao.yuan@nxp.com> - 2016-12-14 09:00 +0100
| From | Rob Herring <robh@kernel.org> |
|---|---|
| Date | 2016-12-12 18:30 +0100 |
| Subject | Re: [PATCH 5/5] Documentation: fsl-quadspi: Add fsl, ls1012a-qspi compatible string |
| Message-ID | <sNCAh-796-11@gated-at.bofh.it> |
On Thu, Dec 08, 2016 at 05:23:04PM +0800, Yuan Yao wrote: > From: Yuan Yao <yao.yuan@nxp.com> Same problem in this subject too. > > new compatible string: "fsl,ls1012a-qspi". > > Signed-off-by: Yuan Yao <yao.yuan@nxp.com> > --- > Documentation/devicetree/bindings/mtd/fsl-quadspi.txt | 1 + > 1 file changed, 1 insertion(+) Acked-by: Rob Herring <robh@kernel.org>
[toc] | [next] | [standalone]
| From | Yao Yuan <yao.yuan@nxp.com> |
|---|---|
| Date | 2016-12-13 16:30 +0100 |
| Message-ID | <sNXbH-2Pt-7@gated-at.bofh.it> |
| In reply to | #1540476 |
On Thu, Dec 13, 2016 at 05:23:02PM +0800, Rob Herring wrote: > On Thu, Dec 08, 2016 at 05:23:04PM +0800, Yuan Yao wrote: > > From: Yuan Yao <yao.yuan@nxp.com> > > Same problem in this subject too. > > > > > new compatible string: "fsl,ls1012a-qspi". > > > > Signed-off-by: Yuan Yao <yao.yuan@nxp.com> > > --- > > Documentation/devicetree/bindings/mtd/fsl-quadspi.txt | 1 + > > 1 file changed, 1 insertion(+) > > Acked-by: Rob Herring <robh@kernel.org> Thanks for your review. And do you have any suggestion for this subject? I will update the subject and send v2 soon.
[toc] | [prev] | [next] | [standalone]
| From | Rob Herring <robh@kernel.org> |
|---|---|
| Date | 2016-12-13 22:20 +0100 |
| Message-ID | <sO2Ep-6bg-11@gated-at.bofh.it> |
| In reply to | #1541194 |
On Mon, Dec 12, 2016 at 8:47 PM, Yao Yuan <yao.yuan@nxp.com> wrote: > On Thu, Dec 13, 2016 at 05:23:02PM +0800, Rob Herring wrote: >> On Thu, Dec 08, 2016 at 05:23:04PM +0800, Yuan Yao wrote: >> > From: Yuan Yao <yao.yuan@nxp.com> >> >> Same problem in this subject too. >> >> > >> > new compatible string: "fsl,ls1012a-qspi". >> > >> > Signed-off-by: Yuan Yao <yao.yuan@nxp.com> >> > --- >> > Documentation/devicetree/bindings/mtd/fsl-quadspi.txt | 1 + >> > 1 file changed, 1 insertion(+) >> >> Acked-by: Rob Herring <robh@kernel.org> > > Thanks for your review. > And do you have any suggestion for this subject? The problem is you have a space in the compatible string: "fsl, ls1012a-qspi" rather than "fsl,ls1012a-qspi" Also, I prefer "dt/bindings: " as the beginning of binding patch subjects. Rob
[toc] | [prev] | [next] | [standalone]
| From | Yao Yuan <yao.yuan@nxp.com> |
|---|---|
| Date | 2016-12-14 09:00 +0100 |
| Message-ID | <sOcDM-3Kl-9@gated-at.bofh.it> |
| In reply to | #1541530 |
On Thu, Dec 14, 2016 at 05:23:02PM +0800, Rob Herring wrote: > On Mon, Dec 12, 2016 at 8:47 PM, Yao Yuan <yao.yuan@nxp.com> wrote: > > On Thu, Dec 13, 2016 at 05:23:02PM +0800, Rob Herring wrote: > >> On Thu, Dec 08, 2016 at 05:23:04PM +0800, Yuan Yao wrote: > >> > From: Yuan Yao <yao.yuan@nxp.com> > >> > >> Same problem in this subject too. > >> > >> > > >> > new compatible string: "fsl,ls1012a-qspi". > >> > > >> > Signed-off-by: Yuan Yao <yao.yuan@nxp.com> > >> > --- > >> > Documentation/devicetree/bindings/mtd/fsl-quadspi.txt | 1 + > >> > 1 file changed, 1 insertion(+) > >> > >> Acked-by: Rob Herring <robh@kernel.org> > > > > Thanks for your review. > > And do you have any suggestion for this subject? > > The problem is you have a space in the compatible string: "fsl, ls1012a-qspi" > rather than "fsl,ls1012a-qspi" > > Also, I prefer "dt/bindings: " as the beginning of binding patch subjects. > Ok, Get it. Thanks for your comments. I will send v2 soon.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web