Re: [PATCH 5/5] Documentation: fsl-quadspi: Add fsl, ls1012a-qspi compatible string

From	Rob Herring <robh@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 5/5] Documentation: fsl-quadspi: Add fsl, ls1012a-qspi compatible string
Date	2016-12-13 22:20 +0100
Message-ID	<sO2Ep-6bg-11@gated-at.bofh.it> (permalink)
References	<sNCgV-72u-3@gated-at.bofh.it> <sNCAh-796-13@gated-at.bofh.it> <sNCAh-796-11@gated-at.bofh.it> <sNXbH-2Pt-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Dec 12, 2016 at 8:47 PM, Yao Yuan <yao.yuan@nxp.com> wrote:
> On Thu, Dec 13, 2016 at 05:23:02PM +0800, Rob Herring wrote:
>> On Thu, Dec 08, 2016 at 05:23:04PM +0800, Yuan Yao wrote:
>> > From: Yuan Yao <yao.yuan@nxp.com>
>>
>> Same problem in this subject too.
>>
>> >
>> > new compatible string: "fsl,ls1012a-qspi".
>> >
>> > Signed-off-by: Yuan Yao <yao.yuan@nxp.com>
>> > ---
>> >  Documentation/devicetree/bindings/mtd/fsl-quadspi.txt | 1 +
>> >  1 file changed, 1 insertion(+)
>>
>> Acked-by: Rob Herring <robh@kernel.org>
>
> Thanks for your review.
> And do you have any suggestion for this subject?

The problem is you have a space in the compatible string: "fsl,
ls1012a-qspi" rather than "fsl,ls1012a-qspi"

Also, I prefer "dt/bindings: " as the beginning of binding patch subjects.

Rob

Thread

Re: [PATCH 5/5] Documentation: fsl-quadspi: Add fsl, ls1012a-qspi  compatible string Rob Herring <robh@kernel.org> - 2016-12-12 18:30 +0100
  RE: [PATCH 5/5] Documentation: fsl-quadspi: Add fsl, ls1012a-qspi  compatible string Yao Yuan <yao.yuan@nxp.com> - 2016-12-13 16:30 +0100
    Re: [PATCH 5/5] Documentation: fsl-quadspi: Add fsl, ls1012a-qspi  compatible string Rob Herring <robh@kernel.org> - 2016-12-13 22:20 +0100
      RE: [PATCH 5/5] Documentation: fsl-quadspi: Add fsl, ls1012a-qspi  compatible string Yao Yuan <yao.yuan@nxp.com> - 2016-12-14 09:00 +0100

csiph-web