Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1537956 > unrolled thread
| Started by | Nizam Haider <nizamhaider786@gmail.com> |
|---|---|
| First post | 2016-12-07 18:50 +0100 |
| Last post | 2016-12-10 19:00 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] Staging: iio: impedance-analyzer: ad5933: fix wrong comments Nizam Haider <nizamhaider786@gmail.com> - 2016-12-07 18:50 +0100
Re: [PATCH] Staging: iio: impedance-analyzer: ad5933: fix wrong comments Jonathan Cameron <jic23@kernel.org> - 2016-12-10 19:00 +0100
| From | Nizam Haider <nizamhaider786@gmail.com> |
|---|---|
| Date | 2016-12-07 18:50 +0100 |
| Subject | [PATCH] Staging: iio: impedance-analyzer: ad5933: fix wrong comments |
| Message-ID | <sLOvT-37T-31@gated-at.bofh.it> |
according to datasheet complete control register is of 2 bytes. http://www.analog.com/media/en/technical-documentation/data-sheets/AD5933.pdf Signed-off-by: Nizam Haider <nijam.h@hcl.com> --- drivers/staging/iio/impedance-analyzer/ad5933.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/iio/impedance-analyzer/ad5933.c b/drivers/staging/iio/impedance-analyzer/ad5933.c index 3892a74..f39e03a 100644 --- a/drivers/staging/iio/impedance-analyzer/ad5933.c +++ b/drivers/staging/iio/impedance-analyzer/ad5933.c @@ -23,8 +23,8 @@ #include <linux/iio/kfifo_buf.h> /* AD5933/AD5934 Registers */ -#define AD5933_REG_CONTROL_HB 0x80 /* R/W, 2 bytes */ -#define AD5933_REG_CONTROL_LB 0x81 /* R/W, 2 bytes */ +#define AD5933_REG_CONTROL_HB 0x80 /* R/W, 1 byte */ +#define AD5933_REG_CONTROL_LB 0x81 /* R/W, 1 byte */ #define AD5933_REG_FREQ_START 0x82 /* R/W, 3 bytes */ #define AD5933_REG_FREQ_INC 0x85 /* R/W, 3 bytes */ #define AD5933_REG_INC_NUM 0x88 /* R/W, 2 bytes, 9 bit */ -- 2.10.1
[toc] | [next] | [standalone]
| From | Jonathan Cameron <jic23@kernel.org> |
|---|---|
| Date | 2016-12-10 19:00 +0100 |
| Subject | Re: [PATCH] Staging: iio: impedance-analyzer: ad5933: fix wrong comments |
| Message-ID | <sMU6d-5eP-7@gated-at.bofh.it> |
| In reply to | #1537956 |
On 07/12/16 17:44, Nizam Haider wrote: > according to datasheet complete control register is of 2 bytes. > http://www.analog.com/media/en/technical-documentation/data-sheets/AD5933.pdf > > Signed-off-by: Nizam Haider <nijam.h@hcl.com> Applied to the togreg branch of iio.git - initially pushed out as testing so the autobuilders can completely ignore this patch ;) Jonathan > --- > drivers/staging/iio/impedance-analyzer/ad5933.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/iio/impedance-analyzer/ad5933.c b/drivers/staging/iio/impedance-analyzer/ad5933.c > index 3892a74..f39e03a 100644 > --- a/drivers/staging/iio/impedance-analyzer/ad5933.c > +++ b/drivers/staging/iio/impedance-analyzer/ad5933.c > @@ -23,8 +23,8 @@ > #include <linux/iio/kfifo_buf.h> > > /* AD5933/AD5934 Registers */ > -#define AD5933_REG_CONTROL_HB 0x80 /* R/W, 2 bytes */ > -#define AD5933_REG_CONTROL_LB 0x81 /* R/W, 2 bytes */ > +#define AD5933_REG_CONTROL_HB 0x80 /* R/W, 1 byte */ > +#define AD5933_REG_CONTROL_LB 0x81 /* R/W, 1 byte */ > #define AD5933_REG_FREQ_START 0x82 /* R/W, 3 bytes */ > #define AD5933_REG_FREQ_INC 0x85 /* R/W, 3 bytes */ > #define AD5933_REG_INC_NUM 0x88 /* R/W, 2 bytes, 9 bit */ >
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web