Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1539871

Re: [PATCH] Staging: iio: impedance-analyzer: ad5933: fix wrong comments

Show all headers | View raw

On 07/12/16 17:44, Nizam Haider wrote:
> according to datasheet complete control register is of 2 bytes.
> http://www.analog.com/media/en/technical-documentation/data-sheets/AD5933.pdf
> 
> Signed-off-by: Nizam Haider <nijam.h@hcl.com>
Applied to the togreg branch of iio.git - initially pushed out as testing so the
autobuilders can completely ignore this patch ;)

Jonathan
> ---
>  drivers/staging/iio/impedance-analyzer/ad5933.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/iio/impedance-analyzer/ad5933.c b/drivers/staging/iio/impedance-analyzer/ad5933.c
> index 3892a74..f39e03a 100644
> --- a/drivers/staging/iio/impedance-analyzer/ad5933.c
> +++ b/drivers/staging/iio/impedance-analyzer/ad5933.c
> @@ -23,8 +23,8 @@
>  #include <linux/iio/kfifo_buf.h>
>  
>  /* AD5933/AD5934 Registers */
> -#define AD5933_REG_CONTROL_HB		0x80	/* R/W, 2 bytes */
> -#define AD5933_REG_CONTROL_LB		0x81	/* R/W, 2 bytes */
> +#define AD5933_REG_CONTROL_HB		0x80	/* R/W, 1 byte */
> +#define AD5933_REG_CONTROL_LB		0x81	/* R/W, 1 byte */
>  #define AD5933_REG_FREQ_START		0x82	/* R/W, 3 bytes */
>  #define AD5933_REG_FREQ_INC		0x85	/* R/W, 3 bytes */
>  #define AD5933_REG_INC_NUM		0x88	/* R/W, 2 bytes, 9 bit */
> 

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] Staging: iio: impedance-analyzer: ad5933: fix wrong comments Nizam Haider <nizamhaider786@gmail.com> - 2016-12-07 18:50 +0100
  Re: [PATCH] Staging: iio: impedance-analyzer: ad5933: fix wrong  comments Jonathan Cameron <jic23@kernel.org> - 2016-12-10 19:00 +0100

csiph-web