Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1537691 > unrolled thread
| Started by | Dan Carpenter <dan.carpenter@oracle.com> |
|---|---|
| First post | 2016-12-07 12:30 +0100 |
| Last post | 2016-12-08 17:40 +0100 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[patch] drivers: net: xgene: uninitialized variable in xgene_enet_free_pagepool() Dan Carpenter <dan.carpenter@oracle.com> - 2016-12-07 12:30 +0100
Re: [patch] drivers: net: xgene: uninitialized variable in xgene_enet_free_pagepool() Iyappan Subramanian <isubramanian@apm.com> - 2016-12-07 21:50 +0100
Re: [patch] drivers: net: xgene: uninitialized variable in xgene_enet_free_pagepool() David Miller <davem@davemloft.net> - 2016-12-08 17:40 +0100
| From | Dan Carpenter <dan.carpenter@oracle.com> |
|---|---|
| Date | 2016-12-07 12:30 +0100 |
| Subject | [patch] drivers: net: xgene: uninitialized variable in xgene_enet_free_pagepool() |
| Message-ID | <sLIAa-7TL-25@gated-at.bofh.it> |
We never set "slots" in this function.
Fixes: a9380b0f7be8 ("drivers: net: xgene: Add support for Jumbo frame")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
I copied how slots gets set in xgene_enet_rx_frame(). Static analysis.
Not tested.
diff --git a/drivers/net/ethernet/apm/xgene/xgene_enet_main.c b/drivers/net/ethernet/apm/xgene/xgene_enet_main.c
index 6c7eea8b36af..884a334e82d0 100644
--- a/drivers/net/ethernet/apm/xgene/xgene_enet_main.c
+++ b/drivers/net/ethernet/apm/xgene/xgene_enet_main.c
@@ -635,6 +635,7 @@ static void xgene_enet_free_pagepool(struct xgene_enet_desc_ring *buf_pool,
return;
dev = ndev_to_dev(buf_pool->ndev);
+ slots = buf_pool->slots - 1;
head = buf_pool->head;
for (i = 0; i < 4; i++) {
[toc] | [next] | [standalone]
| From | Iyappan Subramanian <isubramanian@apm.com> |
|---|---|
| Date | 2016-12-07 21:50 +0100 |
| Subject | Re: [patch] drivers: net: xgene: uninitialized variable in xgene_enet_free_pagepool() |
| Message-ID | <sLRk6-4Vw-7@gated-at.bofh.it> |
| In reply to | #1537691 |
On Wed, Dec 7, 2016 at 3:14 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> We never set "slots" in this function.
>
> Fixes: a9380b0f7be8 ("drivers: net: xgene: Add support for Jumbo frame")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> I copied how slots gets set in xgene_enet_rx_frame(). Static analysis.
> Not tested.
>
> diff --git a/drivers/net/ethernet/apm/xgene/xgene_enet_main.c b/drivers/net/ethernet/apm/xgene/xgene_enet_main.c
> index 6c7eea8b36af..884a334e82d0 100644
> --- a/drivers/net/ethernet/apm/xgene/xgene_enet_main.c
> +++ b/drivers/net/ethernet/apm/xgene/xgene_enet_main.c
> @@ -635,6 +635,7 @@ static void xgene_enet_free_pagepool(struct xgene_enet_desc_ring *buf_pool,
> return;
>
> dev = ndev_to_dev(buf_pool->ndev);
> + slots = buf_pool->slots - 1;
> head = buf_pool->head;
>
> for (i = 0; i < 4; i++) {
Thanks.
Acked-by: Iyappan Subramanian <isubramanian@apm.com>
[toc] | [prev] | [next] | [standalone]
| From | David Miller <davem@davemloft.net> |
|---|---|
| Date | 2016-12-08 17:40 +0100 |
| Message-ID | <sM9TI-8om-27@gated-at.bofh.it> |
| In reply to | #1537691 |
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Wed, 7 Dec 2016 14:14:24 +0300
> We never set "slots" in this function.
>
> Fixes: a9380b0f7be8 ("drivers: net: xgene: Add support for Jumbo frame")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web