Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1538068

Re: [patch] drivers: net: xgene: uninitialized variable in xgene_enet_free_pagepool()

Show all headers | View raw

On Wed, Dec 7, 2016 at 3:14 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> We never set "slots" in this function.
>
> Fixes: a9380b0f7be8 ("drivers: net: xgene: Add support for Jumbo frame")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> I copied how slots gets set in xgene_enet_rx_frame().  Static analysis.
> Not tested.
>
> diff --git a/drivers/net/ethernet/apm/xgene/xgene_enet_main.c b/drivers/net/ethernet/apm/xgene/xgene_enet_main.c
> index 6c7eea8b36af..884a334e82d0 100644
> --- a/drivers/net/ethernet/apm/xgene/xgene_enet_main.c
> +++ b/drivers/net/ethernet/apm/xgene/xgene_enet_main.c
> @@ -635,6 +635,7 @@ static void xgene_enet_free_pagepool(struct xgene_enet_desc_ring *buf_pool,
>                 return;
>
>         dev = ndev_to_dev(buf_pool->ndev);
> +       slots = buf_pool->slots - 1;
>         head = buf_pool->head;
>
>         for (i = 0; i < 4; i++) {

Thanks.

Acked-by: Iyappan Subramanian <isubramanian@apm.com>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[patch] drivers: net: xgene: uninitialized variable in  xgene_enet_free_pagepool() Dan Carpenter <dan.carpenter@oracle.com> - 2016-12-07 12:30 +0100
  Re: [patch] drivers: net: xgene: uninitialized variable in xgene_enet_free_pagepool() Iyappan Subramanian <isubramanian@apm.com> - 2016-12-07 21:50 +0100
  Re: [patch] drivers: net: xgene: uninitialized variable in  xgene_enet_free_pagepool() David Miller <davem@davemloft.net> - 2016-12-08 17:40 +0100

csiph-web