Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1537052 > unrolled thread
| Started by | "Michael S. Tsirkin" <mst@redhat.com> |
|---|---|
| First post | 2016-12-06 16:50 +0100 |
| Last post | 2016-12-07 15:20 +0100 |
| Articles | 4 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH 08/10] vsock/virtio: mark an internal function static "Michael S. Tsirkin" <mst@redhat.com> - 2016-12-06 16:50 +0100
Re: [PATCH 08/10] vsock/virtio: mark an internal function static Jason Wang <jasowang@redhat.com> - 2016-12-07 05:30 +0100
Re: [PATCH 08/10] vsock/virtio: mark an internal function static "Michael S. Tsirkin" <mst@redhat.com> - 2016-12-08 15:30 +0100
Re: [PATCH 08/10] vsock/virtio: mark an internal function static Stefan Hajnoczi <stefanha@redhat.com> - 2016-12-07 15:20 +0100
| From | "Michael S. Tsirkin" <mst@redhat.com> |
|---|---|
| Date | 2016-12-06 16:50 +0100 |
| Subject | [PATCH 08/10] vsock/virtio: mark an internal function static |
| Message-ID | <sLqad-3UD-29@gated-at.bofh.it> |
virtio_transport_alloc_pkt is only used locally, make it static. Signed-off-by: Michael S. Tsirkin <mst@redhat.com> --- net/vmw_vsock/virtio_transport_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/vmw_vsock/virtio_transport_common.c b/net/vmw_vsock/virtio_transport_common.c index a53b3a1..6120384 100644 --- a/net/vmw_vsock/virtio_transport_common.c +++ b/net/vmw_vsock/virtio_transport_common.c @@ -32,7 +32,7 @@ static const struct virtio_transport *virtio_transport_get_ops(void) return container_of(t, struct virtio_transport, transport); } -struct virtio_vsock_pkt * +static struct virtio_vsock_pkt * virtio_transport_alloc_pkt(struct virtio_vsock_pkt_info *info, size_t len, u32 src_cid, -- MST
[toc] | [next] | [standalone]
| From | Jason Wang <jasowang@redhat.com> |
|---|---|
| Date | 2016-12-07 05:30 +0100 |
| Message-ID | <sLC1H-3sn-3@gated-at.bofh.it> |
| In reply to | #1537052 |
On 2016年12月06日 23:41, Michael S. Tsirkin wrote: > virtio_transport_alloc_pkt is only used locally, make it static. > > Signed-off-by: Michael S. Tsirkin <mst@redhat.com> > --- > net/vmw_vsock/virtio_transport_common.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/vmw_vsock/virtio_transport_common.c b/net/vmw_vsock/virtio_transport_common.c > index a53b3a1..6120384 100644 > --- a/net/vmw_vsock/virtio_transport_common.c > +++ b/net/vmw_vsock/virtio_transport_common.c > @@ -32,7 +32,7 @@ static const struct virtio_transport *virtio_transport_get_ops(void) > return container_of(t, struct virtio_transport, transport); > } > > -struct virtio_vsock_pkt * > +static struct virtio_vsock_pkt * > virtio_transport_alloc_pkt(struct virtio_vsock_pkt_info *info, > size_t len, > u32 src_cid, Git grep shows it was used by tracing.
[toc] | [prev] | [next] | [standalone]
| From | "Michael S. Tsirkin" <mst@redhat.com> |
|---|---|
| Date | 2016-12-08 15:30 +0100 |
| Message-ID | <sM7RT-7ch-11@gated-at.bofh.it> |
| In reply to | #1537481 |
On Wed, Dec 07, 2016 at 12:21:22PM +0800, Jason Wang wrote: > > > On 2016年12月06日 23:41, Michael S. Tsirkin wrote: > > virtio_transport_alloc_pkt is only used locally, make it static. > > > > Signed-off-by: Michael S. Tsirkin <mst@redhat.com> > > --- > > net/vmw_vsock/virtio_transport_common.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/net/vmw_vsock/virtio_transport_common.c b/net/vmw_vsock/virtio_transport_common.c > > index a53b3a1..6120384 100644 > > --- a/net/vmw_vsock/virtio_transport_common.c > > +++ b/net/vmw_vsock/virtio_transport_common.c > > @@ -32,7 +32,7 @@ static const struct virtio_transport *virtio_transport_get_ops(void) > > return container_of(t, struct virtio_transport, transport); > > } > > -struct virtio_vsock_pkt * > > +static struct virtio_vsock_pkt * > > virtio_transport_alloc_pkt(struct virtio_vsock_pkt_info *info, > > size_t len, > > u32 src_cid, > > Git grep shows it was used by tracing. True but trace_virtio_transport_alloc_pkt is also local to virtio_transport_common.c -- MST
[toc] | [prev] | [next] | [standalone]
| From | Stefan Hajnoczi <stefanha@redhat.com> |
|---|---|
| Date | 2016-12-07 15:20 +0100 |
| Message-ID | <sLLeG-1cj-5@gated-at.bofh.it> |
| In reply to | #1537052 |
[Multipart message — attachments visible in raw view] — view raw
On Tue, Dec 06, 2016 at 05:41:00PM +0200, Michael S. Tsirkin wrote: > virtio_transport_alloc_pkt is only used locally, make it static. > > Signed-off-by: Michael S. Tsirkin <mst@redhat.com> > --- > net/vmw_vsock/virtio_transport_common.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web