Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1538570

Re: [PATCH 08/10] vsock/virtio: mark an internal function static

Show all headers | View raw

On Wed, Dec 07, 2016 at 12:21:22PM +0800, Jason Wang wrote:
> 
> 
> On 2016年12月06日 23:41, Michael S. Tsirkin wrote:
> > virtio_transport_alloc_pkt is only used locally, make it static.
> > 
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > ---
> >   net/vmw_vsock/virtio_transport_common.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/net/vmw_vsock/virtio_transport_common.c b/net/vmw_vsock/virtio_transport_common.c
> > index a53b3a1..6120384 100644
> > --- a/net/vmw_vsock/virtio_transport_common.c
> > +++ b/net/vmw_vsock/virtio_transport_common.c
> > @@ -32,7 +32,7 @@ static const struct virtio_transport *virtio_transport_get_ops(void)
> >   	return container_of(t, struct virtio_transport, transport);
> >   }
> > -struct virtio_vsock_pkt *
> > +static struct virtio_vsock_pkt *
> >   virtio_transport_alloc_pkt(struct virtio_vsock_pkt_info *info,
> >   			   size_t len,
> >   			   u32 src_cid,
> 
> Git grep shows it was used by tracing.

True but trace_virtio_transport_alloc_pkt is also local to
virtio_transport_common.c

-- 
MST

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 08/10] vsock/virtio: mark an internal function static "Michael S. Tsirkin" <mst@redhat.com> - 2016-12-06 16:50 +0100
  Re: [PATCH 08/10] vsock/virtio: mark an internal function static Jason Wang <jasowang@redhat.com> - 2016-12-07 05:30 +0100
    Re: [PATCH 08/10] vsock/virtio: mark an internal function static "Michael S. Tsirkin" <mst@redhat.com> - 2016-12-08 15:30 +0100
  Re: [PATCH 08/10] vsock/virtio: mark an internal function static Stefan Hajnoczi <stefanha@redhat.com> - 2016-12-07 15:20 +0100

csiph-web