Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1535886 > unrolled thread
| Started by | Pan Bian <bianpan2016@163.com> |
|---|---|
| First post | 2016-12-05 09:30 +0100 |
| Last post | 2016-12-08 08:00 +0100 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH 1/1 v2] xen: xenbus: set error code on failure Pan Bian <bianpan2016@163.com> - 2016-12-05 09:30 +0100
Re: [PATCH 1/1 v2] xen: xenbus: set error code on failure Juergen Gross <jgross@suse.com> - 2016-12-05 10:20 +0100
Re: [PATCH 1/1 v2] xen: xenbus: set error code on failure Juergen Gross <jgross@suse.com> - 2016-12-08 08:00 +0100
| From | Pan Bian <bianpan2016@163.com> |
|---|---|
| Date | 2016-12-05 09:30 +0100 |
| Subject | [PATCH 1/1 v2] xen: xenbus: set error code on failure |
| Message-ID | <sKWOR-2aU-3@gated-at.bofh.it> |
Variable err is initialized with 0. As a result, the return value may
be 0 even if get_zeroed_page() fails to allocate memory. This patch fixes
the bug, initializing err with "-ENOMEM".
v1 is reviewed by: Juergen Gross <jgross@suse.com>
Signed-off-by: Pan Bian <bianpan2016@163.com>
---
drivers/xen/xenbus/xenbus_probe.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/xen/xenbus/xenbus_probe.c b/drivers/xen/xenbus/xenbus_probe.c
index 33a31cf..8178d5b 100644
--- a/drivers/xen/xenbus/xenbus_probe.c
+++ b/drivers/xen/xenbus/xenbus_probe.c
@@ -702,7 +702,7 @@ static int __init xenbus_probe_initcall(void)
*/
static int __init xenstored_local_init(void)
{
- int err = 0;
+ int err = -ENOMEM;
unsigned long page = 0;
struct evtchn_alloc_unbound alloc_unbound;
--
1.9.1
[toc] | [next] | [standalone]
| From | Juergen Gross <jgross@suse.com> |
|---|---|
| Date | 2016-12-05 10:20 +0100 |
| Message-ID | <sKXBg-2G5-45@gated-at.bofh.it> |
| In reply to | #1535886 |
On 05/12/16 09:22, Pan Bian wrote:
> Variable err is initialized with 0. As a result, the return value may
> be 0 even if get_zeroed_page() fails to allocate memory. This patch fixes
> the bug, initializing err with "-ENOMEM".
>
> v1 is reviewed by: Juergen Gross <jgross@suse.com>
I didn't say so.
> Signed-off-by: Pan Bian <bianpan2016@163.com>
Now I do:
Reviewed-by: Juergen Gross <jgross@suse.com>
Juergen
> ---
> drivers/xen/xenbus/xenbus_probe.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/xen/xenbus/xenbus_probe.c b/drivers/xen/xenbus/xenbus_probe.c
> index 33a31cf..8178d5b 100644
> --- a/drivers/xen/xenbus/xenbus_probe.c
> +++ b/drivers/xen/xenbus/xenbus_probe.c
> @@ -702,7 +702,7 @@ static int __init xenbus_probe_initcall(void)
> */
> static int __init xenstored_local_init(void)
> {
> - int err = 0;
> + int err = -ENOMEM;
> unsigned long page = 0;
> struct evtchn_alloc_unbound alloc_unbound;
>
>
[toc] | [prev] | [next] | [standalone]
| From | Juergen Gross <jgross@suse.com> |
|---|---|
| Date | 2016-12-08 08:00 +0100 |
| Message-ID | <sM0Qq-2Lg-15@gated-at.bofh.it> |
| In reply to | #1535886 |
On 05/12/16 09:22, Pan Bian wrote: > Variable err is initialized with 0. As a result, the return value may > be 0 even if get_zeroed_page() fails to allocate memory. This patch fixes > the bug, initializing err with "-ENOMEM". > > v1 is reviewed by: Juergen Gross <jgross@suse.com> > > Signed-off-by: Pan Bian <bianpan2016@163.com> Commited to xen/tip.git for-linus-4.10 Juergen
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web