Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1535913

Re: [PATCH 1/1 v2] xen: xenbus: set error code on failure

Show all headers | View raw

On 05/12/16 09:22, Pan Bian wrote:
> Variable err is initialized with 0. As a result, the return value may 
> be 0 even if get_zeroed_page() fails to allocate memory. This patch fixes
> the bug, initializing err with "-ENOMEM".
> 
> v1 is reviewed by: Juergen Gross <jgross@suse.com>

I didn't say so.

> Signed-off-by: Pan Bian <bianpan2016@163.com>

Now I do:

Reviewed-by: Juergen Gross <jgross@suse.com>


Juergen

> ---
>  drivers/xen/xenbus/xenbus_probe.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/xen/xenbus/xenbus_probe.c b/drivers/xen/xenbus/xenbus_probe.c
> index 33a31cf..8178d5b 100644
> --- a/drivers/xen/xenbus/xenbus_probe.c
> +++ b/drivers/xen/xenbus/xenbus_probe.c
> @@ -702,7 +702,7 @@ static int __init xenbus_probe_initcall(void)
>   */
>  static int __init xenstored_local_init(void)
>  {
> -	int err = 0;
> +	int err = -ENOMEM;
>  	unsigned long page = 0;
>  	struct evtchn_alloc_unbound alloc_unbound;
>  
> 

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/1 v2] xen: xenbus: set error code on failure Pan Bian <bianpan2016@163.com> - 2016-12-05 09:30 +0100
  Re: [PATCH 1/1 v2] xen: xenbus: set error code on failure Juergen Gross <jgross@suse.com> - 2016-12-05 10:20 +0100
  Re: [PATCH 1/1 v2] xen: xenbus: set error code on failure Juergen Gross <jgross@suse.com> - 2016-12-08 08:00 +0100

csiph-web