Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1532946 > unrolled thread
| Started by | Yan Laijun <yan.laijun@gmail.com> |
|---|---|
| First post | 2016-11-30 05:30 +0100 |
| Last post | 2016-12-02 11:50 +0100 |
| Articles | 5 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] Staging: wlan-ng: hfa384x_usb.c Fixed too long code line warnings. Yan Laijun <yan.laijun@gmail.com> - 2016-11-30 05:30 +0100
Re: [PATCH] Staging: wlan-ng: hfa384x_usb.c Fixed too long code line warnings. Greg KH <gregkh@linuxfoundation.org> - 2016-11-30 10:20 +0100
Re: [PATCH] Staging: wlan-ng: hfa384x_usb.c Fixed too long code line warnings. Yan Laijun <yan.laijun@gmail.com> - 2016-12-02 11:10 +0100
[PATCH v2] staging: wlan-ng: Fixed too long code line warnings. Yan Laijun <yan.laijun@gmail.com> - 2016-12-02 11:10 +0100
Re: [PATCH v2] staging: wlan-ng: Fixed too long code line warnings. Markus Böhme <markus.boehme@mailbox.org> - 2016-12-02 11:50 +0100
| From | Yan Laijun <yan.laijun@gmail.com> |
|---|---|
| Date | 2016-11-30 05:30 +0100 |
| Subject | [PATCH] Staging: wlan-ng: hfa384x_usb.c Fixed too long code line warnings. |
| Message-ID | <sJ4GR-1aC-3@gated-at.bofh.it> |
Fixed checkpatch warning "line over 80 characters" in
wlan-ng/hfa384x_usb.c file.
Signed-off-by: Yan Laijun <yan.laijun@gmail.com>
---
drivers/staging/wlan-ng/hfa384x_usb.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng/hfa384x_usb.c
index 5f11f6e..3447fc5 100644
--- a/drivers/staging/wlan-ng/hfa384x_usb.c
+++ b/drivers/staging/wlan-ng/hfa384x_usb.c
@@ -3037,7 +3037,7 @@ static void hfa384x_usbin_callback(struct urb *urb)
{
struct wlandevice *wlandev = urb->context;
struct hfa384x *hw;
- union hfa384x_usbin *usbin = (union hfa384x_usbin *)urb->transfer_buffer;
+ union hfa384x_usbin *usbin = NULL;
struct sk_buff *skb = NULL;
int result;
int urb_status;
@@ -3049,6 +3049,7 @@ static void hfa384x_usbin_callback(struct urb *urb)
ABORT
} action;
+ usbin = (union hfa384x_usbin *)urb->transfer_buffer;
if (!wlandev || !wlandev->netdev || wlandev->hwremoved)
goto exit;
--
1.9.1
[toc] | [next] | [standalone]
| From | Greg KH <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2016-11-30 10:20 +0100 |
| Subject | Re: [PATCH] Staging: wlan-ng: hfa384x_usb.c Fixed too long code line warnings. |
| Message-ID | <sJ9dv-4cm-5@gated-at.bofh.it> |
| In reply to | #1532946 |
On Wed, Nov 30, 2016 at 12:29:13PM +0800, Yan Laijun wrote:
> Fixed checkpatch warning "line over 80 characters" in
> wlan-ng/hfa384x_usb.c file.
>
> Signed-off-by: Yan Laijun <yan.laijun@gmail.com>
> ---
> drivers/staging/wlan-ng/hfa384x_usb.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng/hfa384x_usb.c
> index 5f11f6e..3447fc5 100644
> --- a/drivers/staging/wlan-ng/hfa384x_usb.c
> +++ b/drivers/staging/wlan-ng/hfa384x_usb.c
> @@ -3037,7 +3037,7 @@ static void hfa384x_usbin_callback(struct urb *urb)
> {
> struct wlandevice *wlandev = urb->context;
> struct hfa384x *hw;
> - union hfa384x_usbin *usbin = (union hfa384x_usbin *)urb->transfer_buffer;
> + union hfa384x_usbin *usbin = NULL;
Why set this to NULL if you then assign it to something else a few lines
later?
thanks,
greg k-h
[toc] | [prev] | [next] | [standalone]
| From | Yan Laijun <yan.laijun@gmail.com> |
|---|---|
| Date | 2016-12-02 11:10 +0100 |
| Subject | Re: [PATCH] Staging: wlan-ng: hfa384x_usb.c Fixed too long code line warnings. |
| Message-ID | <sJSWZ-2sV-11@gated-at.bofh.it> |
| In reply to | #1533095 |
Remove initialization of usbin on its decarlation. Yan Laijun (1): Staging: wlan-ng: hfa384x_usb.c Fixed too long code line warnings. drivers/staging/wlan-ng/hfa384x_usb.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- 1.9.1
[toc] | [prev] | [next] | [standalone]
| From | Yan Laijun <yan.laijun@gmail.com> |
|---|---|
| Date | 2016-12-02 11:10 +0100 |
| Subject | [PATCH v2] staging: wlan-ng: Fixed too long code line warnings. |
| Message-ID | <sJSWZ-2sV-9@gated-at.bofh.it> |
| In reply to | #1534783 |
Fixed checkpatch warning "line over 80 characters" in
wlan-ng/hfa384x_usb.c file.
Signed-off-by: Yan Laijun <yan.laijun@gmail.com>
---
Changes in v2:
- Remove initialization of usbin on its decarlation.
---
drivers/staging/wlan-ng/hfa384x_usb.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng/hfa384x_usb.c
index 5f11f6e..c7bda04 100644
--- a/drivers/staging/wlan-ng/hfa384x_usb.c
+++ b/drivers/staging/wlan-ng/hfa384x_usb.c
@@ -3037,7 +3037,7 @@ static void hfa384x_usbin_callback(struct urb *urb)
{
struct wlandevice *wlandev = urb->context;
struct hfa384x *hw;
- union hfa384x_usbin *usbin = (union hfa384x_usbin *)urb->transfer_buffer;
+ union hfa384x_usbin *usbin;
struct sk_buff *skb = NULL;
int result;
int urb_status;
@@ -3049,6 +3049,7 @@ static void hfa384x_usbin_callback(struct urb *urb)
ABORT
} action;
+ usbin = (union hfa384x_usbin *)urb->transfer_buffer;
if (!wlandev || !wlandev->netdev || wlandev->hwremoved)
goto exit;
--
1.9.1
[toc] | [prev] | [next] | [standalone]
| From | Markus Böhme <markus.boehme@mailbox.org> |
|---|---|
| Date | 2016-12-02 11:50 +0100 |
| Subject | Re: [PATCH v2] staging: wlan-ng: Fixed too long code line warnings. |
| Message-ID | <sJTzI-2Il-37@gated-at.bofh.it> |
| In reply to | #1534785 |
On 12/02/2016 11:09 AM, Yan Laijun wrote:
> Fixed checkpatch warning "line over 80 characters" in
> wlan-ng/hfa384x_usb.c file.
>
> Signed-off-by: Yan Laijun <yan.laijun@gmail.com>
> ---
> Changes in v2:
> - Remove initialization of usbin on its decarlation.
> ---
> drivers/staging/wlan-ng/hfa384x_usb.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng/hfa384x_usb.c
> index 5f11f6e..c7bda04 100644
> --- a/drivers/staging/wlan-ng/hfa384x_usb.c
> +++ b/drivers/staging/wlan-ng/hfa384x_usb.c
> @@ -3037,7 +3037,7 @@ static void hfa384x_usbin_callback(struct urb *urb)
> {
> struct wlandevice *wlandev = urb->context;
> struct hfa384x *hw;
> - union hfa384x_usbin *usbin = (union hfa384x_usbin *)urb->transfer_buffer;
> + union hfa384x_usbin *usbin;
> struct sk_buff *skb = NULL;
> int result;
> int urb_status;
> @@ -3049,6 +3049,7 @@ static void hfa384x_usbin_callback(struct urb *urb)
> ABORT
> } action;
>
> + usbin = (union hfa384x_usbin *)urb->transfer_buffer;
> if (!wlandev || !wlandev->netdev || wlandev->hwremoved)
> goto exit;
>
>
If you separate declaration and assignment of usbin, maybe it makes
sense to move the assignment down to where usbin is used for the first time.
Regards,
Markus
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web