Re: [PATCH] Staging: wlan-ng: hfa384x_usb.c Fixed too long code line warnings.

From	Greg KH <gregkh@linuxfoundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] Staging: wlan-ng: hfa384x_usb.c Fixed too long code line warnings.
Date	2016-11-30 10:20 +0100
Message-ID	<sJ9dv-4cm-5@gated-at.bofh.it> (permalink)
References	<sJ4GR-1aC-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Nov 30, 2016 at 12:29:13PM +0800, Yan Laijun wrote:
> Fixed checkpatch warning "line over 80 characters" in
> wlan-ng/hfa384x_usb.c file.
> 
> Signed-off-by: Yan Laijun <yan.laijun@gmail.com>
> ---
>  drivers/staging/wlan-ng/hfa384x_usb.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng/hfa384x_usb.c
> index 5f11f6e..3447fc5 100644
> --- a/drivers/staging/wlan-ng/hfa384x_usb.c
> +++ b/drivers/staging/wlan-ng/hfa384x_usb.c
> @@ -3037,7 +3037,7 @@ static void hfa384x_usbin_callback(struct urb *urb)
>  {
>  	struct wlandevice *wlandev = urb->context;
>  	struct hfa384x *hw;
> -	union hfa384x_usbin *usbin = (union hfa384x_usbin *)urb->transfer_buffer;
> +	union hfa384x_usbin *usbin = NULL;

Why set this to NULL if you then assign it to something else a few lines
later?

thanks,

greg k-h

Thread

[PATCH] Staging: wlan-ng: hfa384x_usb.c  Fixed too long code line  warnings. Yan Laijun <yan.laijun@gmail.com> - 2016-11-30 05:30 +0100
  Re: [PATCH] Staging: wlan-ng: hfa384x_usb.c  Fixed too long code  line warnings. Greg KH <gregkh@linuxfoundation.org> - 2016-11-30 10:20 +0100
    Re: [PATCH] Staging: wlan-ng: hfa384x_usb.c  Fixed too long code  line warnings. Yan Laijun <yan.laijun@gmail.com> - 2016-12-02 11:10 +0100
      [PATCH v2] staging: wlan-ng: Fixed too long code line warnings. Yan Laijun <yan.laijun@gmail.com> - 2016-12-02 11:10 +0100
        Re: [PATCH v2] staging: wlan-ng: Fixed too long code line warnings. Markus Böhme <markus.boehme@mailbox.org> - 2016-12-02 11:50 +0100

csiph-web