Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1532947 > unrolled thread

[PATCH] arm64: dts: exynos: Add flash led dt node for TM2 board

Started bySeung-Woo Kim <sw0312.kim@samsung.com>
First post2016-11-30 05:30 +0100
Last post2016-11-30 09:50 +0100
Articles 4 — 2 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH] arm64: dts: exynos: Add flash led dt node for TM2 board Seung-Woo Kim <sw0312.kim@samsung.com> - 2016-11-30 05:30 +0100
    [PATCH v2] arm64: dts: exynos: Add flash led dt node for TM2 board Seung-Woo Kim <sw0312.kim@samsung.com> - 2016-11-30 06:00 +0100
      Re: [PATCH v2] arm64: dts: exynos: Add flash led dt node for TM2 board Chanwoo Choi <cw00.choi@samsung.com> - 2016-11-30 09:40 +0100
        Re: [PATCH v2] arm64: dts: exynos: Add flash led dt node for TM2 board Seung-Woo Kim <sw0312.kim@samsung.com> - 2016-11-30 09:50 +0100

#1532947 — [PATCH] arm64: dts: exynos: Add flash led dt node for TM2 board

FromSeung-Woo Kim <sw0312.kim@samsung.com>
Date2016-11-30 05:30 +0100
Subject[PATCH] arm64: dts: exynos: Add flash led dt node for TM2 board
Message-ID<sJ4GR-1aC-9@gated-at.bofh.it>
From: Ingi Kim <ingi2.kim@samsung.com>

This patch adds Kinetic ktd2692 flash led device node for TM2 board.

Signed-off-by: Ingi Kim <ingi2.kim@samsung.com>
Signed-off-by: Seung-Woo Kim <sw0312.kim@samsung.com>
---
 arch/arm64/boot/dts/exynos/exynos5433-tm2.dts |   13 +++++++++++++
 1 files changed, 13 insertions(+), 0 deletions(-)

diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts
index f21bdc2..3ba305f 100644
--- a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts
+++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts
@@ -58,6 +58,19 @@
 		reg = <0x0 0x20000000 0x0 0xc0000000>;
 	};
 
+	camera-flash {
+		compatible = "kinetic,ktd2692";
+		ctrl-gpios = <&gpc0 1 0>;
+		aux-gpios = <&gpc0 2 0>;
+
+		flash-led {
+			label = "ktd2692-flash";
+			led-max-microamp = <300000>;
+			flash-max-microamp = <1500000>;
+			flash-max-timeout-us = <1835000>;
+		};
+	};
+
 	gpio-keys {
 		compatible = "gpio-keys";
 
-- 
1.7.4.1

[toc] | [next] | [standalone]

#1532952 — [PATCH v2] arm64: dts: exynos: Add flash led dt node for TM2 board

FromSeung-Woo Kim <sw0312.kim@samsung.com>
Date2016-11-30 06:00 +0100
Subject[PATCH v2] arm64: dts: exynos: Add flash led dt node for TM2 board
Message-ID<sJ59T-1k3-5@gated-at.bofh.it>
In reply to#1532947
From: Ingi Kim <ingi2.kim@samsung.com>

This patch adds Kinetic ktd2692 flash led device node for TM2 board.

Signed-off-by: Ingi Kim <ingi2.kim@samsung.com>
Signed-off-by: Seung-Woo Kim <sw0312.kim@samsung.com>
---
Change from v1:
- gpio active value is set with defined macro instead of value.
---
 arch/arm64/boot/dts/exynos/exynos5433-tm2.dts |   13 +++++++++++++
 1 files changed, 13 insertions(+), 0 deletions(-)

diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts
index f21bdc2..0d454aa 100644
--- a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts
+++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts
@@ -58,6 +58,19 @@
 		reg = <0x0 0x20000000 0x0 0xc0000000>;
 	};
 
+	camera-flash {
+		compatible = "kinetic,ktd2692";
+		ctrl-gpios = <&gpc0 1 GPIO_ACTIVE_HIGH>;
+		aux-gpios = <&gpc0 2 GPIO_ACTIVE_HIGH>;
+
+		flash-led {
+			label = "ktd2692-flash";
+			led-max-microamp = <300000>;
+			flash-max-microamp = <1500000>;
+			flash-max-timeout-us = <1835000>;
+		};
+	};
+
 	gpio-keys {
 		compatible = "gpio-keys";
 
-- 
1.7.4.1

[toc] | [prev] | [next] | [standalone]

#1533065 — Re: [PATCH v2] arm64: dts: exynos: Add flash led dt node for TM2 board

FromChanwoo Choi <cw00.choi@samsung.com>
Date2016-11-30 09:40 +0100
SubjectRe: [PATCH v2] arm64: dts: exynos: Add flash led dt node for TM2 board
Message-ID<sJ8AN-3Kh-17@gated-at.bofh.it>
In reply to#1532952
Dear Seung-Woo,

I think that this patch looks good to me.
But, When I tested this patch on my TM2 board,
the flash turn off after some millisecond automatically.

It is strange situation. Unfortunately, I don't know the cause.
I think that we better to check this issue for more time.

Best Regards,
Chanwoo Choi

On 2016년 11월 30일 13:48, Seung-Woo Kim wrote:
> From: Ingi Kim <ingi2.kim@samsung.com>
> 
> This patch adds Kinetic ktd2692 flash led device node for TM2 board.
> 
> Signed-off-by: Ingi Kim <ingi2.kim@samsung.com>
> Signed-off-by: Seung-Woo Kim <sw0312.kim@samsung.com>
> ---
> Change from v1:
> - gpio active value is set with defined macro instead of value.
> ---
>  arch/arm64/boot/dts/exynos/exynos5433-tm2.dts |   13 +++++++++++++
>  1 files changed, 13 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts
> index f21bdc2..0d454aa 100644
> --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts
> +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts
> @@ -58,6 +58,19 @@
>  		reg = <0x0 0x20000000 0x0 0xc0000000>;
>  	};
>  
> +	camera-flash {
> +		compatible = "kinetic,ktd2692";
> +		ctrl-gpios = <&gpc0 1 GPIO_ACTIVE_HIGH>;
> +		aux-gpios = <&gpc0 2 GPIO_ACTIVE_HIGH>;
> +
> +		flash-led {
> +			label = "ktd2692-flash";
> +			led-max-microamp = <300000>;
> +			flash-max-microamp = <1500000>;
> +			flash-max-timeout-us = <1835000>;
> +		};
> +	};
> +
>  	gpio-keys {
>  		compatible = "gpio-keys";
>  
>

[toc] | [prev] | [next] | [standalone]

#1533068 — Re: [PATCH v2] arm64: dts: exynos: Add flash led dt node for TM2 board

FromSeung-Woo Kim <sw0312.kim@samsung.com>
Date2016-11-30 09:50 +0100
SubjectRe: [PATCH v2] arm64: dts: exynos: Add flash led dt node for TM2 board
Message-ID<sJ8Kt-3Ns-7@gated-at.bofh.it>
In reply to#1533065
Hello Chanwoo,

On 2016년 11월 30일 17:36, Chanwoo Choi wrote:
> Dear Seung-Woo,
> 
> I think that this patch looks good to me.
> But, When I tested this patch on my TM2 board,
> the flash turn off after some millisecond automatically.

Thank you for testing on your side. I will check on my side about the
issue, and if I find, then I will send next version.

Regards,
- Seung-Woo Kim

> 
> It is strange situation. Unfortunately, I don't know the cause.
> I think that we better to check this issue for more time.
> 
> Best Regards,
> Chanwoo Choi
> 
> On 2016년 11월 30일 13:48, Seung-Woo Kim wrote:
>> From: Ingi Kim <ingi2.kim@samsung.com>
>>
>> This patch adds Kinetic ktd2692 flash led device node for TM2 board.
>>
>> Signed-off-by: Ingi Kim <ingi2.kim@samsung.com>
>> Signed-off-by: Seung-Woo Kim <sw0312.kim@samsung.com>
>> ---
>> Change from v1:
>> - gpio active value is set with defined macro instead of value.
>> ---
>>  arch/arm64/boot/dts/exynos/exynos5433-tm2.dts |   13 +++++++++++++
>>  1 files changed, 13 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts
>> index f21bdc2..0d454aa 100644
>> --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts
>> +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts
>> @@ -58,6 +58,19 @@
>>  		reg = <0x0 0x20000000 0x0 0xc0000000>;
>>  	};
>>  
>> +	camera-flash {
>> +		compatible = "kinetic,ktd2692";
>> +		ctrl-gpios = <&gpc0 1 GPIO_ACTIVE_HIGH>;
>> +		aux-gpios = <&gpc0 2 GPIO_ACTIVE_HIGH>;
>> +
>> +		flash-led {
>> +			label = "ktd2692-flash";
>> +			led-max-microamp = <300000>;
>> +			flash-max-microamp = <1500000>;
>> +			flash-max-timeout-us = <1835000>;
>> +		};
>> +	};
>> +
>>  	gpio-keys {
>>  		compatible = "gpio-keys";
>>  
>>
> 
> 

-- 
Seung-Woo Kim
Samsung Software R&D Center
--

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web