Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1533065
| From | Chanwoo Choi <cw00.choi@samsung.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2] arm64: dts: exynos: Add flash led dt node for TM2 board |
| Date | 2016-11-30 09:40 +0100 |
| Message-ID | <sJ8AN-3Kh-17@gated-at.bofh.it> (permalink) |
| References | <sJ4GR-1aC-9@gated-at.bofh.it> <sJ8AN-3Kh-19@gated-at.bofh.it> <sJ59T-1k3-5@gated-at.bofh.it> |
| Organization | Samsung Electronics |
Dear Seung-Woo,
I think that this patch looks good to me.
But, When I tested this patch on my TM2 board,
the flash turn off after some millisecond automatically.
It is strange situation. Unfortunately, I don't know the cause.
I think that we better to check this issue for more time.
Best Regards,
Chanwoo Choi
On 2016년 11월 30일 13:48, Seung-Woo Kim wrote:
> From: Ingi Kim <ingi2.kim@samsung.com>
>
> This patch adds Kinetic ktd2692 flash led device node for TM2 board.
>
> Signed-off-by: Ingi Kim <ingi2.kim@samsung.com>
> Signed-off-by: Seung-Woo Kim <sw0312.kim@samsung.com>
> ---
> Change from v1:
> - gpio active value is set with defined macro instead of value.
> ---
> arch/arm64/boot/dts/exynos/exynos5433-tm2.dts | 13 +++++++++++++
> 1 files changed, 13 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts
> index f21bdc2..0d454aa 100644
> --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts
> +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts
> @@ -58,6 +58,19 @@
> reg = <0x0 0x20000000 0x0 0xc0000000>;
> };
>
> + camera-flash {
> + compatible = "kinetic,ktd2692";
> + ctrl-gpios = <&gpc0 1 GPIO_ACTIVE_HIGH>;
> + aux-gpios = <&gpc0 2 GPIO_ACTIVE_HIGH>;
> +
> + flash-led {
> + label = "ktd2692-flash";
> + led-max-microamp = <300000>;
> + flash-max-microamp = <1500000>;
> + flash-max-timeout-us = <1835000>;
> + };
> + };
> +
> gpio-keys {
> compatible = "gpio-keys";
>
>
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] arm64: dts: exynos: Add flash led dt node for TM2 board Seung-Woo Kim <sw0312.kim@samsung.com> - 2016-11-30 05:30 +0100
[PATCH v2] arm64: dts: exynos: Add flash led dt node for TM2 board Seung-Woo Kim <sw0312.kim@samsung.com> - 2016-11-30 06:00 +0100
Re: [PATCH v2] arm64: dts: exynos: Add flash led dt node for TM2 board Chanwoo Choi <cw00.choi@samsung.com> - 2016-11-30 09:40 +0100
Re: [PATCH v2] arm64: dts: exynos: Add flash led dt node for TM2 board Seung-Woo Kim <sw0312.kim@samsung.com> - 2016-11-30 09:50 +0100
csiph-web