Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1531197 > unrolled thread

Re: [PATCH] ARM: dts: mvebu: Add Armada 38x labels and clean up Turris Omnia

Started byRussell King - ARM Linux <linux@armlinux.org.uk>
First post2016-11-28 11:50 +0100
Last post2016-11-28 12:00 +0100
Articles 5 — 3 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] ARM: dts: mvebu: Add Armada 38x labels and clean up  Turris Omnia Russell King - ARM Linux <linux@armlinux.org.uk> - 2016-11-28 11:50 +0100
    Re: [PATCH] ARM: dts: mvebu: Add Armada 38x labels and clean up  Turris Omnia Andreas Färber <afaerber@suse.de> - 2016-11-28 12:00 +0100
      Re: [PATCH] ARM: dts: mvebu: Add Armada 38x labels and clean up  Turris Omnia Russell King - ARM Linux <linux@armlinux.org.uk> - 2016-11-28 12:00 +0100
      Re: [PATCH] ARM: dts: mvebu: Add Armada 38x labels and clean up  Turris Omnia Uwe Kleine-König <uwe@kleine-koenig.org> - 2016-11-28 12:00 +0100
        Re: [PATCH] ARM: dts: mvebu: Add Armada 38x labels and clean up  Turris Omnia Andreas Färber <afaerber@suse.de> - 2016-11-28 12:00 +0100

#1531197 — Re: [PATCH] ARM: dts: mvebu: Add Armada 38x labels and clean up Turris Omnia

FromRussell King - ARM Linux <linux@armlinux.org.uk>
Date2016-11-28 11:50 +0100
SubjectRe: [PATCH] ARM: dts: mvebu: Add Armada 38x labels and clean up Turris Omnia
Message-ID<sIrFv-YK-15@gated-at.bofh.it>
On Sun, Nov 27, 2016 at 07:51:39PM +0100, Andreas Färber wrote:
> To more consistently reference nodes by label, add labels for sata,
> usb2, sdhci and usb3 nodes.
> 
> Convert all other 38x boards for consistency. Add labels for nfc and rtc.

Please don't do this for clearfog - there's changes in the pipeline which
completely replace armada-388-clearfog.dts because there's a "base" and
"pro" versions of this hardware now, and making such a huge change will
effectively mean we have to start over with the DT files.

-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.

[toc] | [next] | [standalone]

#1531199

FromAndreas Färber <afaerber@suse.de>
Date2016-11-28 12:00 +0100
Message-ID<sIrPb-12d-11@gated-at.bofh.it>
In reply to#1531197
Hi Russell,

Am 28.11.2016 um 11:37 schrieb Russell King - ARM Linux:
> On Sun, Nov 27, 2016 at 07:51:39PM +0100, Andreas Färber wrote:
>> To more consistently reference nodes by label, add labels for sata,
>> usb2, sdhci and usb3 nodes.
>>
>> Convert all other 38x boards for consistency. Add labels for nfc and rtc.
> 
> Please don't do this for clearfog - there's changes in the pipeline which
> completely replace armada-388-clearfog.dts because there's a "base" and
> "pro" versions of this hardware now, and making such a huge change will
> effectively mean we have to start over with the DT files.

Would it help to split it back up into a series of add-labels,
use-labels like I had originally? Then you could start using them in
your refactoring as soon as the add-labels patch gets applied. Or are
you completely against this style?

Thanks for pointing this out,

Andreas

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)

[toc] | [prev] | [next] | [standalone]

#1531203

FromRussell King - ARM Linux <linux@armlinux.org.uk>
Date2016-11-28 12:00 +0100
Message-ID<sIrPb-12d-13@gated-at.bofh.it>
In reply to#1531199
On Mon, Nov 28, 2016 at 11:52:26AM +0100, Andreas Färber wrote:
> Hi Russell,
> 
> Am 28.11.2016 um 11:37 schrieb Russell King - ARM Linux:
> > On Sun, Nov 27, 2016 at 07:51:39PM +0100, Andreas Färber wrote:
> >> To more consistently reference nodes by label, add labels for sata,
> >> usb2, sdhci and usb3 nodes.
> >>
> >> Convert all other 38x boards for consistency. Add labels for nfc and rtc.
> > 
> > Please don't do this for clearfog - there's changes in the pipeline which
> > completely replace armada-388-clearfog.dts because there's a "base" and
> > "pro" versions of this hardware now, and making such a huge change will
> > effectively mean we have to start over with the DT files.
> 
> Would it help to split it back up into a series of add-labels,
> use-labels like I had originally? Then you could start using them in
> your refactoring as soon as the add-labels patch gets applied. Or are
> you completely against this style?

What I mentioned is not a case of a work in progress, it's already out
in the wild, and completely changing the clearfog dts file by changing
the style of DT references will make applying the changes _much_ more
difficult - not only obviously impossible to apply the original patch,
but also quite impossible to identify the changes made downstream.

So, I'd rather armada-388-clearfog.dts is not touched at all as it _will_
cause conflicts, but I have nothing against the new style (and I actually
prefer it.)

What I'm asking is that you don't make other people's lives harder than
they need to be.

-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.

[toc] | [prev] | [next] | [standalone]

#1531204

FromUwe Kleine-König <uwe@kleine-koenig.org>
Date2016-11-28 12:00 +0100
Message-ID<sIrPc-12d-19@gated-at.bofh.it>
In reply to#1531199

[Multipart message — attachments visible in raw view] — view raw

Hello,

On 11/28/2016 11:52 AM, Andreas Färber wrote:
>> Please don't do this for clearfog - there's changes in the pipeline which
>> completely replace armada-388-clearfog.dts because there's a "base" and
>> "pro" versions of this hardware now, and making such a huge change will
>> effectively mean we have to start over with the DT files.
> 
> Would it help to split it back up into a series of add-labels,
> use-labels like I had originally? Then you could start using them in
> your refactoring as soon as the add-labels patch gets applied. Or are
> you completely against this style?

I'd even go as far as:

	1: add labels to .dtsi
	2: use labels on .dts#1
	3: use labels on .dts#2
	...

Best regards
Uwe

[toc] | [prev] | [next] | [standalone]

#1531206

FromAndreas Färber <afaerber@suse.de>
Date2016-11-28 12:00 +0100
Message-ID<sIrPc-12d-27@gated-at.bofh.it>
In reply to#1531204
Hi,

Am 28.11.2016 um 11:54 schrieb Uwe Kleine-König:
> On 11/28/2016 11:52 AM, Andreas Färber wrote:
>> Would it help to split it back up into a series of add-labels,
>> use-labels like I had originally? Then you could start using them in
>> your refactoring as soon as the add-labels patch gets applied. Or are
>> you completely against this style?
> 
> I'd even go as far as:
> 
> 	1: add labels to .dtsi
> 	2: use labels on .dts#1
> 	3: use labels on .dts#2
> 	...

That was what I had in mind. :) I even considered reusing the existing
labels first, then adding more and converting more nodes.

Making the patches smaller will hopefully make them more easily
reviewable at the same time.

Cheers,
Andreas

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web