Re: [PATCH] ARM: dts: mvebu: Add Armada 38x labels and clean up Turris Omnia

From	Andreas Färber <afaerber@suse.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH] ARM: dts: mvebu: Add Armada 38x labels and clean up Turris Omnia
Date	2016-11-28 12:00 +0100
Message-ID	<sIrPc-12d-27@gated-at.bofh.it> (permalink)
References	<sIcQ9-8az-5@gated-at.bofh.it> <sIcQ9-8az-3@gated-at.bofh.it> <sIrFv-YK-15@gated-at.bofh.it> <sIrPb-12d-11@gated-at.bofh.it> <sIrPc-12d-19@gated-at.bofh.it>
Organization	SUSE Linux GmbH

Show all headers | View raw

Hi,

Am 28.11.2016 um 11:54 schrieb Uwe Kleine-König:
> On 11/28/2016 11:52 AM, Andreas Färber wrote:
>> Would it help to split it back up into a series of add-labels,
>> use-labels like I had originally? Then you could start using them in
>> your refactoring as soon as the add-labels patch gets applied. Or are
>> you completely against this style?
> 
> I'd even go as far as:
> 
> 	1: add labels to .dtsi
> 	2: use labels on .dts#1
> 	3: use labels on .dts#2
> 	...

That was what I had in mind. :) I even considered reusing the existing
labels first, then adding more and converting more nodes.

Making the patches smaller will hopefully make them more easily
reviewable at the same time.

Cheers,
Andreas

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH] ARM: dts: mvebu: Add Armada 38x labels and clean up  Turris Omnia Russell King - ARM Linux <linux@armlinux.org.uk> - 2016-11-28 11:50 +0100
  Re: [PATCH] ARM: dts: mvebu: Add Armada 38x labels and clean up  Turris Omnia Andreas Färber <afaerber@suse.de> - 2016-11-28 12:00 +0100
    Re: [PATCH] ARM: dts: mvebu: Add Armada 38x labels and clean up  Turris Omnia Russell King - ARM Linux <linux@armlinux.org.uk> - 2016-11-28 12:00 +0100
    Re: [PATCH] ARM: dts: mvebu: Add Armada 38x labels and clean up  Turris Omnia Uwe Kleine-König <uwe@kleine-koenig.org> - 2016-11-28 12:00 +0100
      Re: [PATCH] ARM: dts: mvebu: Add Armada 38x labels and clean up  Turris Omnia Andreas Färber <afaerber@suse.de> - 2016-11-28 12:00 +0100

csiph-web