Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1531109 > unrolled thread

Re: [PATCH] usb: gadget: uvc: fix returnvar.cocci warnings

Started byChristoph Hellwig <hch@lst.de>
First post2016-11-28 09:30 +0100
Last post2016-11-28 09:30 +0100
Articles 1 — 1 participant

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH] usb: gadget: uvc: fix returnvar.cocci warnings Christoph Hellwig <hch@lst.de> - 2016-11-28 09:30 +0100

#1531109 — Re: [PATCH] usb: gadget: uvc: fix returnvar.cocci warnings

FromChristoph Hellwig <hch@lst.de>
Date2016-11-28 09:30 +0100
SubjectRe: [PATCH] usb: gadget: uvc: fix returnvar.cocci warnings
Message-ID<sIpu2-883-27@gated-at.bofh.it>
On Wed, Nov 23, 2016 at 09:35:36AM +0100, Andrzej Pietrasiewicz wrote:
> The ->drop_item() is indeed a void function, the ->drop_link() is
> actually not. This, together with the fact that the value of ->drop_link()
> is silently ignored suggests, that it is the ->drop_link() return
> type that should be corrected and changed to void.

Please send a patch to change it.

[toc] | [standalone]


Back to top | Article view | linux.kernel


csiph-web