Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1531109

Re: [PATCH] usb: gadget: uvc: fix returnvar.cocci warnings

From Christoph Hellwig <hch@lst.de>
Newsgroups linux.kernel
Subject Re: [PATCH] usb: gadget: uvc: fix returnvar.cocci warnings
Date 2016-11-28 09:30 +0100
Message-ID <sIpu2-883-27@gated-at.bofh.it> (permalink)
References (1 earlier) <q9DcT-6QA-23@gated-at.bofh.it> <q9Fom-1Tl-11@gated-at.bofh.it> <sGBfY-2uO-17@gated-at.bofh.it> <sGn3k-1LJ-59@gated-at.bofh.it> <sGBfY-2uO-15@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Wed, Nov 23, 2016 at 09:35:36AM +0100, Andrzej Pietrasiewicz wrote:
> The ->drop_item() is indeed a void function, the ->drop_link() is
> actually not. This, together with the fact that the value of ->drop_link()
> is silently ignored suggests, that it is the ->drop_link() return
> type that should be corrected and changed to void.

Please send a patch to change it.

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

Re: [PATCH] usb: gadget: uvc: fix returnvar.cocci warnings Christoph Hellwig <hch@lst.de> - 2016-11-28 09:30 +0100

csiph-web