Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1531098 > unrolled thread
| Started by | Andreas Ziegler <andreas.ziegler@fau.de> |
|---|---|
| First post | 2016-11-28 09:10 +0100 |
| Last post | 2016-11-28 21:00 +0100 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
Re: [PATCH v3] module: extend 'rodata=off' boot cmdline parameter to module mappings Andreas Ziegler <andreas.ziegler@fau.de> - 2016-11-28 09:10 +0100
Re: [PATCH v3] module: extend 'rodata=off' boot cmdline parameter to module mappings AKASHI Takahiro <takahiro.akashi@linaro.org> - 2016-11-28 10:20 +0100
Re: module: extend 'rodata=off' boot cmdline parameter to module mappings Jessica Yu <jeyu@redhat.com> - 2016-11-28 21:00 +0100
| From | Andreas Ziegler <andreas.ziegler@fau.de> |
|---|---|
| Date | 2016-11-28 09:10 +0100 |
| Subject | Re: [PATCH v3] module: extend 'rodata=off' boot cmdline parameter to module mappings |
| Message-ID | <sIpaF-7Zj-3@gated-at.bofh.it> |
Hi Akashi, your patch "module: extend 'rodata=off' boot cmdline parameter to module mappings" showed up in linux-next today, and I noticed a small error in it. The first modified #ifdef is fine, the second one, however, has a spelling mistake in it: the CONFIG_ variable should be CONFIG_DEBUG_SET_MODULE_RONX instead of CONFIG_SET_MODULE_RONX (note the missing DEBUG). I noticed it by running 'scripts/checkkconfigsymbols -f --force -f next-20161124..next-20161128', which is essentialy diffing the last two linux-next releases and looks for undefined/unknown Kconfig symbols. You can also run the script on single commits with -c to test them. Best regards, Andreas
[toc] | [next] | [standalone]
| From | AKASHI Takahiro <takahiro.akashi@linaro.org> |
|---|---|
| Date | 2016-11-28 10:20 +0100 |
| Message-ID | <sIqgq-c4-27@gated-at.bofh.it> |
| In reply to | #1531098 |
On Mon, Nov 28, 2016 at 08:59:40AM +0100, Andreas Ziegler wrote: > Hi Akashi, > > your patch "module: extend 'rodata=off' boot cmdline parameter to module > mappings" showed up in linux-next today, and I noticed a small error in it. > > The first modified #ifdef is fine, the second one, however, has a spelling > mistake in it: the CONFIG_ variable should be CONFIG_DEBUG_SET_MODULE_RONX > instead of CONFIG_SET_MODULE_RONX (note the missing DEBUG). Thank you for pointing this out. (I didn't notice it because DEBUG_RODATA is always on on arm64.) Rusty, Jessica, should I submit v4 to correct it? -Takahiro AKASHI > I noticed it by running 'scripts/checkkconfigsymbols -f --force -f > next-20161124..next-20161128', which is essentialy diffing the last two > linux-next releases and looks for undefined/unknown Kconfig symbols. > You can also run the script on single commits with -c to test them. > > Best regards, > > Andreas
[toc] | [prev] | [next] | [standalone]
| From | Jessica Yu <jeyu@redhat.com> |
|---|---|
| Date | 2016-11-28 21:00 +0100 |
| Subject | Re: module: extend 'rodata=off' boot cmdline parameter to module mappings |
| Message-ID | <sIAfL-6sT-11@gated-at.bofh.it> |
| In reply to | #1531144 |
+++ AKASHI Takahiro [28/11/16 18:18 +0900]: >On Mon, Nov 28, 2016 at 08:59:40AM +0100, Andreas Ziegler wrote: >> Hi Akashi, >> >> your patch "module: extend 'rodata=off' boot cmdline parameter to module >> mappings" showed up in linux-next today, and I noticed a small error in it. >> >> The first modified #ifdef is fine, the second one, however, has a spelling >> mistake in it: the CONFIG_ variable should be CONFIG_DEBUG_SET_MODULE_RONX >> instead of CONFIG_SET_MODULE_RONX (note the missing DEBUG). > >Thank you for pointing this out. >(I didn't notice it because DEBUG_RODATA is always on on arm64.) > >Rusty, Jessica, should I submit v4 to correct it? Andreas, Akashi - The typo has been fixed with Arnd's patch: http://lkml.kernel.org/r/20161128145931.3350661-1-arnd@arndb.de Thanks for finding the issue! Jessica
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web