Re: module: extend 'rodata=off' boot cmdline parameter to module mappings

From	Jessica Yu <jeyu@redhat.com>
Newsgroups	linux.kernel
Subject	Re: module: extend 'rodata=off' boot cmdline parameter to module mappings
Date	2016-11-28 21:00 +0100
Message-ID	<sIAfL-6sT-11@gated-at.bofh.it> (permalink)
References	<sIpaF-7Zj-3@gated-at.bofh.it> <sIqgq-c4-27@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

+++ AKASHI Takahiro [28/11/16 18:18 +0900]:
>On Mon, Nov 28, 2016 at 08:59:40AM +0100, Andreas Ziegler wrote:
>> Hi Akashi,
>>
>> your patch "module: extend 'rodata=off' boot cmdline parameter to module
>> mappings" showed up in linux-next today, and I noticed a small error in it.
>>
>> The first modified #ifdef is fine, the second one, however, has a spelling
>> mistake in it: the CONFIG_ variable should be CONFIG_DEBUG_SET_MODULE_RONX
>> instead of CONFIG_SET_MODULE_RONX (note the missing DEBUG).
>
>Thank you for pointing this out.
>(I didn't notice it because DEBUG_RODATA is always on on arm64.)
>
>Rusty, Jessica, should I submit v4 to correct it?

Andreas, Akashi -

The typo has been fixed with Arnd's patch:

   http://lkml.kernel.org/r/20161128145931.3350661-1-arnd@arndb.de

Thanks for finding the issue!

Jessica

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v3] module: extend 'rodata=off' boot cmdline parameter to  module mappings Andreas Ziegler <andreas.ziegler@fau.de> - 2016-11-28 09:10 +0100
  Re: [PATCH v3] module: extend 'rodata=off' boot cmdline parameter to  module mappings AKASHI Takahiro <takahiro.akashi@linaro.org> - 2016-11-28 10:20 +0100
    Re: module: extend 'rodata=off' boot cmdline parameter to module  mappings Jessica Yu <jeyu@redhat.com> - 2016-11-28 21:00 +0100

csiph-web