Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1532213 > unrolled thread
| Started by | Bartosz Golaszewski <bgolaszewski@baylibre.com> |
|---|---|
| First post | 2016-11-29 13:00 +0100 |
| Last post | 2016-12-05 15:50 +0100 |
| Articles | 7 — 4 participants |
Back to article view | Back to linux.kernel
[PATCH v3 0/2] ARM: dts: da850: tilcdc related DT changes Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2016-11-29 13:00 +0100
[PATCH v3 1/2] ARM: dts: da850-lcdk: add the dumb-vga-dac node Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2016-11-29 13:00 +0100
Re: [PATCH v3 1/2] ARM: dts: da850-lcdk: add the dumb-vga-dac node Tomi Valkeinen <tomi.valkeinen@ti.com> - 2016-12-05 14:00 +0100
Re: [PATCH v3 1/2] ARM: dts: da850-lcdk: add the dumb-vga-dac node Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2016-12-06 14:10 +0100
Re: [PATCH v3 1/2] ARM: dts: da850-lcdk: add the dumb-vga-dac node Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2016-12-06 16:10 +0100
Re: [PATCH v3 1/2] ARM: dts: da850-lcdk: add the dumb-vga-dac node Sekhar Nori <nsekhar@ti.com> - 2016-12-06 16:20 +0100
Re: [PATCH v3 1/2] ARM: dts: da850-lcdk: add the dumb-vga-dac node Rob Herring <robh+dt@kernel.org> - 2016-12-05 15:50 +0100
| From | Bartosz Golaszewski <bgolaszewski@baylibre.com> |
|---|---|
| Date | 2016-11-29 13:00 +0100 |
| Subject | [PATCH v3 0/2] ARM: dts: da850: tilcdc related DT changes |
| Message-ID | <sIPeN-7XO-9@gated-at.bofh.it> |
his series contains the last DT changes required for LCDC support on da850-lcdk. The first one adds the dumb-vga-dac nodes, the second limits the maximum pixel clock rate. v1 -> v2: - drop patch 3/3 (already merged) - use max-pixelclock instead of max-bandwidth for display mode limiting v2 -> v3: - make the commit message in patch [2/2] more detailed - move the max-pixelclock property to da850.dtsi as the limit affects all da850-based boards Bartosz Golaszewski (2): ARM: dts: da850-lcdk: add the dumb-vga-dac node ARM: dts: da850: specify the maximum pixel clock rate for tilcdc arch/arm/boot/dts/da850-lcdk.dts | 58 ++++++++++++++++++++++++++++++++++++++++ arch/arm/boot/dts/da850.dtsi | 18 +++++++++++++ 2 files changed, 76 insertions(+) -- 2.9.3
[toc] | [next] | [standalone]
| From | Bartosz Golaszewski <bgolaszewski@baylibre.com> |
|---|---|
| Date | 2016-11-29 13:00 +0100 |
| Subject | [PATCH v3 1/2] ARM: dts: da850-lcdk: add the dumb-vga-dac node |
| Message-ID | <sIPeO-7XO-27@gated-at.bofh.it> |
| In reply to | #1532213 |
Add the dumb-vga-dac node to the board DT together with corresponding
ports and vga connector. This allows to retrieve the edid info from
the display automatically.
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
---
arch/arm/boot/dts/da850-lcdk.dts | 58 ++++++++++++++++++++++++++++++++++++++++
arch/arm/boot/dts/da850.dtsi | 17 ++++++++++++
2 files changed, 75 insertions(+)
diff --git a/arch/arm/boot/dts/da850-lcdk.dts b/arch/arm/boot/dts/da850-lcdk.dts
index 711b9ad..d864f11 100644
--- a/arch/arm/boot/dts/da850-lcdk.dts
+++ b/arch/arm/boot/dts/da850-lcdk.dts
@@ -50,6 +50,53 @@
system-clock-frequency = <24576000>;
};
};
+
+ vga_bridge {
+ compatible = "dumb-vga-dac";
+ pinctrl-names = "default";
+ pinctrl-0 = <&lcd_pins>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ port@0 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <0>;
+
+ vga_bridge_in: endpoint@0 {
+ reg = <0>;
+ remote-endpoint = <&display_out_vga>;
+ };
+ };
+
+ port@1 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <1>;
+
+ vga_bridge_out: endpoint@0 {
+ reg = <0>;
+ remote-endpoint = <&vga_con_in>;
+ };
+ };
+ };
+ };
+
+ vga {
+ compatible = "vga-connector";
+
+ ddc-i2c-bus = <&i2c0>;
+
+ port {
+ vga_con_in: endpoint {
+ remote-endpoint = <&vga_bridge_out>;
+ };
+ };
+ };
};
&pmx_core {
@@ -235,3 +282,14 @@
&memctrl {
status = "okay";
};
+
+&display {
+ status = "okay";
+};
+
+&display_out {
+ display_out_vga: endpoint@0 {
+ reg = <0>;
+ remote-endpoint = <&vga_bridge_in>;
+ };
+};
diff --git a/arch/arm/boot/dts/da850.dtsi b/arch/arm/boot/dts/da850.dtsi
index 4070619..5f4ba2e 100644
--- a/arch/arm/boot/dts/da850.dtsi
+++ b/arch/arm/boot/dts/da850.dtsi
@@ -454,6 +454,23 @@
reg = <0x213000 0x1000>;
interrupts = <52>;
status = "disabled";
+
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ display_in: port@0 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <0>;
+ };
+
+ display_out: port@1 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <1>;
+ };
+ };
};
};
aemif: aemif@68000000 {
--
2.9.3
[toc] | [prev] | [next] | [standalone]
| From | Tomi Valkeinen <tomi.valkeinen@ti.com> |
|---|---|
| Date | 2016-12-05 14:00 +0100 |
| Subject | Re: [PATCH v3 1/2] ARM: dts: da850-lcdk: add the dumb-vga-dac node |
| Message-ID | <sL129-4GU-3@gated-at.bofh.it> |
| In reply to | #1532224 |
[Multipart message — attachments visible in raw view] — view raw
On 29/11/16 13:57, Bartosz Golaszewski wrote:
> Add the dumb-vga-dac node to the board DT together with corresponding
> ports and vga connector. This allows to retrieve the edid info from
> the display automatically.
>
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> ---
> arch/arm/boot/dts/da850-lcdk.dts | 58 ++++++++++++++++++++++++++++++++++++++++
> arch/arm/boot/dts/da850.dtsi | 17 ++++++++++++
> 2 files changed, 75 insertions(+)
>
> diff --git a/arch/arm/boot/dts/da850-lcdk.dts b/arch/arm/boot/dts/da850-lcdk.dts
> index 711b9ad..d864f11 100644
> --- a/arch/arm/boot/dts/da850-lcdk.dts
> +++ b/arch/arm/boot/dts/da850-lcdk.dts
> @@ -50,6 +50,53 @@
> system-clock-frequency = <24576000>;
> };
> };
> +
> + vga_bridge {
> + compatible = "dumb-vga-dac";
> + pinctrl-names = "default";
> + pinctrl-0 = <&lcd_pins>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + port@0 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + reg = <0>;
> +
> + vga_bridge_in: endpoint@0 {
> + reg = <0>;
> + remote-endpoint = <&display_out_vga>;
> + };
> + };
> +
> + port@1 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + reg = <1>;
> +
> + vga_bridge_out: endpoint@0 {
> + reg = <0>;
> + remote-endpoint = <&vga_con_in>;
> + };
> + };
> + };
> + };
> +
> + vga {
> + compatible = "vga-connector";
> +
> + ddc-i2c-bus = <&i2c0>;
> +
> + port {
> + vga_con_in: endpoint {
> + remote-endpoint = <&vga_bridge_out>;
> + };
> + };
> + };
> };
>
> &pmx_core {
> @@ -235,3 +282,14 @@
> &memctrl {
> status = "okay";
> };
> +
> +&display {
> + status = "okay";
> +};
> +
> +&display_out {
> + display_out_vga: endpoint@0 {
> + reg = <0>;
> + remote-endpoint = <&vga_bridge_in>;
> + };
> +};
> diff --git a/arch/arm/boot/dts/da850.dtsi b/arch/arm/boot/dts/da850.dtsi
> index 4070619..5f4ba2e 100644
> --- a/arch/arm/boot/dts/da850.dtsi
> +++ b/arch/arm/boot/dts/da850.dtsi
> @@ -454,6 +454,23 @@
> reg = <0x213000 0x1000>;
> interrupts = <52>;
> status = "disabled";
> +
> + ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + display_in: port@0 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + reg = <0>;
> + };
> +
> + display_out: port@1 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + reg = <1>;
> + };
> + };
> };
It's a bit difficult to follow this as there's been so many patches
going around. But I take the above is the LCDC node in the base da850
dtsi file? In that case, what is the display_in supposed to present?
It's the first node in the "display chain", so it has no input.
Also, don't touch da850.dtsi here, just add the "ports" node in the
da850-lcdk.dts file.
If the da850.dtsi has not been merged yet, I'd change the name of the
lcdc node to something else than "display". It's rather vague. If it's
named "lcdc", reading da850-lcdk.dts becomes much easier, as you'll
refer to "lcdc".
Tomi
[toc] | [prev] | [next] | [standalone]
| From | Bartosz Golaszewski <bgolaszewski@baylibre.com> |
|---|---|
| Date | 2016-12-06 14:10 +0100 |
| Subject | Re: [PATCH v3 1/2] ARM: dts: da850-lcdk: add the dumb-vga-dac node |
| Message-ID | <sLnFo-2su-39@gated-at.bofh.it> |
| In reply to | #1536069 |
2016-12-05 13:49 GMT+01:00 Tomi Valkeinen <tomi.valkeinen@ti.com>: > On 29/11/16 13:57, Bartosz Golaszewski wrote: >> Add the dumb-vga-dac node to the board DT together with corresponding >> ports and vga connector. This allows to retrieve the edid info from >> the display automatically. >> > > It's a bit difficult to follow this as there's been so many patches > going around. But I take the above is the LCDC node in the base da850 > dtsi file? In that case, what is the display_in supposed to present? > It's the first node in the "display chain", so it has no input. > > Also, don't touch da850.dtsi here, just add the "ports" node in the > da850-lcdk.dts file. > > If the da850.dtsi has not been merged yet, I'd change the name of the > lcdc node to something else than "display". It's rather vague. If it's > named "lcdc", reading da850-lcdk.dts becomes much easier, as you'll > refer to "lcdc". > The node is already in Sekhar's branch. Thanks, Bartosz
[toc] | [prev] | [next] | [standalone]
| From | Bartosz Golaszewski <bgolaszewski@baylibre.com> |
|---|---|
| Date | 2016-12-06 16:10 +0100 |
| Subject | Re: [PATCH v3 1/2] ARM: dts: da850-lcdk: add the dumb-vga-dac node |
| Message-ID | <sLpxw-3FC-15@gated-at.bofh.it> |
| In reply to | #1536955 |
2016-12-06 16:03 GMT+01:00 Sekhar Nori <nsekhar@ti.com>: > On Tuesday 06 December 2016 06:32 PM, Bartosz Golaszewski wrote: >> 2016-12-05 13:49 GMT+01:00 Tomi Valkeinen <tomi.valkeinen@ti.com>: >>> On 29/11/16 13:57, Bartosz Golaszewski wrote: >>>> Add the dumb-vga-dac node to the board DT together with corresponding >>>> ports and vga connector. This allows to retrieve the edid info from >>>> the display automatically. >>>> >>> >>> It's a bit difficult to follow this as there's been so many patches >>> going around. But I take the above is the LCDC node in the base da850 >>> dtsi file? In that case, what is the display_in supposed to present? >>> It's the first node in the "display chain", so it has no input. >>> >>> Also, don't touch da850.dtsi here, just add the "ports" node in the >>> da850-lcdk.dts file. >>> >>> If the da850.dtsi has not been merged yet, I'd change the name of the >>> lcdc node to something else than "display". It's rather vague. If it's >>> named "lcdc", reading da850-lcdk.dts becomes much easier, as you'll >>> refer to "lcdc". >>> >> >> The node is already in Sekhar's branch. > > The node name should be 'display' as thats the ePAPR 1.1 generic name > recommendation. The label is also set to 'display' though and that can > be changed to lcdc. > > A pre-patch to fix that before we modify the node further is welcome. > > Thanks, > Sekhar I'll include this in v5 together with the change requested by Laurent. Thanks, Bartosz
[toc] | [prev] | [next] | [standalone]
| From | Sekhar Nori <nsekhar@ti.com> |
|---|---|
| Date | 2016-12-06 16:20 +0100 |
| Subject | Re: [PATCH v3 1/2] ARM: dts: da850-lcdk: add the dumb-vga-dac node |
| Message-ID | <sLpxw-3FC-17@gated-at.bofh.it> |
| In reply to | #1536955 |
On Tuesday 06 December 2016 06:32 PM, Bartosz Golaszewski wrote: > 2016-12-05 13:49 GMT+01:00 Tomi Valkeinen <tomi.valkeinen@ti.com>: >> On 29/11/16 13:57, Bartosz Golaszewski wrote: >>> Add the dumb-vga-dac node to the board DT together with corresponding >>> ports and vga connector. This allows to retrieve the edid info from >>> the display automatically. >>> >> >> It's a bit difficult to follow this as there's been so many patches >> going around. But I take the above is the LCDC node in the base da850 >> dtsi file? In that case, what is the display_in supposed to present? >> It's the first node in the "display chain", so it has no input. >> >> Also, don't touch da850.dtsi here, just add the "ports" node in the >> da850-lcdk.dts file. >> >> If the da850.dtsi has not been merged yet, I'd change the name of the >> lcdc node to something else than "display". It's rather vague. If it's >> named "lcdc", reading da850-lcdk.dts becomes much easier, as you'll >> refer to "lcdc". >> > > The node is already in Sekhar's branch. The node name should be 'display' as thats the ePAPR 1.1 generic name recommendation. The label is also set to 'display' though and that can be changed to lcdc. A pre-patch to fix that before we modify the node further is welcome. Thanks, Sekhar
[toc] | [prev] | [next] | [standalone]
| From | Rob Herring <robh+dt@kernel.org> |
|---|---|
| Date | 2016-12-05 15:50 +0100 |
| Subject | Re: [PATCH v3 1/2] ARM: dts: da850-lcdk: add the dumb-vga-dac node |
| Message-ID | <sL2KB-5N1-1@gated-at.bofh.it> |
| In reply to | #1532224 |
On Tue, Nov 29, 2016 at 5:57 AM, Bartosz Golaszewski
<bgolaszewski@baylibre.com> wrote:
> Add the dumb-vga-dac node to the board DT together with corresponding
> ports and vga connector. This allows to retrieve the edid info from
> the display automatically.
>
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> ---
> arch/arm/boot/dts/da850-lcdk.dts | 58 ++++++++++++++++++++++++++++++++++++++++
> arch/arm/boot/dts/da850.dtsi | 17 ++++++++++++
> 2 files changed, 75 insertions(+)
>
> diff --git a/arch/arm/boot/dts/da850-lcdk.dts b/arch/arm/boot/dts/da850-lcdk.dts
> index 711b9ad..d864f11 100644
> --- a/arch/arm/boot/dts/da850-lcdk.dts
> +++ b/arch/arm/boot/dts/da850-lcdk.dts
> @@ -50,6 +50,53 @@
> system-clock-frequency = <24576000>;
> };
> };
> +
> + vga_bridge {
s/_/-/
> + compatible = "dumb-vga-dac";
> + pinctrl-names = "default";
> + pinctrl-0 = <&lcd_pins>;
Are these pins from the LCD controller? They should be part of the LCD
controller node.
Rob
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web