Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1532197 > unrolled thread
| Started by | Tomas Winkler <tomas.winkler@intel.com> |
|---|---|
| First post | 2016-11-29 12:50 +0100 |
| Last post | 2016-11-29 21:20 +0100 |
| Articles | 4 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[char-msic 3/3] mei: fix return value on disconnection Tomas Winkler <tomas.winkler@intel.com> - 2016-11-29 12:50 +0100
Re: [char-msic 3/3] mei: fix return value on disconnection Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-11-29 20:20 +0100
RE: [char-msic 3/3] mei: fix return value on disconnection "Winkler, Tomas" <tomas.winkler@intel.com> - 2016-11-29 21:20 +0100
RE: [char-msic 3/3] mei: fix return value on disconnection "Winkler, Tomas" <tomas.winkler@intel.com> - 2016-11-29 21:20 +0100
| From | Tomas Winkler <tomas.winkler@intel.com> |
|---|---|
| Date | 2016-11-29 12:50 +0100 |
| Subject | [char-msic 3/3] mei: fix return value on disconnection |
| Message-ID | <sIP57-7Uu-17@gated-at.bofh.it> |
commit 2d4d5481e2d6f93b25fcfb13a9f20bbfbf54266a upstream.
Correct errno on client disconnection is -ENODEV not -EBUSY
Cc: <stable@vger.kernel.org> #4.4
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Signed-off-by: Alexander Usyskin <alexander.usyskin@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
drivers/misc/mei/bus.c | 2 +-
drivers/misc/mei/main.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/misc/mei/bus.c b/drivers/misc/mei/bus.c
index a77643954523..e59838231703 100644
--- a/drivers/misc/mei/bus.c
+++ b/drivers/misc/mei/bus.c
@@ -144,7 +144,7 @@ ssize_t __mei_cl_recv(struct mei_cl *cl, u8 *buf, size_t length)
mutex_lock(&bus->device_lock);
if (!mei_cl_is_connected(cl)) {
- rets = -EBUSY;
+ rets = -ENODEV;
goto out;
}
}
diff --git a/drivers/misc/mei/main.c b/drivers/misc/mei/main.c
index 80f9afcb1382..4ef189a7a2fb 100644
--- a/drivers/misc/mei/main.c
+++ b/drivers/misc/mei/main.c
@@ -207,7 +207,7 @@ static ssize_t mei_read(struct file *file, char __user *ubuf,
mutex_lock(&dev->device_lock);
if (!mei_cl_is_connected(cl)) {
- rets = -EBUSY;
+ rets = -ENODEV;
goto out;
}
}
--
2.7.4
[toc] | [next] | [standalone]
| From | Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2016-11-29 20:20 +0100 |
| Message-ID | <sIW6B-48h-1@gated-at.bofh.it> |
| In reply to | #1532197 |
On Tue, Nov 29, 2016 at 02:44:46PM +0200, Tomas Winkler wrote: > commit 2d4d5481e2d6f93b25fcfb13a9f20bbfbf54266a upstream. > > Correct errno on client disconnection is -ENODEV not -EBUSY > > Cc: <stable@vger.kernel.org> #4.4 > Signed-off-by: Tomas Winkler <tomas.winkler@intel.com> > Signed-off-by: Alexander Usyskin <alexander.usyskin@intel.com> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > --- > drivers/misc/mei/bus.c | 2 +- > drivers/misc/mei/main.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) Again, what kernel tree? greg k-h
[toc] | [prev] | [next] | [standalone]
| From | "Winkler, Tomas" <tomas.winkler@intel.com> |
|---|---|
| Date | 2016-11-29 21:20 +0100 |
| Message-ID | <sIX2G-4Lk-7@gated-at.bofh.it> |
| In reply to | #1532688 |
> -----Original Message----- > From: Greg Kroah-Hartman [mailto:gregkh@linuxfoundation.org] > Sent: Tuesday, November 29, 2016 21:15 > To: Winkler, Tomas <tomas.winkler@intel.com> > Cc: stable@vger.kernel.org; linux-kernel@vger.kernel.org; Usyskin, Alexander > <alexander.usyskin@intel.com> > Subject: Re: [char-msic 3/3] mei: fix return value on disconnection > > On Tue, Nov 29, 2016 at 02:44:46PM +0200, Tomas Winkler wrote: > > commit 2d4d5481e2d6f93b25fcfb13a9f20bbfbf54266a upstream. > > > > Correct errno on client disconnection is -ENODEV not -EBUSY > > > > Cc: <stable@vger.kernel.org> #4.4 > > Signed-off-by: Tomas Winkler <tomas.winkler@intel.com> > > Signed-off-by: Alexander Usyskin <alexander.usyskin@intel.com> > > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > --- > > drivers/misc/mei/bus.c | 2 +- > > drivers/misc/mei/main.c | 2 +- > > 2 files changed, 2 insertions(+), 2 deletions(-) > > Again, what kernel tree? Stable 4.4 Cc: <stable@vger.kernel.org> #4.4 Thanks Tomas
[toc] | [prev] | [next] | [standalone]
| From | "Winkler, Tomas" <tomas.winkler@intel.com> |
|---|---|
| Date | 2016-11-29 21:20 +0100 |
| Message-ID | <sIX2G-4Lk-15@gated-at.bofh.it> |
| In reply to | #1532688 |
> -----Original Message----- > From: Greg Kroah-Hartman [mailto:gregkh@linuxfoundation.org] > Sent: Tuesday, November 29, 2016 21:15 > To: Winkler, Tomas <tomas.winkler@intel.com> > Cc: stable@vger.kernel.org; linux-kernel@vger.kernel.org; Usyskin, Alexander > <alexander.usyskin@intel.com> > Subject: Re: [char-msic 3/3] mei: fix return value on disconnection > > On Tue, Nov 29, 2016 at 02:44:46PM +0200, Tomas Winkler wrote: > > commit 2d4d5481e2d6f93b25fcfb13a9f20bbfbf54266a upstream. > > > > Correct errno on client disconnection is -ENODEV not -EBUSY > > > > Cc: <stable@vger.kernel.org> #4.4 > > Signed-off-by: Tomas Winkler <tomas.winkler@intel.com> > > Signed-off-by: Alexander Usyskin <alexander.usyskin@intel.com> > > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > --- > > drivers/misc/mei/bus.c | 2 +- > > drivers/misc/mei/main.c | 2 +- > > 2 files changed, 2 insertions(+), 2 deletions(-) > > Again, what kernel tree? Stable 4.4 Cc: <stable@vger.kernel.org> #4.4 Thanks Tomas
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web