[char-msic 3/3] mei: fix return value on disconnection

From	Tomas Winkler <tomas.winkler@intel.com>
Newsgroups	linux.kernel
Subject	[char-msic 3/3] mei: fix return value on disconnection
Date	2016-11-29 12:50 +0100
Message-ID	<sIP57-7Uu-17@gated-at.bofh.it> (permalink)
References	<sIP57-7Uu-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

commit 2d4d5481e2d6f93b25fcfb13a9f20bbfbf54266a upstream.

Correct errno on client disconnection is -ENODEV not -EBUSY

Cc: <stable@vger.kernel.org> #4.4
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Signed-off-by: Alexander Usyskin <alexander.usyskin@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
 drivers/misc/mei/bus.c  | 2 +-
 drivers/misc/mei/main.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/misc/mei/bus.c b/drivers/misc/mei/bus.c
index a77643954523..e59838231703 100644
--- a/drivers/misc/mei/bus.c
+++ b/drivers/misc/mei/bus.c
@@ -144,7 +144,7 @@ ssize_t __mei_cl_recv(struct mei_cl *cl, u8 *buf, size_t length)
 		mutex_lock(&bus->device_lock);
 
 		if (!mei_cl_is_connected(cl)) {
-			rets = -EBUSY;
+			rets = -ENODEV;
 			goto out;
 		}
 	}
diff --git a/drivers/misc/mei/main.c b/drivers/misc/mei/main.c
index 80f9afcb1382..4ef189a7a2fb 100644
--- a/drivers/misc/mei/main.c
+++ b/drivers/misc/mei/main.c
@@ -207,7 +207,7 @@ static ssize_t mei_read(struct file *file, char __user *ubuf,
 
 		mutex_lock(&dev->device_lock);
 		if (!mei_cl_is_connected(cl)) {
-			rets = -EBUSY;
+			rets = -ENODEV;
 			goto out;
 		}
 	}
-- 
2.7.4

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[char-msic 3/3] mei: fix return value on disconnection Tomas Winkler <tomas.winkler@intel.com> - 2016-11-29 12:50 +0100
  Re: [char-msic 3/3] mei: fix return value on disconnection Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-11-29 20:20 +0100
    RE: [char-msic 3/3] mei: fix return value on disconnection "Winkler, Tomas" <tomas.winkler@intel.com> - 2016-11-29 21:20 +0100
    RE: [char-msic 3/3] mei: fix return value on disconnection "Winkler, Tomas" <tomas.winkler@intel.com> - 2016-11-29 21:20 +0100

csiph-web