Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1531760 > unrolled thread
| Started by | Martin Kaiser <martin@kaiser.cx> |
|---|---|
| First post | 2016-11-28 23:50 +0100 |
| Last post | 2016-11-29 21:00 +0100 |
| Articles | 4 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH] video: imxfb: remove the macros for initializing the DMACR Martin Kaiser <martin@kaiser.cx> - 2016-11-28 23:50 +0100
Re: [PATCH] video: imxfb: remove the macros for initializing the DMACR Uwe Kleine-König <u.kleine-koenig@pengutronix.de> - 2016-11-29 09:00 +0100
[PATCH v2] video: imxfb: remove the macros for initializing the DMACR Martin Kaiser <martin@kaiser.cx> - 2016-11-29 21:00 +0100
Re: [PATCH v2] video: imxfb: remove the macros for initializing the DMACR Uwe Kleine-König <u.kleine-koenig@pengutronix.de> - 2016-11-29 21:00 +0100
| From | Martin Kaiser <martin@kaiser.cx> |
|---|---|
| Date | 2016-11-28 23:50 +0100 |
| Subject | [PATCH] video: imxfb: remove the macros for initializing the DMACR |
| Message-ID | <sICUh-8cJ-15@gated-at.bofh.it> |
The current definitions of DMACR_HM() and DMACR_TM() are correct only
for imx1, they're wrong for imx21.
The macros are meant for legacy board files only, they're not applicable
for boards using device tree.
At the moment, there are no boards are using the macros. So it should be
safe to drop them rather than making them work for both imx1 and imx21,
which would require a change in the platform data struct.
Signed-off-by: Martin Kaiser <martin@kaiser.cx>
---
include/linux/platform_data/video-imxfb.h | 4 ----
1 file changed, 4 deletions(-)
diff --git a/include/linux/platform_data/video-imxfb.h b/include/linux/platform_data/video-imxfb.h
index 18e9083..a5c0a71 100644
--- a/include/linux/platform_data/video-imxfb.h
+++ b/include/linux/platform_data/video-imxfb.h
@@ -47,10 +47,6 @@
#define LSCR1_GRAY2(x) (((x) & 0xf) << 4)
#define LSCR1_GRAY1(x) (((x) & 0xf))
-#define DMACR_BURST (1 << 31)
-#define DMACR_HM(x) (((x) & 0xf) << 16)
-#define DMACR_TM(x) ((x) & 0xf)
-
struct imx_fb_videomode {
struct fb_videomode mode;
u32 pcr;
--
1.7.10.4
[toc] | [next] | [standalone]
| From | Uwe Kleine-König <u.kleine-koenig@pengutronix.de> |
|---|---|
| Date | 2016-11-29 09:00 +0100 |
| Subject | Re: [PATCH] video: imxfb: remove the macros for initializing the DMACR |
| Message-ID | <sILuy-5oV-9@gated-at.bofh.it> |
| In reply to | #1531760 |
On Mon, Nov 28, 2016 at 11:43:09PM +0100, Martin Kaiser wrote: > The current definitions of DMACR_HM() and DMACR_TM() are correct only > for imx1, they're wrong for imx21. > > The macros are meant for legacy board files only, they're not applicable > for boards using device tree. > > At the moment, there are no boards are using the macros. So it should be s/are using the/using these/ > safe to drop them rather than making them work for both imx1 and imx21, > which would require a change in the platform data struct. > > Signed-off-by: Martin Kaiser <martin@kaiser.cx> Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ |
[toc] | [prev] | [next] | [standalone]
| From | Martin Kaiser <martin@kaiser.cx> |
|---|---|
| Date | 2016-11-29 21:00 +0100 |
| Subject | [PATCH v2] video: imxfb: remove the macros for initializing the DMACR |
| Message-ID | <sIWJj-4l9-1@gated-at.bofh.it> |
| In reply to | #1531980 |
The current definitions of DMACR_HM() and DMACR_TM() are correct only
for imx1, they're wrong for imx21.
The macros are meant for legacy board files only, they're not applicable
for boards using device tree.
At the moment, there are no boards using these macros. So it should be
safe to drop them rather than making them work for both imx1 and imx21,
which would require a change in the platform data struct.
Signed-off-by: Martin Kaiser <martin@kaiser.cx>
---
Change in v2:
fixed the commit message
include/linux/platform_data/video-imxfb.h | 4 ----
1 file changed, 4 deletions(-)
diff --git a/include/linux/platform_data/video-imxfb.h b/include/linux/platform_data/video-imxfb.h
index 18e9083..a5c0a71 100644
--- a/include/linux/platform_data/video-imxfb.h
+++ b/include/linux/platform_data/video-imxfb.h
@@ -47,10 +47,6 @@
#define LSCR1_GRAY2(x) (((x) & 0xf) << 4)
#define LSCR1_GRAY1(x) (((x) & 0xf))
-#define DMACR_BURST (1 << 31)
-#define DMACR_HM(x) (((x) & 0xf) << 16)
-#define DMACR_TM(x) ((x) & 0xf)
-
struct imx_fb_videomode {
struct fb_videomode mode;
u32 pcr;
--
1.7.10.4
[toc] | [prev] | [next] | [standalone]
| From | Uwe Kleine-König <u.kleine-koenig@pengutronix.de> |
|---|---|
| Date | 2016-11-29 21:00 +0100 |
| Subject | Re: [PATCH v2] video: imxfb: remove the macros for initializing the DMACR |
| Message-ID | <sIWJj-4l9-11@gated-at.bofh.it> |
| In reply to | #1532719 |
On Tue, Nov 29, 2016 at 08:50:39PM +0100, Martin Kaiser wrote: > The current definitions of DMACR_HM() and DMACR_TM() are correct only > for imx1, they're wrong for imx21. > > The macros are meant for legacy board files only, they're not applicable > for boards using device tree. > > At the moment, there are no boards using these macros. So it should be > safe to drop them rather than making them work for both imx1 and imx21, > which would require a change in the platform data struct. > > Signed-off-by: Martin Kaiser <martin@kaiser.cx> Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Thanks Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ |
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web