Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1531980

Re: [PATCH] video: imxfb: remove the macros for initializing the DMACR

Show all headers | View raw

On Mon, Nov 28, 2016 at 11:43:09PM +0100, Martin Kaiser wrote:
> The current definitions of DMACR_HM() and DMACR_TM() are correct only
> for imx1, they're wrong for imx21.
> 
> The macros are meant for legacy board files only, they're not applicable
> for boards using device tree.
> 
> At the moment, there are no boards are using the macros. So it should be
s/are using the/using these/

> safe to drop them rather than making them work for both imx1 and imx21,
> which would require a change in the platform data struct.
> 
> Signed-off-by: Martin Kaiser <martin@kaiser.cx>
Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] video: imxfb: remove the macros for initializing the DMACR Martin Kaiser <martin@kaiser.cx> - 2016-11-28 23:50 +0100
  Re: [PATCH] video: imxfb: remove the macros for initializing the  DMACR Uwe Kleine-König          <u.kleine-koenig@pengutronix.de> - 2016-11-29 09:00 +0100
    [PATCH v2] video: imxfb: remove the macros for initializing the DMACR Martin Kaiser <martin@kaiser.cx> - 2016-11-29 21:00 +0100
      Re: [PATCH v2] video: imxfb: remove the macros for initializing the  DMACR Uwe Kleine-König          <u.kleine-koenig@pengutronix.de> - 2016-11-29 21:00 +0100

csiph-web