Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1529603 > unrolled thread

[PATCH] pinctrl: imx: fix imx_pinctrl_desc initialization

Started byGary Bisson <gary.bisson@boundarydevices.com>
First post2016-11-24 19:20 +0100
Last post2016-11-25 14:20 +0100
Articles 5 — 4 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH] pinctrl: imx: fix imx_pinctrl_desc initialization Gary Bisson <gary.bisson@boundarydevices.com> - 2016-11-24 19:20 +0100
    Re: [PATCH] pinctrl: imx: fix imx_pinctrl_desc initialization Gary Bisson <gary.bisson@boundarydevices.com> - 2016-11-24 19:30 +0100
    Re: [PATCH] pinctrl: imx: fix imx_pinctrl_desc initialization Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com> - 2016-11-24 21:20 +0100
    Re: [PATCH] pinctrl: imx: fix imx_pinctrl_desc initialization Peng Fan <van.freenix@gmail.com> - 2016-11-25 02:20 +0100
    Re: [PATCH] pinctrl: imx: fix imx_pinctrl_desc initialization Linus Walleij <linus.walleij@linaro.org> - 2016-11-25 14:20 +0100

#1529603 — [PATCH] pinctrl: imx: fix imx_pinctrl_desc initialization

FromGary Bisson <gary.bisson@boundarydevices.com>
Date2016-11-24 19:20 +0100
Subject[PATCH] pinctrl: imx: fix imx_pinctrl_desc initialization
Message-ID<sH6MO-6kz-13@gated-at.bofh.it>
Was introduced by:
6e408ed pinctrl: imx: fix initialization of imx_pinctrl_desc

Signed-off-by: Gary Bisson <gary.bisson@boundarydevices.com>
---
 drivers/pinctrl/freescale/pinctrl-imx.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/pinctrl/freescale/pinctrl-imx.c b/drivers/pinctrl/freescale/pinctrl-imx.c
index 79c4e14..5ef7e87 100644
--- a/drivers/pinctrl/freescale/pinctrl-imx.c
+++ b/drivers/pinctrl/freescale/pinctrl-imx.c
@@ -778,10 +778,10 @@ int imx_pinctrl_probe(struct platform_device *pdev,
 	imx_pinctrl_desc->name = dev_name(&pdev->dev);
 	imx_pinctrl_desc->pins = info->pins;
 	imx_pinctrl_desc->npins = info->npins;
-	imx_pinctrl_desc->pctlops = &imx_pctrl_ops,
-	imx_pinctrl_desc->pmxops = &imx_pmx_ops,
-	imx_pinctrl_desc->confops = &imx_pinconf_ops,
-	imx_pinctrl_desc->owner = THIS_MODULE,
+	imx_pinctrl_desc->pctlops = &imx_pctrl_ops;
+	imx_pinctrl_desc->pmxops = &imx_pmx_ops;
+	imx_pinctrl_desc->confops = &imx_pinconf_ops;
+	imx_pinctrl_desc->owner = THIS_MODULE;
 
 	ret = imx_pinctrl_probe_dt(pdev, info);
 	if (ret) {
-- 
2.9.3

[toc] | [next] | [standalone]

#1529609

FromGary Bisson <gary.bisson@boundarydevices.com>
Date2016-11-24 19:30 +0100
Message-ID<sH6Wu-6po-13@gated-at.bofh.it>
In reply to#1529603
Hi all,

Just resending this email since there was a typo in Shawn's e-mail
address.

Regards,
Gary

On Thu, Nov 24, 2016 at 07:11:51PM +0100, Gary Bisson wrote:
> Was introduced by:
> 6e408ed pinctrl: imx: fix initialization of imx_pinctrl_desc
> 
> Signed-off-by: Gary Bisson <gary.bisson@boundarydevices.com>
> ---
>  drivers/pinctrl/freescale/pinctrl-imx.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/pinctrl/freescale/pinctrl-imx.c b/drivers/pinctrl/freescale/pinctrl-imx.c
> index 79c4e14..5ef7e87 100644
> --- a/drivers/pinctrl/freescale/pinctrl-imx.c
> +++ b/drivers/pinctrl/freescale/pinctrl-imx.c
> @@ -778,10 +778,10 @@ int imx_pinctrl_probe(struct platform_device *pdev,
>  	imx_pinctrl_desc->name = dev_name(&pdev->dev);
>  	imx_pinctrl_desc->pins = info->pins;
>  	imx_pinctrl_desc->npins = info->npins;
> -	imx_pinctrl_desc->pctlops = &imx_pctrl_ops,
> -	imx_pinctrl_desc->pmxops = &imx_pmx_ops,
> -	imx_pinctrl_desc->confops = &imx_pinconf_ops,
> -	imx_pinctrl_desc->owner = THIS_MODULE,
> +	imx_pinctrl_desc->pctlops = &imx_pctrl_ops;
> +	imx_pinctrl_desc->pmxops = &imx_pmx_ops;
> +	imx_pinctrl_desc->confops = &imx_pinconf_ops;
> +	imx_pinctrl_desc->owner = THIS_MODULE;
>  
>  	ret = imx_pinctrl_probe_dt(pdev, info);
>  	if (ret) {
> -- 
> 2.9.3
>

[toc] | [prev] | [next] | [standalone]

#1529679

FromVladimir Zapolskiy <vladimir_zapolskiy@mentor.com>
Date2016-11-24 21:20 +0100
Message-ID<sH8EV-7zi-7@gated-at.bofh.it>
In reply to#1529603
Hi Gary,

On 11/24/2016 08:11 PM, Gary Bisson wrote:
> Was introduced by:
> 6e408ed pinctrl: imx: fix initialization of imx_pinctrl_desc
>
> Signed-off-by: Gary Bisson <gary.bisson@boundarydevices.com>
> ---
>  drivers/pinctrl/freescale/pinctrl-imx.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/pinctrl/freescale/pinctrl-imx.c b/drivers/pinctrl/freescale/pinctrl-imx.c
> index 79c4e14..5ef7e87 100644
> --- a/drivers/pinctrl/freescale/pinctrl-imx.c
> +++ b/drivers/pinctrl/freescale/pinctrl-imx.c
> @@ -778,10 +778,10 @@ int imx_pinctrl_probe(struct platform_device *pdev,
>  	imx_pinctrl_desc->name = dev_name(&pdev->dev);
>  	imx_pinctrl_desc->pins = info->pins;
>  	imx_pinctrl_desc->npins = info->npins;
> -	imx_pinctrl_desc->pctlops = &imx_pctrl_ops,
> -	imx_pinctrl_desc->pmxops = &imx_pmx_ops,
> -	imx_pinctrl_desc->confops = &imx_pinconf_ops,
> -	imx_pinctrl_desc->owner = THIS_MODULE,
> +	imx_pinctrl_desc->pctlops = &imx_pctrl_ops;
> +	imx_pinctrl_desc->pmxops = &imx_pmx_ops;
> +	imx_pinctrl_desc->confops = &imx_pinconf_ops;
> +	imx_pinctrl_desc->owner = THIS_MODULE;
>
>  	ret = imx_pinctrl_probe_dt(pdev, info);
>  	if (ret) {
>

excellent catch, my compiler does not report the issue.

Subject and commit message are not quite informative, but
the change is trivial, so please feel free to add my

Reviewed-by: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>

--
With best wishes,
Vladimir

[toc] | [prev] | [next] | [standalone]

#1529762

FromPeng Fan <van.freenix@gmail.com>
Date2016-11-25 02:20 +0100
Message-ID<sHdlg-2h1-3@gated-at.bofh.it>
In reply to#1529603
Hi Gary,

On Thu, Nov 24, 2016 at 07:11:51PM +0100, Gary Bisson wrote:
>Was introduced by:
>6e408ed pinctrl: imx: fix initialization of imx_pinctrl_desc
>
>Signed-off-by: Gary Bisson <gary.bisson@boundarydevices.com>
>---
> drivers/pinctrl/freescale/pinctrl-imx.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/drivers/pinctrl/freescale/pinctrl-imx.c b/drivers/pinctrl/freescale/pinctrl-imx.c
>index 79c4e14..5ef7e87 100644
>--- a/drivers/pinctrl/freescale/pinctrl-imx.c
>+++ b/drivers/pinctrl/freescale/pinctrl-imx.c
>@@ -778,10 +778,10 @@ int imx_pinctrl_probe(struct platform_device *pdev,
> 	imx_pinctrl_desc->name = dev_name(&pdev->dev);
> 	imx_pinctrl_desc->pins = info->pins;
> 	imx_pinctrl_desc->npins = info->npins;
>-	imx_pinctrl_desc->pctlops = &imx_pctrl_ops,
>-	imx_pinctrl_desc->pmxops = &imx_pmx_ops,
>-	imx_pinctrl_desc->confops = &imx_pinconf_ops,
>-	imx_pinctrl_desc->owner = THIS_MODULE,
>+	imx_pinctrl_desc->pctlops = &imx_pctrl_ops;
>+	imx_pinctrl_desc->pmxops = &imx_pmx_ops;
>+	imx_pinctrl_desc->confops = &imx_pinconf_ops;
>+	imx_pinctrl_desc->owner = THIS_MODULE;

Thanks for the fix.

Reviewed-by: Peng Fan <peng.fan@nxp.com>

> 
> 	ret = imx_pinctrl_probe_dt(pdev, info);
> 	if (ret) {
>-- 
>2.9.3
>

--

[toc] | [prev] | [next] | [standalone]

#1530223

FromLinus Walleij <linus.walleij@linaro.org>
Date2016-11-25 14:20 +0100
Message-ID<sHoA1-129-7@gated-at.bofh.it>
In reply to#1529603
On Thu, Nov 24, 2016 at 7:11 PM, Gary Bisson
<gary.bisson@boundarydevices.com> wrote:

> Was introduced by:
> 6e408ed pinctrl: imx: fix initialization of imx_pinctrl_desc
>
> Signed-off-by: Gary Bisson <gary.bisson@boundarydevices.com>

Patch applied with the review tags.

Yours,
Linus Walleij

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web