Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1529679

Re: [PATCH] pinctrl: imx: fix imx_pinctrl_desc initialization

Show all headers | View raw

Hi Gary,

On 11/24/2016 08:11 PM, Gary Bisson wrote:
> Was introduced by:
> 6e408ed pinctrl: imx: fix initialization of imx_pinctrl_desc
>
> Signed-off-by: Gary Bisson <gary.bisson@boundarydevices.com>
> ---
>  drivers/pinctrl/freescale/pinctrl-imx.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/pinctrl/freescale/pinctrl-imx.c b/drivers/pinctrl/freescale/pinctrl-imx.c
> index 79c4e14..5ef7e87 100644
> --- a/drivers/pinctrl/freescale/pinctrl-imx.c
> +++ b/drivers/pinctrl/freescale/pinctrl-imx.c
> @@ -778,10 +778,10 @@ int imx_pinctrl_probe(struct platform_device *pdev,
>  	imx_pinctrl_desc->name = dev_name(&pdev->dev);
>  	imx_pinctrl_desc->pins = info->pins;
>  	imx_pinctrl_desc->npins = info->npins;
> -	imx_pinctrl_desc->pctlops = &imx_pctrl_ops,
> -	imx_pinctrl_desc->pmxops = &imx_pmx_ops,
> -	imx_pinctrl_desc->confops = &imx_pinconf_ops,
> -	imx_pinctrl_desc->owner = THIS_MODULE,
> +	imx_pinctrl_desc->pctlops = &imx_pctrl_ops;
> +	imx_pinctrl_desc->pmxops = &imx_pmx_ops;
> +	imx_pinctrl_desc->confops = &imx_pinconf_ops;
> +	imx_pinctrl_desc->owner = THIS_MODULE;
>
>  	ret = imx_pinctrl_probe_dt(pdev, info);
>  	if (ret) {
>

excellent catch, my compiler does not report the issue.

Subject and commit message are not quite informative, but
the change is trivial, so please feel free to add my

Reviewed-by: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>

--
With best wishes,
Vladimir

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] pinctrl: imx: fix imx_pinctrl_desc initialization Gary Bisson <gary.bisson@boundarydevices.com> - 2016-11-24 19:20 +0100
  Re: [PATCH] pinctrl: imx: fix imx_pinctrl_desc initialization Gary Bisson <gary.bisson@boundarydevices.com> - 2016-11-24 19:30 +0100
  Re: [PATCH] pinctrl: imx: fix imx_pinctrl_desc initialization Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com> - 2016-11-24 21:20 +0100
  Re: [PATCH] pinctrl: imx: fix imx_pinctrl_desc initialization Peng Fan <van.freenix@gmail.com> - 2016-11-25 02:20 +0100
  Re: [PATCH] pinctrl: imx: fix imx_pinctrl_desc initialization Linus Walleij <linus.walleij@linaro.org> - 2016-11-25 14:20 +0100

csiph-web