Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1522995 > unrolled thread

[PATCH] spi: spi-ti-qspi: reinit of completion variable

Back to article view | Back to linux.kernel

Contents

  [PATCH] spi: spi-ti-qspi: reinit of completion variable Prahlad V <prahlad.eee@gmail.com> - 2016-11-15 19:30 +0100
    Applied "spi: spi-ti-qspi: reinit of completion variable" to the spi tree Mark Brown <broonie@kernel.org> - 2016-11-15 20:00 +0100
    Re: [PATCH] spi: spi-ti-qspi: reinit of completion variable prahlad venkata <prahlad.eee@gmail.com> - 2016-11-22 08:30 +0100
      Re: [PATCH] spi: spi-ti-qspi: reinit of completion variable Mark Brown <broonie@kernel.org> - 2016-11-22 13:30 +0100

#1522995 — [PATCH] spi: spi-ti-qspi: reinit of completion variable

completion variable should be reinitialized before reusing.

Signed-off-by: Prahlad V <prahlad.eee@gmail.com>
---
 drivers/spi/spi-ti-qspi.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/spi/spi-ti-qspi.c b/drivers/spi/spi-ti-qspi.c
index caeac66..ec6fb09 100644
--- a/drivers/spi/spi-ti-qspi.c
+++ b/drivers/spi/spi-ti-qspi.c
@@ -411,6 +411,7 @@ static int ti_qspi_dma_xfer(struct ti_qspi *qspi, dma_addr_t dma_dst,
 	tx->callback = ti_qspi_dma_callback;
 	tx->callback_param = qspi;
 	cookie = tx->tx_submit(tx);
+	reinit_completion(&qspi->transfer_complete);
 
 	ret = dma_submit_error(cookie);
 	if (ret) {
-- 
2.9.2.729.ga42d7b6

[toc] | [next] | [standalone]

#1523019 — Applied "spi: spi-ti-qspi: reinit of completion variable" to the spi tree

The patch

   spi: spi-ti-qspi: reinit of completion variable

has been applied to the spi tree at

   git://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git 

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.  

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

From d06a3507fe7cfd85a296d2c1fe367dd850e9595f Mon Sep 17 00:00:00 2001
From: Prahlad V <prahlad.eee@gmail.com>
Date: Tue, 15 Nov 2016 23:56:43 +0530
Subject: [PATCH] spi: spi-ti-qspi: reinit of completion variable

completion variable should be reinitialized before reusing.

Signed-off-by: Prahlad V <prahlad.eee@gmail.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
 drivers/spi/spi-ti-qspi.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/spi/spi-ti-qspi.c b/drivers/spi/spi-ti-qspi.c
index caeac66a3977..ec6fb09e2e17 100644
--- a/drivers/spi/spi-ti-qspi.c
+++ b/drivers/spi/spi-ti-qspi.c
@@ -411,6 +411,7 @@ static int ti_qspi_dma_xfer(struct ti_qspi *qspi, dma_addr_t dma_dst,
 	tx->callback = ti_qspi_dma_callback;
 	tx->callback_param = qspi;
 	cookie = tx->tx_submit(tx);
+	reinit_completion(&qspi->transfer_complete);
 
 	ret = dma_submit_error(cookie);
 	if (ret) {
-- 
2.10.2

[toc] | [prev] | [next] | [standalone]

#1527270

Did anybody got chance to review this patch?
I feel this is a trivial yet required fix.

On Tue, Nov 15, 2016 at 11:56 PM, Prahlad V <prahlad.eee@gmail.com> wrote:
>
> completion variable should be reinitialized before reusing.
>
> Signed-off-by: Prahlad V <prahlad.eee@gmail.com>
> ---
>  drivers/spi/spi-ti-qspi.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/spi/spi-ti-qspi.c b/drivers/spi/spi-ti-qspi.c
> index caeac66..ec6fb09 100644
> --- a/drivers/spi/spi-ti-qspi.c
> +++ b/drivers/spi/spi-ti-qspi.c
> @@ -411,6 +411,7 @@ static int ti_qspi_dma_xfer(struct ti_qspi *qspi, dma_addr_t dma_dst,
>         tx->callback = ti_qspi_dma_callback;
>         tx->callback_param = qspi;
>         cookie = tx->tx_submit(tx);
> +       reinit_completion(&qspi->transfer_complete);
>
>         ret = dma_submit_error(cookie);
>         if (ret) {
> --
> 2.9.2.729.ga42d7b6
>



-- 
Regards,
Prahlad.
+91-9663742838

[toc] | [prev] | [next] | [standalone]

#1527456

[Multipart message — attachments visible in raw view] — view raw

On Tue, Nov 22, 2016 at 12:54:06PM +0530, prahlad venkata wrote:
> Did anybody got chance to review this patch?
> I feel this is a trivial yet required fix.

Please don't send content free pings and please allow a reasonable time
for review.  People get busy, go on holiday, attend conferences and so 
on so unless there is some reason for urgency (like critical bug fixes)
please allow at least a couple of weeks for review.  If there have been
review comments then people may be waiting for those to be addressed.

Sending content free pings adds to the mail volume (if they are seen at
all) which is often the problem and since they can't be reviewed
directly if something has gone wrong you'll have to resend the patches
anyway, though there are some other maintainers who like them - if in
doubt look at how patches for the subsystem are normally handled.

Please don't top post, reply in line with needed context.  This allows
readers to readily follow the flow of conversation and understand what
you are talking about and also helps ensure that everything in the
discussion is being addressed.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web