Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1527270

Re: [PATCH] spi: spi-ti-qspi: reinit of completion variable

Show all headers | View raw

Did anybody got chance to review this patch?
I feel this is a trivial yet required fix.

On Tue, Nov 15, 2016 at 11:56 PM, Prahlad V <prahlad.eee@gmail.com> wrote:
>
> completion variable should be reinitialized before reusing.
>
> Signed-off-by: Prahlad V <prahlad.eee@gmail.com>
> ---
>  drivers/spi/spi-ti-qspi.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/spi/spi-ti-qspi.c b/drivers/spi/spi-ti-qspi.c
> index caeac66..ec6fb09 100644
> --- a/drivers/spi/spi-ti-qspi.c
> +++ b/drivers/spi/spi-ti-qspi.c
> @@ -411,6 +411,7 @@ static int ti_qspi_dma_xfer(struct ti_qspi *qspi, dma_addr_t dma_dst,
>         tx->callback = ti_qspi_dma_callback;
>         tx->callback_param = qspi;
>         cookie = tx->tx_submit(tx);
> +       reinit_completion(&qspi->transfer_complete);
>
>         ret = dma_submit_error(cookie);
>         if (ret) {
> --
> 2.9.2.729.ga42d7b6
>



-- 
Regards,
Prahlad.
+91-9663742838

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] spi: spi-ti-qspi: reinit of completion variable Prahlad V <prahlad.eee@gmail.com> - 2016-11-15 19:30 +0100
  Applied "spi: spi-ti-qspi: reinit of completion variable" to the spi tree Mark Brown <broonie@kernel.org> - 2016-11-15 20:00 +0100
  Re: [PATCH] spi: spi-ti-qspi: reinit of completion variable prahlad venkata <prahlad.eee@gmail.com> - 2016-11-22 08:30 +0100
    Re: [PATCH] spi: spi-ti-qspi: reinit of completion variable Mark Brown <broonie@kernel.org> - 2016-11-22 13:30 +0100

csiph-web