Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1525595 > unrolled thread

[PATCH v4] staging: slicoss: fix different address space warnings

Back to article view | Back to linux.kernel

Contents

  [PATCH v4] staging: slicoss: fix different address space warnings Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-11-18 19:00 +0100
    [PATCH v4] staging: slicoss: fix different address space warnings Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-11-18 19:00 +0100
      Re: [PATCH v4] staging: slicoss: fix different address space warnings Greg KH <gregkh@linuxfoundation.org> - 2016-11-19 14:30 +0100
        Re: [PATCH v4] staging: slicoss: fix different address space warnings Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-11-20 09:30 +0100
          Re: [PATCH v4] staging: slicoss: fix different address space warnings Greg KH <gregkh@linuxfoundation.org> - 2016-11-21 11:10 +0100
            Re: [PATCH v4] staging: slicoss: fix different address space warnings Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-11-21 12:10 +0100

#1525595 — [PATCH v4] staging: slicoss: fix different address space warnings

This patchset fix the following sparse warning:
warning: incorrect type in assignment (different address spaces)

Changes in v2:
* Remove IOMEM_GET_FIELDADDR macro
* Add ioread64 and iowrite64 defines

Changes in v3:
* Remove ioread64 and iowrite64 defines
* Split into two patches: one for 32 bits stuff and the other for 64 bits.

Changes in v4:
* Undo all of previous changes and just remove __iomem annotation from 
field of struct because it is incorrect.

Sergio Paracuellos (1):
  staging: slicoss: fix different address space warnings

 drivers/staging/slicoss/slic.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
1.9.1

[toc] | [next] | [standalone]

#1525600

Remove incorrect __iomem annotation.

This patch fix the following sparse warnings in slicoss driver:
warning: incorrect type in assignment (different address spaces)

Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
---
 drivers/staging/slicoss/slic.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/slicoss/slic.h b/drivers/staging/slicoss/slic.h
index 420546d..14d7555 100644
--- a/drivers/staging/slicoss/slic.h
+++ b/drivers/staging/slicoss/slic.h
@@ -380,7 +380,7 @@ struct slic_shmemory {
 	dma_addr_t isr_phaddr;
 	dma_addr_t lnkstatus_phaddr;
 	dma_addr_t stats_phaddr;
-	struct slic_shmem_data __iomem *shmem_data;
+	struct slic_shmem_data *shmem_data;
 };
 
 struct slic_upr {
-- 
1.9.1

[toc] | [prev] | [next] | [standalone]

#1525991

On Fri, Nov 18, 2016 at 06:57:18PM +0100, Sergio Paracuellos wrote:
> Remove incorrect __iomem annotation.
> 
> This patch fix the following sparse warnings in slicoss driver:
> warning: incorrect type in assignment (different address spaces)
> 
> Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
> ---
>  drivers/staging/slicoss/slic.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/slicoss/slic.h b/drivers/staging/slicoss/slic.h
> index 420546d..14d7555 100644
> --- a/drivers/staging/slicoss/slic.h
> +++ b/drivers/staging/slicoss/slic.h
> @@ -380,7 +380,7 @@ struct slic_shmemory {
>  	dma_addr_t isr_phaddr;
>  	dma_addr_t lnkstatus_phaddr;
>  	dma_addr_t stats_phaddr;
> -	struct slic_shmem_data __iomem *shmem_data;
> +	struct slic_shmem_data *shmem_data;

But, is this the correct fix?  It looks like shmem_data is being treated
like a pointer to io memory, so we need to use the correct accessors for
that memory, and not just a "raw" pointer, right?  Removing this marking
seems to be moving backwards...

thanks,

greg k-h

[toc] | [prev] | [next] | [standalone]

#1526181

On Sat, Nov 19, 2016 at 2:20 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> On Fri, Nov 18, 2016 at 06:57:18PM +0100, Sergio Paracuellos wrote:
>> Remove incorrect __iomem annotation.
>>
>> This patch fix the following sparse warnings in slicoss driver:
>> warning: incorrect type in assignment (different address spaces)
>>
>> Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
>> ---
>>  drivers/staging/slicoss/slic.h | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/slicoss/slic.h b/drivers/staging/slicoss/slic.h
>> index 420546d..14d7555 100644
>> --- a/drivers/staging/slicoss/slic.h
>> +++ b/drivers/staging/slicoss/slic.h
>> @@ -380,7 +380,7 @@ struct slic_shmemory {
>>       dma_addr_t isr_phaddr;
>>       dma_addr_t lnkstatus_phaddr;
>>       dma_addr_t stats_phaddr;
>> -     struct slic_shmem_data __iomem *shmem_data;
>> +     struct slic_shmem_data *shmem_data;
>
> But, is this the correct fix?  It looks like shmem_data is being treated
> like a pointer to io memory, so we need to use the correct accessors for
> that memory, and not just a "raw" pointer, right?  Removing this marking
> seems to be moving backwards...

That was the intention of v3 of the patch. But after Dan suggestions I
though that just
removing this mark would be enough because it was wrong. I am a little
lost now :)

Cheers,
    Sergio Paracuellos

>
> thanks,
>
> greg k-h

[toc] | [prev] | [next] | [standalone]

#1526511

On Sun, Nov 20, 2016 at 09:21:51AM +0100, Sergio Paracuellos wrote:
> On Sat, Nov 19, 2016 at 2:20 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> > On Fri, Nov 18, 2016 at 06:57:18PM +0100, Sergio Paracuellos wrote:
> >> Remove incorrect __iomem annotation.
> >>
> >> This patch fix the following sparse warnings in slicoss driver:
> >> warning: incorrect type in assignment (different address spaces)
> >>
> >> Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
> >> ---
> >>  drivers/staging/slicoss/slic.h | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/staging/slicoss/slic.h b/drivers/staging/slicoss/slic.h
> >> index 420546d..14d7555 100644
> >> --- a/drivers/staging/slicoss/slic.h
> >> +++ b/drivers/staging/slicoss/slic.h
> >> @@ -380,7 +380,7 @@ struct slic_shmemory {
> >>       dma_addr_t isr_phaddr;
> >>       dma_addr_t lnkstatus_phaddr;
> >>       dma_addr_t stats_phaddr;
> >> -     struct slic_shmem_data __iomem *shmem_data;
> >> +     struct slic_shmem_data *shmem_data;
> >
> > But, is this the correct fix?  It looks like shmem_data is being treated
> > like a pointer to io memory, so we need to use the correct accessors for
> > that memory, and not just a "raw" pointer, right?  Removing this marking
> > seems to be moving backwards...
> 
> That was the intention of v3 of the patch. But after Dan suggestions I
> though that just
> removing this mark would be enough because it was wrong. I am a little
> lost now :)

Ok, I'm lost too, sorry.  I looked at the driver and shmem_data is
created by calling pci_zalloc_consistent, and that's not __iomem space,
but a real pointer.

So your patch is correct here, sorry for the noise, I'll go apply it.

thanks,

greg k-h

[toc] | [prev] | [next] | [standalone]

#1526572

On Mon, Nov 21, 2016 at 11:09 AM, Greg KH <gregkh@linuxfoundation.org> wrote:

> Ok, I'm lost too, sorry.  I looked at the driver and shmem_data is
> created by calling pci_zalloc_consistent, and that's not __iomem space,
> but a real pointer.
>
> So your patch is correct here, sorry for the noise, I'll go apply it.
>
> thanks,
>
> greg k-h

I was thinking that my English wasn't good enough and I was missing
something :-)

Thanks for let me know, Greg.

Cheers,
    Sergio Paracuellos

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web