Re: [PATCH v4] staging: slicoss: fix different address space warnings

From	Greg KH <gregkh@linuxfoundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v4] staging: slicoss: fix different address space warnings
Date	2016-11-21 11:10 +0100
Message-ID	<sFTHY-8fb-43@gated-at.bofh.it> (permalink)
References	<sEVCa-1Ow-1@gated-at.bofh.it> <sEVCa-1Ow-21@gated-at.bofh.it> <sFdSp-5rB-5@gated-at.bofh.it> <sFvFD-6O-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sun, Nov 20, 2016 at 09:21:51AM +0100, Sergio Paracuellos wrote:
> On Sat, Nov 19, 2016 at 2:20 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> > On Fri, Nov 18, 2016 at 06:57:18PM +0100, Sergio Paracuellos wrote:
> >> Remove incorrect __iomem annotation.
> >>
> >> This patch fix the following sparse warnings in slicoss driver:
> >> warning: incorrect type in assignment (different address spaces)
> >>
> >> Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
> >> ---
> >>  drivers/staging/slicoss/slic.h | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/staging/slicoss/slic.h b/drivers/staging/slicoss/slic.h
> >> index 420546d..14d7555 100644
> >> --- a/drivers/staging/slicoss/slic.h
> >> +++ b/drivers/staging/slicoss/slic.h
> >> @@ -380,7 +380,7 @@ struct slic_shmemory {
> >>       dma_addr_t isr_phaddr;
> >>       dma_addr_t lnkstatus_phaddr;
> >>       dma_addr_t stats_phaddr;
> >> -     struct slic_shmem_data __iomem *shmem_data;
> >> +     struct slic_shmem_data *shmem_data;
> >
> > But, is this the correct fix?  It looks like shmem_data is being treated
> > like a pointer to io memory, so we need to use the correct accessors for
> > that memory, and not just a "raw" pointer, right?  Removing this marking
> > seems to be moving backwards...
> 
> That was the intention of v3 of the patch. But after Dan suggestions I
> though that just
> removing this mark would be enough because it was wrong. I am a little
> lost now :)

Ok, I'm lost too, sorry.  I looked at the driver and shmem_data is
created by calling pci_zalloc_consistent, and that's not __iomem space,
but a real pointer.

So your patch is correct here, sorry for the noise, I'll go apply it.

thanks,

greg k-h

Thread

[PATCH v4] staging: slicoss: fix different address space warnings Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-11-18 19:00 +0100
  [PATCH v4] staging: slicoss: fix different address space warnings Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-11-18 19:00 +0100
    Re: [PATCH v4] staging: slicoss: fix different address space warnings Greg KH <gregkh@linuxfoundation.org> - 2016-11-19 14:30 +0100
      Re: [PATCH v4] staging: slicoss: fix different address space warnings Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-11-20 09:30 +0100
        Re: [PATCH v4] staging: slicoss: fix different address space warnings Greg KH <gregkh@linuxfoundation.org> - 2016-11-21 11:10 +0100
          Re: [PATCH v4] staging: slicoss: fix different address space warnings Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-11-21 12:10 +0100

csiph-web