Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1522531 > unrolled thread

[PATCH v2 1/1] mfd: intel-lpss: Try to enable Memory-Write-Invalidate

Back to article view | Back to linux.kernel

Contents

  [PATCH v2 1/1] mfd: intel-lpss: Try to enable Memory-Write-Invalidate Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-11-15 11:40 +0100
    Re: [PATCH v2 1/1] mfd: intel-lpss: Try to enable  Memory-Write-Invalidate Mika Westerberg <mika.westerberg@linux.intel.com> - 2016-11-17 10:10 +0100
    Re: [PATCH v2 1/1] mfd: intel-lpss: Try to enable  Memory-Write-Invalidate Lee Jones <lee.jones@linaro.org> - 2016-11-21 14:20 +0100

#1522531 — [PATCH v2 1/1] mfd: intel-lpss: Try to enable Memory-Write-Invalidate

Enable MWI mechanism if PCI bus master supports it.

It might be potential benefit in some cases. Documentation [1] says that
standard Memory Write might supply more current data than in the CPU modified
cache line and "trashing a line in the cache may trash some data that is more
current that in the memory line". This allows to avoid potential retries and
other performance degradation issues on the bus.

[1] PCI System Architecture, 4th edition, ISBN: 0-201-30974-2, pp.117-119.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
In v2:
- extend commit message
 drivers/mfd/intel-lpss-pci.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/mfd/intel-lpss-pci.c b/drivers/mfd/intel-lpss-pci.c
index 50e78db..4756153 100644
--- a/drivers/mfd/intel-lpss-pci.c
+++ b/drivers/mfd/intel-lpss-pci.c
@@ -41,6 +41,7 @@ static int intel_lpss_pci_probe(struct pci_dev *pdev,
 
 	/* Probably it is enough to set this for iDMA capable devices only */
 	pci_set_master(pdev);
+	pci_try_set_mwi(pdev);
 
 	ret = intel_lpss_probe(&pdev->dev, info);
 	if (ret)
-- 
2.9.3

[toc] | [next] | [standalone]

#1524172 — Re: [PATCH v2 1/1] mfd: intel-lpss: Try to enable Memory-Write-Invalidate

On Tue, Nov 15, 2016 at 12:37:04PM +0200, Andy Shevchenko wrote:
> Enable MWI mechanism if PCI bus master supports it.
> 
> It might be potential benefit in some cases. Documentation [1] says that
> standard Memory Write might supply more current data than in the CPU modified
> cache line and "trashing a line in the cache may trash some data that is more
> current that in the memory line". This allows to avoid potential retries and
> other performance degradation issues on the bus.
> 
> [1] PCI System Architecture, 4th edition, ISBN: 0-201-30974-2, pp.117-119.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>

[toc] | [prev] | [next] | [standalone]

#1526667 — Re: [PATCH v2 1/1] mfd: intel-lpss: Try to enable Memory-Write-Invalidate

On Tue, 15 Nov 2016, Andy Shevchenko wrote:

> Enable MWI mechanism if PCI bus master supports it.
> 
> It might be potential benefit in some cases. Documentation [1] says that
> standard Memory Write might supply more current data than in the CPU modified
> cache line and "trashing a line in the cache may trash some data that is more
> current that in the memory line". This allows to avoid potential retries and
> other performance degradation issues on the bus.
> 
> [1] PCI System Architecture, 4th edition, ISBN: 0-201-30974-2, pp.117-119.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> In v2:
> - extend commit message
>  drivers/mfd/intel-lpss-pci.c | 1 +
>  1 file changed, 1 insertion(+)

Applied, thanks.

> diff --git a/drivers/mfd/intel-lpss-pci.c b/drivers/mfd/intel-lpss-pci.c
> index 50e78db..4756153 100644
> --- a/drivers/mfd/intel-lpss-pci.c
> +++ b/drivers/mfd/intel-lpss-pci.c
> @@ -41,6 +41,7 @@ static int intel_lpss_pci_probe(struct pci_dev *pdev,
>  
>  	/* Probably it is enough to set this for iDMA capable devices only */
>  	pci_set_master(pdev);
> +	pci_try_set_mwi(pdev);
>  
>  	ret = intel_lpss_probe(&pdev->dev, info);
>  	if (ret)

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web