Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1525479 > unrolled thread
| Started by | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| First post | 2016-11-18 17:10 +0100 |
| Last post | 2016-11-21 12:30 +0100 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] mlxsw: switchib: add MLXSW_PCI dependency Arnd Bergmann <arnd@arndb.de> - 2016-11-18 17:10 +0100
Re: [PATCH] mlxsw: switchib: add MLXSW_PCI dependency David Miller <davem@davemloft.net> - 2016-11-18 20:20 +0100
Re: [PATCH] mlxsw: switchib: add MLXSW_PCI dependency Jiri Pirko <jiri@resnulli.us> - 2016-11-21 12:30 +0100
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Date | 2016-11-18 17:10 +0100 |
| Subject | [PATCH] mlxsw: switchib: add MLXSW_PCI dependency |
| Message-ID | <sETTH-Xh-11@gated-at.bofh.it> |
The newly added switchib driver fails to link if MLXSW_PCI=m: drivers/net/ethernet/mellanox/mlxsw/mlxsw_switchib.o: In function^Cmlxsw_sib_module_exit': switchib.c:(.exit.text+0x8): undefined reference to `mlxsw_pci_driver_unregister' switchib.c:(.exit.text+0x10): undefined reference to `mlxsw_pci_driver_unregister' drivers/net/ethernet/mellanox/mlxsw/mlxsw_switchib.o: In function `mlxsw_sib_module_init': switchib.c:(.init.text+0x28): undefined reference to `mlxsw_pci_driver_register' switchib.c:(.init.text+0x38): undefined reference to `mlxsw_pci_driver_register' switchib.c:(.init.text+0x48): undefined reference to `mlxsw_pci_driver_unregister' The other two such sub-drivers have a dependency, so add the same one here. In theory we could allow this driver if MLXSW_PCI is disabled, but it's probably not worth it. Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/net/ethernet/mellanox/mlxsw/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlxsw/Kconfig b/drivers/net/ethernet/mellanox/mlxsw/Kconfig index bac2e5e826e2..49237a24605e 100644 --- a/drivers/net/ethernet/mellanox/mlxsw/Kconfig +++ b/drivers/net/ethernet/mellanox/mlxsw/Kconfig @@ -31,7 +31,7 @@ config MLXSW_PCI config MLXSW_SWITCHIB tristate "Mellanox Technologies SwitchIB and SwitchIB-2 support" - depends on MLXSW_CORE && NET_SWITCHDEV + depends on MLXSW_CORE && MLXSW_PCI && NET_SWITCHDEV default m ---help--- This driver supports Mellanox Technologies SwitchIB and SwitchIB-2 -- 2.9.0
[toc] | [next] | [standalone]
| From | David Miller <davem@davemloft.net> |
|---|---|
| Date | 2016-11-18 20:20 +0100 |
| Subject | Re: [PATCH] mlxsw: switchib: add MLXSW_PCI dependency |
| Message-ID | <sEWRz-2PD-5@gated-at.bofh.it> |
| In reply to | #1525479 |
From: Arnd Bergmann <arnd@arndb.de> Date: Fri, 18 Nov 2016 17:01:14 +0100 > The newly added switchib driver fails to link if MLXSW_PCI=m: > > drivers/net/ethernet/mellanox/mlxsw/mlxsw_switchib.o: In function^Cmlxsw_sib_module_exit': > switchib.c:(.exit.text+0x8): undefined reference to `mlxsw_pci_driver_unregister' > switchib.c:(.exit.text+0x10): undefined reference to `mlxsw_pci_driver_unregister' > drivers/net/ethernet/mellanox/mlxsw/mlxsw_switchib.o: In function `mlxsw_sib_module_init': > switchib.c:(.init.text+0x28): undefined reference to `mlxsw_pci_driver_register' > switchib.c:(.init.text+0x38): undefined reference to `mlxsw_pci_driver_register' > switchib.c:(.init.text+0x48): undefined reference to `mlxsw_pci_driver_unregister' > > The other two such sub-drivers have a dependency, so add the same one > here. In theory we could allow this driver if MLXSW_PCI is disabled, > but it's probably not worth it. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Please resubmit this with a proper fixes tag that identifies the commit that added the switchib driver. Thanks.
[toc] | [prev] | [next] | [standalone]
| From | Jiri Pirko <jiri@resnulli.us> |
|---|---|
| Date | 2016-11-21 12:30 +0100 |
| Message-ID | <sFUXn-vK-3@gated-at.bofh.it> |
| In reply to | #1525479 |
Fri, Nov 18, 2016 at 05:01:14PM CET, arnd@arndb.de wrote: >The newly added switchib driver fails to link if MLXSW_PCI=m: > >drivers/net/ethernet/mellanox/mlxsw/mlxsw_switchib.o: In function^Cmlxsw_sib_module_exit': >switchib.c:(.exit.text+0x8): undefined reference to `mlxsw_pci_driver_unregister' >switchib.c:(.exit.text+0x10): undefined reference to `mlxsw_pci_driver_unregister' >drivers/net/ethernet/mellanox/mlxsw/mlxsw_switchib.o: In function `mlxsw_sib_module_init': >switchib.c:(.init.text+0x28): undefined reference to `mlxsw_pci_driver_register' >switchib.c:(.init.text+0x38): undefined reference to `mlxsw_pci_driver_register' >switchib.c:(.init.text+0x48): undefined reference to `mlxsw_pci_driver_unregister' > >The other two such sub-drivers have a dependency, so add the same one >here. In theory we could allow this driver if MLXSW_PCI is disabled, >but it's probably not worth it. > >Signed-off-by: Arnd Bergmann <arnd@arndb.de> Thanks. Reviewed-by: Jiri Pirko <jiri@mellanox.com>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web