Re: [PATCH] mlxsw: switchib: add MLXSW_PCI dependency

From	Jiri Pirko <jiri@resnulli.us>
Newsgroups	linux.kernel
Subject	Re: [PATCH] mlxsw: switchib: add MLXSW_PCI dependency
Date	2016-11-21 12:30 +0100
Message-ID	<sFUXn-vK-3@gated-at.bofh.it> (permalink)
References	<sETTH-Xh-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Fri, Nov 18, 2016 at 05:01:14PM CET, arnd@arndb.de wrote:
>The newly added switchib driver fails to link if MLXSW_PCI=m:
>
>drivers/net/ethernet/mellanox/mlxsw/mlxsw_switchib.o: In function^Cmlxsw_sib_module_exit':
>switchib.c:(.exit.text+0x8): undefined reference to `mlxsw_pci_driver_unregister'
>switchib.c:(.exit.text+0x10): undefined reference to `mlxsw_pci_driver_unregister'
>drivers/net/ethernet/mellanox/mlxsw/mlxsw_switchib.o: In function `mlxsw_sib_module_init':
>switchib.c:(.init.text+0x28): undefined reference to `mlxsw_pci_driver_register'
>switchib.c:(.init.text+0x38): undefined reference to `mlxsw_pci_driver_register'
>switchib.c:(.init.text+0x48): undefined reference to `mlxsw_pci_driver_unregister'
>
>The other two such sub-drivers have a dependency, so add the same one
>here. In theory we could allow this driver if MLXSW_PCI is disabled,
>but it's probably not worth it.
>
>Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Thanks.

Reviewed-by: Jiri Pirko <jiri@mellanox.com>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] mlxsw: switchib:  add MLXSW_PCI dependency Arnd Bergmann <arnd@arndb.de> - 2016-11-18 17:10 +0100
  Re: [PATCH] mlxsw: switchib: add MLXSW_PCI dependency David Miller <davem@davemloft.net> - 2016-11-18 20:20 +0100
  Re: [PATCH] mlxsw: switchib:  add MLXSW_PCI dependency Jiri Pirko <jiri@resnulli.us> - 2016-11-21 12:30 +0100

csiph-web