Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1517226 > unrolled thread

Re: [PATCH v2] ARC: [plat-eznps] set default baud for early console

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v2] ARC: [plat-eznps] set default baud for early console Alexey Brodkin <Alexey.Brodkin@synopsys.com> - 2016-11-08 15:10 +0100
    Re: [PATCH v2] ARC: [plat-eznps] set default baud for early console Alexey Brodkin <Alexey.Brodkin@synopsys.com> - 2016-11-08 15:20 +0100
    RE: [PATCH v2] ARC: [plat-eznps] set default baud for early console Noam Camus <noamca@mellanox.com> - 2016-11-08 15:40 +0100

#1517226 — Re: [PATCH v2] ARC: [plat-eznps] set default baud for early console

Hi Noam,

On Tue, 2016-11-08 at 15:20 +0200, Noam Camus wrote:
> From: Noam Camus <noamca@mellanox.com>
> 
> For CONFIG_SERIAL_EARLYCON we need 800MHz for NPS SoC
> The early console driver uses BASE_BAUD and not using dtb.
> 
> The default of 50MHz is NOT good for NPS SoC.
> 
> Signed-off-by: Noam Camus <noamca@mellanox.com>

Could you please provide a changelog (v1 -> v2) so reviewers
may have a hint about changes you made if any.

Regards,
Alexey

[toc] | [next] | [standalone]

#1517236

Hi Noam,

On Tue, 2016-11-08 at 14:13 +0000, Noam Camus wrote:
> > 
> > From: Alexey Brodkin [mailto:Alexey.Brodkin@synopsys.com] 
> > Sent: Tuesday, November 8, 2016 4:08 PM
> 
> > 
> > Could you please provide a changelog (v1 -> v2) so reviewers may have a hint about changes you made if any.
> ... Just fix some typos in log
> This line somehow was removed from patch while sending (It is at patch head followed by line with ---)
> Basically in V1 I wrote that default value is good while I meant is NOT good (fixed in V2).

Thanks for explanation.
IMHO it worth adding that kind of changelog on each next iteration so
please keep it in mind next time :)

-Alexey

[toc] | [prev] | [next] | [standalone]

#1517242

> From: Alexey Brodkin [mailto:Alexey.Brodkin@synopsys.com] 
> Sent: Tuesday, November 8, 2016 4:08 PM

>Could you please provide a changelog (v1 -> v2) so reviewers may have a hint about changes you made if any.
... Just fix some typos in log
This line somehow was removed from patch while sending (It is at patch head followed by line with ---)
Basically in V1 I wrote that default value is good while I meant is NOT good (fixed in V2).

Thanks,
Noam

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web