Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1517236

Re: [PATCH v2] ARC: [plat-eznps] set default baud for early console

From Alexey Brodkin <Alexey.Brodkin@synopsys.com>
Newsgroups linux.kernel
Subject Re: [PATCH v2] ARC: [plat-eznps] set default baud for early console
Date 2016-11-08 15:20 +0100
Message-ID <sBfpM-20X-27@gated-at.bofh.it> (permalink)
References <sBfg6-1XK-21@gated-at.bofh.it> <sBfg6-1XK-19@gated-at.bofh.it> <sBfpM-20X-29@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Hi Noam,

On Tue, 2016-11-08 at 14:13 +0000, Noam Camus wrote:
> > 
> > From: Alexey Brodkin [mailto:Alexey.Brodkin@synopsys.com] 
> > Sent: Tuesday, November 8, 2016 4:08 PM
> 
> > 
> > Could you please provide a changelog (v1 -> v2) so reviewers may have a hint about changes you made if any.
> ... Just fix some typos in log
> This line somehow was removed from patch while sending (It is at patch head followed by line with ---)
> Basically in V1 I wrote that default value is good while I meant is NOT good (fixed in V2).

Thanks for explanation.
IMHO it worth adding that kind of changelog on each next iteration so
please keep it in mind next time :)

-Alexey

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

Re: [PATCH v2] ARC: [plat-eznps] set default baud for early console Alexey Brodkin <Alexey.Brodkin@synopsys.com> - 2016-11-08 15:10 +0100
  Re: [PATCH v2] ARC: [plat-eznps] set default baud for early console Alexey Brodkin <Alexey.Brodkin@synopsys.com> - 2016-11-08 15:20 +0100
  RE: [PATCH v2] ARC: [plat-eznps] set default baud for early console Noam Camus <noamca@mellanox.com> - 2016-11-08 15:40 +0100

csiph-web