Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1468850 > unrolled thread

Re: [PATCH v10 4/8] i2c: thunderx: Add SMBUS alert support

Started byWolfram Sang <wsa@the-dreams.de>
First post2016-08-23 23:00 +0200
Last post2016-08-23 23:50 +0200
Articles 2 — 1 participant

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH v10 4/8] i2c: thunderx: Add SMBUS alert support Wolfram Sang <wsa@the-dreams.de> - 2016-08-23 23:00 +0200
    Re: [PATCH v10 4/8] i2c: thunderx: Add SMBUS alert support Wolfram Sang <wsa@the-dreams.de> - 2016-08-23 23:50 +0200

#1468850 — Re: [PATCH v10 4/8] i2c: thunderx: Add SMBUS alert support

FromWolfram Sang <wsa@the-dreams.de>
Date2016-08-23 23:00 +0200
SubjectRe: [PATCH v10 4/8] i2c: thunderx: Add SMBUS alert support
Message-ID<s9qXE-H7-19@gated-at.bofh.it>

[Multipart message — attachments visible in raw view] — view raw

On Wed, Jun 15, 2016 at 03:51:30PM +0200, Jan Glauber wrote:
> Add SMBUS alert interrupt support. For now only device tree is
> supported for specifying the alert. In case of ACPI an error
> is returned.
> 
> Signed-off-by: Jan Glauber <jglauber@cavium.com>

What about 'select I2C_SMBUS' in Kconfig and skip all the ifdeffery?

[toc] | [next] | [standalone]


#1468899

FromWolfram Sang <wsa@the-dreams.de>
Date2016-08-23 23:50 +0200
Message-ID<s9rK2-1fM-9@gated-at.bofh.it>
In reply to#1468850

[Multipart message — attachments visible in raw view] — view raw

On Tue, Aug 23, 2016 at 11:28:59PM +0200, Jan Glauber wrote:
> On Tue, Aug 23, 2016 at 10:57:25PM +0200, Wolfram Sang wrote:
> > On Wed, Jun 15, 2016 at 03:51:30PM +0200, Jan Glauber wrote:
> > > Add SMBUS alert interrupt support. For now only device tree is
> > > supported for specifying the alert. In case of ACPI an error
> > > is returned.
> > > 
> > > Signed-off-by: Jan Glauber <jglauber@cavium.com>
> > 
> > What about 'select I2C_SMBUS' in Kconfig and skip all the ifdeffery?
> > 
> 
> Wouldn't that prevent a distribution that has I2C_HELPER_AUTO set
> from enabling the ThunderX i2c driver at all?

From commit e2ca307439fb9df922c3e8891289a2ac05812fb7:

...
Bus drivers which implement SMBus alert should select this option, so
in most cases this option is hidden and the user doesn't have to care
about it.

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web